MGTwoLevelTransferCopyToHost #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanMoulday
changed the title
tjhei
reviewed
Oct 1, 2025
| * An abstract base class for transfer operators between two multigrid levels. | ||
| * The implementation of | ||
| * restriction and prolongation between levels is delegated to derived classes, | ||
| * which implement prolongate_and_add_internal() and restrict_and_add_internal() |
RyanMoulday
force-pushed
the
MGTwoLevelTransferCopyToHost
branch
from
80576a3 to
c696016
Compare
tjhei
reviewed
Oct 6, 2025
| MemorySpace::Default>>, | ||
| "This class is currently only implemented for vectors of " | ||
| "type LinearAlgebra::distributed::Vector."); | ||
| /** |
| * Default constructor. | ||
| */ | ||
| MGTwoLevelTransferBase(); | ||
| MGTwoLevelTransferBase() |
Owner
There was a problem hiding this comment.
Suggested change
| MGTwoLevelTransferBase() | |
| MGTwoLevelTransferBase() = default; |
| MemorySpace::Host>> || | ||
| std::is_same_v< | ||
| VectorType, | ||
| LinearAlgebra::distributed::Vector<typename VectorType::value_type, |
|
|
||
| /** | ||
| * A class which provides extra functionality used by several MGTwoLevelTransfer | ||
| * schemes. |
Owner
There was a problem hiding this comment.
base class for nonnested and mgtransfertwolevel
| */ | ||
| using Number = typename VectorType::value_type; | ||
|
|
||
| using VectorTypeHost = LinearAlgebra::distributed::Vector<Number>; |
Owner
There was a problem hiding this comment.
Suggested change
| using VectorTypeHost = LinearAlgebra::distributed::Vector<Number>; | |
| using VectorTypeHost = LinearAlgebra::distributed::Vector<Number,MemorySpace::Host>; |
| VectorTypeHost dst_host; | ||
| VectorTypeHost src_host; | ||
|
|
||
| copy_to_host(dst_host, dst); |
| VectorTypeHost dst_host; | ||
| VectorTypeHost src_host; | ||
|
|
||
| dst_host.reinit(dst.get_partitioner()); |
| interpolate(VectorType &dst, const VectorType &src) const override | ||
| { | ||
| VectorTypeHost dst_host; | ||
| VectorTypeHost src_host; |
| src.get_partitioner()->locally_owned_range()); | ||
| rw_vector.import_elements(src, VectorOperation::insert); | ||
|
|
||
| dst.reinit(src.get_partitioner()); |
| return {t->dof_handler_fine, t->mg_level_fine}; | ||
| } | ||
|
|
||
| if (const auto t = dynamic_cast<const MGTwoLevelTransferCopyToHost< |
Owner
There was a problem hiding this comment.
might need constexpr if memoryspace==::default
RyanMoulday
force-pushed
the
MGTwoLevelTransferCopyToHost
branch
from
c696016 to
438684e
Compare
tjhei
approved these changes
Oct 6, 2025
Owner
tjhei
left a comment
tjhei
left a comment
There was a problem hiding this comment.
Looks good. Feel free to open the PR to deal.II.
| * An abstract base class for transfer operators between two multigrid levels. | ||
| * The implementation of | ||
| * restriction and prolongation between levels is delegated to derived classes, | ||
| * which implement prolongate_and_add_internal() and restrict_and_add_internal() |
| /** | ||
| * Default constructor. | ||
| */ | ||
| MGTwoLevelTransferCore(); |
Owner
There was a problem hiding this comment.
either do = default; or update the comment to just say "constructor" if you need it to do something. :-)
| /** | ||
| * Vectors used for the host transfer. | ||
| */ | ||
|
|
| // &, | ||
| // const LinearAlgebra::distributed::Vector<S2, MemorySpace::Host> &, | ||
| // const bool) const; | ||
| // MGLevelGlobalTransfer<LinearAlgebra::distributed::Vector<S1, |
Owner
There was a problem hiding this comment.
why are these here? you can delete these lines, I think.
RyanMoulday
force-pushed
the
MGTwoLevelTransferCopyToHost
branch
6 times, most recently
from
1a5aff7 to
c62d29c
Compare
…rmits transfer on device vectors via use of an internal MGTwoLevelTransfer class defined on the host.
RyanMoulday
force-pushed
the
MGTwoLevelTransferCopyToHost
branch
from
c62d29c to
d2efed8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.