Skip to content

Commit abb846f

Browse files
committed
ci: correct the e2e comments now that E2E is a required check
The ruleset now requires the E2E summary, so the comments claiming e2e is advisory and kept out of branch protection are wrong: a flaky dhtproxy endpoint can now block merges. Update both to say so. Signed-off-by: Date Huang <tjjh89017@hotmail.com>
1 parent 5ba5d64 commit abb846f

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

.github/workflows/main.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -199,10 +199,9 @@ jobs:
199199

200200
# Runtime test of the real publish -> opendht -> establish pipeline with two
201201
# live WireGuard interfaces, running the exact binary the build stage produced.
202-
# It depends on the public dhtproxy endpoints and outbound STUN, so it is not a
203-
# required check; failures are advisory. The action branches per os; freebsd
204-
# runs in a VM on a Linux host (arm64 -> arm64 host for native virt). See
205-
# test/e2e/.
202+
# It depends on the public dhtproxy endpoints and outbound STUN, so a flaky
203+
# endpoint can block merges. The action branches per os; freebsd runs in a VM
204+
# on a Linux host (arm64 -> arm64 host for native virt). See test/e2e/.
206205
e2e:
207206
name: E2E (${{ matrix.os }}/${{ matrix.arch }})
208207
# build-plugins-required is a gate, not an artifact source: e2e uses the
@@ -230,9 +229,7 @@ jobs:
230229
app-name: ${{ env.APP }}
231230

232231
# One stable check aggregating the e2e matrix, mirroring the other summary
233-
# gates. It stays advisory (kept out of branch protection): e2e depends on the
234-
# public dhtproxy endpoints and outbound STUN, and that flakiness must not
235-
# block merges. The single E2E check is for a clean PR view, not to require.
232+
# gates. The ruleset requires it, so all six cells must pass to merge.
236233
e2e-required:
237234
name: E2E
238235
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)