Documented Android flash:"on" quirk after finding out that setting focus mode to CONTINUOUS_PICTURE or CONTINUOUS_VIDEO actually gave poorer results (flash only turned on during the first autofocus attempt, if at all - may be device dependent)

Author: tjwoon

README.md

@@ -26,7 +26,7 @@ Arguments:
         text_title: "OPTIONAL Title Text - default = 'Scan QR Code'", // Android only
         text_instructions: "OPTIONAL Instruction Text - default = 'Please point your camera at the QR code.'", // Android only
         camera: "front" || "back" // defaults to "back"
-        flash: "on" || "off" || "auto" // defaults to "auto"
+        flash: "on" || "off" || "auto" // defaults to "auto". See Quirks
     }
     ```
 
@@ -43,3 +43,8 @@ Status:
 
 - Android: DONE
 - iOS: DONE
+
+Quirks:
+
+- __Android__: Flash "on" may cause the flash to alternate between on and off
+  at about a half second/one second interval, instead of making it stay on...

android/ZBarScannerActivity.java

@@ -342,7 +342,11 @@ private void tryStartPreview () {
                 camera.setPreviewDisplay(holder);
                 camera.setPreviewCallback(previewCb);
                 camera.startPreview();
-                camera.autoFocus(autoFocusCb);
+                camera.autoFocus(autoFocusCb); // We are not using any of the
+                    // continuous autofocus modes as that does not seem to work
+                    // well with flash setting of "on"... At least with this
+                    // simple and stupid focus method, we get to turn the flash
+                    // on during autofocus.
             } catch (IOException e) {
                 die("Could not start camera preview: " + e.getMessage());
             }