Skip to content

Commit 7c27eaf

Browse files
committed
update snapshot tests
1 parent 6e9a95f commit 7c27eaf

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

backend/tests_e2e/test_e2e.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -627,7 +627,11 @@ def test_protein_detail_egfp(page: Page, live_server: LiveServer, assert_snapsho
627627
page.goto(url)
628628
expect(page).to_have_url(url)
629629
page.wait_for_load_state("networkidle")
630-
assert_snapshot(page)
630+
if not hasattr(assert_snapshot, "NOOP"):
631+
# Wait for chart to fully render
632+
page.locator(".highcharts-series").first.wait_for(state="attached")
633+
# Mask legend as it has minor rendering variations
634+
assert_snapshot(page, mask_elements=[".highcharts-legend"])
631635

632636
# scroll to the structure section and take another snapshot
633637
page.locator("#protein-structure").scroll_into_view_if_needed()
@@ -637,7 +641,9 @@ def test_protein_detail_egfp(page: Page, live_server: LiveServer, assert_snapsho
637641
expect(page.locator("img#smilesImg")).to_be_visible()
638642

639643
page.wait_for_load_state("networkidle")
640-
assert_snapshot(page)
644+
# Mask the 3D structure viewer as it renders with animation/randomness
645+
# Mask both the viewer div and its parent container to ensure full coverage
646+
assert_snapshot(page, mask_elements=["#protein-structure .col-12.col-md-6.order-2.order-md-1"])
641647

642648

643649
def test_favorite_button_interaction(

backend/tests_e2e/test_spectra_viewer.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,12 @@ def test_spectra_viewer_add_from_input(spectra_viewer: Page, assert_snapshot: Ca
5252
# a NEW search input should appear after selecting a protein
5353
tab_wrapper = spectra_viewer.locator(".tab-wrapper")
5454
expect(tab_wrapper.get_by_text("Type to search...")).to_be_visible()
55-
assert_snapshot(spectra_viewer)
55+
if not hasattr(assert_snapshot, "NOOP"):
56+
# Wait for chart to fully render
57+
spectra_viewer.locator(".highcharts-series").first.wait_for(state="attached")
58+
spectra_viewer.wait_for_load_state("networkidle")
59+
# Mask legend as it has minor rendering variations
60+
assert_snapshot(spectra_viewer, mask_elements=[".highcharts-legend"])
5661

5762

5863
@pytest.mark.parametrize("method", ["spacebar", "click"])
@@ -90,7 +95,12 @@ def test_spectra_viewer_add_from_spacebar(spectra_viewer: Page, assert_snapshot:
9095
# ... and a selector for EGFP should now be visible
9196
expect(tab_wrapper.get_by_text(re.compile(r"^EGFP"))).to_be_visible()
9297

93-
assert_snapshot(spectra_viewer)
98+
if not hasattr(assert_snapshot, "NOOP"):
99+
# Wait for chart to fully render
100+
spectra_viewer.locator(".highcharts-series").first.wait_for(state="attached")
101+
spectra_viewer.wait_for_load_state("networkidle")
102+
# Mask legend as it has minor rendering variations
103+
assert_snapshot(spectra_viewer, mask_elements=[".highcharts-legend"])
94104

95105

96106
def test_spectra_url_sharing_basic(live_server: LiveServer, page: Page) -> None:

0 commit comments

Comments
 (0)