LS4 build error on macOS

[ahelwer]

When building on macOS, I get the following error:

+ patch -p0
In file included from /Users/ahelwer/src/tlaplus/proof/_build/default/deps/ls4/ls4-1.0/core/Main.cc:34:
../utils/Options.h:285:33: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  285 |             fprintf(stderr, "%4"PRIi64, range.begin);
      |                                 ^
      |
../utils/Options.h:291:33: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  291 |             fprintf(stderr, "%4"PRIi64, range.end);
      |                                 ^
      |
../utils/Options.h:293:40: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  293 |         fprintf(stderr, "] (default: %"PRIi64")\n", value);
      |                                        ^
      |
3 errors generated.
In file included from /Users/ahelwer/src/tlaplus/proof/_build/default/deps/ls4/ls4-1.0/core/Solver.cc:30:
In file included from ../core/Solver.h:33:
../utils/Options.h:285:33: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  285 |             fprintf(stderr, "%4"PRIi64, range.begin);
      |                                 ^
      |
../utils/Options.h:291:33: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  291 |             fprintf(stderr, "%4"PRIi64, range.end);
      |                                 ^
      |
../utils/Options.h:293:40: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  293 |         fprintf(stderr, "] (default: %"PRIi64")\n", value);
      |                                        ^
      |
3 errors generated.
In file included from /Users/ahelwer/src/tlaplus/proof/_build/default/deps/ls4/ls4-1.0/core/Main.cc:34:
../utils/Options.h:285:33: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  285 |             fprintf(stderr, "%4"PRIi64, range.begin);
      |                                 ^
      |
../utils/Options.h:291:33: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  291 |             fprintf(stderr, "%4"PRIi64, range.end);
      |                                 ^
      |
../utils/Options.h:293:40: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
  293 |         fprintf(stderr, "] (default: %"PRIi64")\n", value);
      |                                        ^
      |
3 errors generated.
make[2]: *** [/Users/ahelwer/src/tlaplus/proof/_build/default/deps/ls4/ls4-1.0/core/Main.o] Error 1
make[1]: *** [ls4-1.0] Error 2
make: *** [build] Error 1

I've run into errors of these sorts before on other projects when building on macOS, which seems to use C++11 by default. I guess the question is whether we need to add a flag to force an earlier version of C++ or what.

[kape1395]

Something similar was fixed recently in the main (#215).

[ahelwer]

Agh, silly me not pulling before building! Closed.