Skip to content

Commit 26e4ce7

Browse files
author
tlipinski
committed
Fix scrolling logic by adjusting max_offset calculation to prevent overflow errors
1 parent f6c6514 commit 26e4ce7

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/app.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -296,12 +296,12 @@ impl App {
296296
self.error_output_opt = None
297297
}
298298
UiCmd::ScrollDown => {
299-
let max_offset = self.main_output().lines.len() as u16 - self.output_height;
300-
self.offset.y = self.offset.y.saturating_add(1).min(max_offset);
299+
let max_offset = self.main_output().lines.len().saturating_sub(self.output_height as usize);
300+
self.offset.y = self.offset.y.saturating_add(1).min(max_offset as u16);
301301
}
302302
UiCmd::ScrollDownPage => {
303-
let max_offset = self.main_output().lines.len() as u16 - self.output_height;
304-
self.offset.y = self.offset.y.saturating_add(10).min(max_offset);
303+
let max_offset = self.main_output().lines.len().saturating_sub(self.output_height as usize);
304+
self.offset.y = self.offset.y.saturating_add(10).min(max_offset as u16);
305305
}
306306
UiCmd::ScrollUp => {
307307
self.offset.y = self.offset.y.saturating_sub(1);

0 commit comments

Comments
 (0)