Collection was modified; enumeration operation may not execute.

[bazarniy]

Hey guys! I have multithreading exception for you.

FlurlClientCache bangs in CreateBuilder() foreach with "Collection was modified; enumeration operation may not execute." when another thread calls WithDefaults method. Please make collection copy before call foreach.

I am understand that in real world we make just one call of singleton WithDefaults per application. But here I have integration tests who recreates container and have multiple calls in parralel (add defaults + create client). And I understand that I should call it just one time and I fix it in my code, but it is bad to have multithreading exceptions in singleton

[tmenier]

Thanks for reporting. I was likely less careful with methods that "shouldn't" normally be called from multiple threads, but it's hard to argue that it's not a bug. :)

[emiliaszynkowska]

Hi, I am also seeing this issue after upgrading from Flurl 3.x. What is the best workaround to avoid it?

(I'm using IFlurlClientCache with a client per URL approach)