Commit 1495fce
committed
Bench(fix[lgtm]): Skip the optional-dependency tests on what they import
why: Both tests guard on `opentelemetry`, but that namespace package arrives
transitively, so the guard passes wherever libtmux is installed. What the
modules under test actually import is `opentelemetry.sdk`, the OTLP
exporters, and rampa, all of which ship only in the optional `otel` group --
which CI does not install. The guard therefore never fired and the tests
failed on import instead of skipping, which was the stated intent.
what:
- Guard on `opentelemetry.sdk` rather than the namespace package
- Guard the load scenario on rampa as well, since it imports both
Verified in both directions: without the group the two skip, and with it
installed they still run and pass rather than being silently disabled.1 parent f224e44 commit 1495fce
1 file changed
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
277 | 277 | | |
278 | 278 | | |
279 | 279 | | |
280 | | - | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
281 | 285 | | |
282 | 286 | | |
283 | 287 | | |
| |||
463 | 467 | | |
464 | 468 | | |
465 | 469 | | |
466 | | - | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
467 | 474 | | |
468 | 475 | | |
469 | 476 | | |
| |||
0 commit comments