Skip to content

Commit d166044

Browse files
authored
Merge pull request lightningdevkit#1480 from tnull/2022-05-fix-test-warnings
Fix unused code warnings test.
2 parents b5a6307 + 79f42d7 commit d166044

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

lightning/src/util/fairrwlock.rs

+1-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use std::sync::{TryLockResult, LockResult, RwLock, RwLockReadGuard, RwLockWriteGuard};
1+
use std::sync::{LockResult, RwLock, RwLockReadGuard, RwLockWriteGuard};
22
use std::sync::atomic::{AtomicUsize, Ordering};
33

44
/// Rust libstd's RwLock does not provide any fairness guarantees (and, in fact, when used on
@@ -32,10 +32,6 @@ impl<T> FairRwLock<T> {
3232
res
3333
}
3434

35-
pub fn try_write(&self) -> TryLockResult<RwLockWriteGuard<T>> {
36-
self.lock.try_write()
37-
}
38-
3935
pub fn read(&self) -> LockResult<RwLockReadGuard<T>> {
4036
if self.waiting_writers.load(Ordering::Relaxed) != 0 {
4137
let _write_queue_lock = self.lock.write();

lightning/src/util/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ pub mod persist;
2525
pub(crate) mod atomic_counter;
2626
pub(crate) mod byte_utils;
2727
pub(crate) mod chacha20;
28-
#[cfg(feature = "std")]
28+
#[cfg(all(not(test), feature = "std"))]
2929
pub(crate) mod fairrwlock;
3030
#[cfg(fuzzing)]
3131
pub mod zbase32;

lightning/src/util/test_utils.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -267,12 +267,12 @@ impl TestChannelMessageHandler {
267267
expected_msgs.as_mut().unwrap().push(ev);
268268
}
269269

270-
fn received_msg(&self, ev: wire::Message<()>) {
270+
fn received_msg(&self, _ev: wire::Message<()>) {
271271
let mut msgs = self.expected_recv_msgs.lock().unwrap();
272272
if msgs.is_none() { return; }
273273
assert!(!msgs.as_ref().unwrap().is_empty(), "Received message when we weren't expecting one");
274274
#[cfg(test)]
275-
assert_eq!(msgs.as_ref().unwrap()[0], ev);
275+
assert_eq!(msgs.as_ref().unwrap()[0], _ev);
276276
msgs.as_mut().unwrap().remove(0);
277277
}
278278
}

0 commit comments

Comments
 (0)