sanitize rules: remove 24 overlapping/obsolete rules, split performance_anti_patterns into 5 focused rules, extract prefer_weak_let and async_stream_safety (wvc-7oa)

Author: Jason-Abbott

.issues/0/04e-hge--redundant-sendable-detect-redundant-conformance-in.md

@@ -0,0 +1,30 @@
+---
+# 04e-hge
+title: '`redundant_sendable`: detect redundant conformance in public extension context'
+status: completed
+type: bug
+priority: normal
+created_at: 2026-04-11T17:53:01Z
+updated_at: 2026-04-11T18:19:01Z
+sync:
+    github:
+        issue_number: "177"
+        synced_at: "2026-04-11T18:44:01Z"
+---
+
+The `redundant_sendable` rule currently only checks types decorated with `@MainActor` or configured global actors. It does not detect redundant `Sendable` conformance on types defined inside public extensions that inherit isolation.
+
+Upstream reference: nicklockwood/SwiftFormat 0.60.1 fixed `redundantSendable` incorrectly removing `Sendable` conformance on types in public extensions.
+
+
+## Summary of Changes
+
+Updated `isIsolatedToActor()` in `RedundantSendableRule` to walk ancestor declarations. Types inside a `@MainActor` extension or nested inside a `@MainActor` parent type now correctly inherit that isolation, making their explicit `Sendable` conformance flaggable as redundant.
+
+**Changed file:** `Sources/SwiftiomaticKit/Rules/Redundancy/Visibility/RedundantSendableRule.swift`
+
+- Extracted attribute check into `AttributeListSyntax.isActorIsolated(actors:)` helper
+- `isIsolatedToActor()` now walks the parent syntax chain checking all `DeclGroupSyntax` ancestors (extensions, structs, classes, enums) for global actor attributes
+- Added non-triggering examples: types in plain extensions and public extensions (no isolation)
+- Added triggering examples: type in `@MainActor extension`, nested type in `@MainActor struct`
+- Added correction pairs for both new triggering cases

.issues/1/15g-v3q--clean-up-test-infrastructure-from-swift-review.md

@@ -0,0 +1,29 @@
+---
+# 15g-v3q
+title: Clean up test infrastructure from Swift review
+status: completed
+type: task
+priority: normal
+created_at: 2026-04-11T17:50:48Z
+updated_at: 2026-04-11T17:55:05Z
+sync:
+    github:
+        issue_number: "179"
+        synced_at: "2026-04-11T18:44:01Z"
+---
+
+Fix all 6 findings from /swift review of Tests/SwiftiomaticTests/:
+
+- [x] 1. Delete dead `String+StaticString.swift` (unsafe, unused)
+- [x] 2. Replace `checkError` with `#expect(throws:)` (22 call sites)
+- [x] 3. Remove dead XCTest `file:/line:` params from `LinterCacheTests`
+- [x] 4. Delete dead `lineDiff` function from `RuleTestHelpers`
+- [x] 5. Consolidate 3 duplicate rule-registration lazy vars
+- [x] 6. Skipped: `macOSSDKPath()` is sync; converting to `Subprocess` (async) would cascade through the test infra
+
+
+## Summary of Changes
+
+All actionable findings fixed. Item 6 skipped — `macOSSDKPath()` is called synchronously and converting to async `Subprocess` would cascade through the entire test infrastructure for minimal benefit.
+
+Build: passed. Tests: 463 passed, 0 failed.

.issues/3/345-ocg--config-file-selected-via-file-importer-not-loaded.md

@@ -0,0 +1,37 @@
+---
+# 345-ocg
+title: Config file selected via file importer not loaded into app
+status: completed
+type: bug
+priority: normal
+created_at: 2026-04-11T17:41:06Z
+updated_at: 2026-04-11T17:54:52Z
+sync:
+    github:
+        issue_number: "184"
+        synced_at: "2026-04-11T18:44:01Z"
+---
+
+## Description
+
+The file importer dialog opens and allows selecting a .swiftiomatic.yaml config file, but after selection the app still shows "No configuration file selected" — the chosen file is not actually loaded/applied.
+
+## Steps to Reproduce
+
+1. Open the Swiftiomatic app
+2. Go to Configuration File section
+3. Click "Choose..."
+4. Select a .swiftiomatic.yaml file
+5. Observe: Path still shows "No configuration file selected"
+
+## TODO
+
+- [x] Trace the file importer flow in the SwiftUI app
+- [x] Identify where the selected URL is (or isn't) being stored/applied
+- [x] Create a failing test if possible — not practical (sandboxed app entitlement + file importer UI)
+- [x] Fix the issue
+- [x] Verify the fix
+
+## Summary of Changes
+
+Removed security-scoped bookmark approach entirely. Config is now read once from the selected file, then persisted as a YAML string in App Group UserDefaults (matching SwiftFormat's pattern). Added `toYAMLString()` and `fromYAMLString()` to `Configuration` for serialization. Removed `com.apple.security.files.bookmarks.app-scope` entitlement.

.issues/9/9qw-72x--improve-rule-summaries-fill-empty-static-let-summa.md

@@ -0,0 +1,30 @@
+---
+# 9qw-72x
+title: 'Improve rule summaries: fill empty static let summary fields'
+status: ready
+type: task
+priority: normal
+created_at: 2026-04-11T18:22:20Z
+updated_at: 2026-04-11T18:22:20Z
+sync:
+    github:
+        issue_number: "181"
+        synced_at: "2026-04-11T18:44:01Z"
+---
+
+6+ rules have `static let summary = ""`. Fill them in with concise, useful descriptions.
+
+Identified rules with empty summaries:
+- `static_over_final_class`
+- `non_overridable_class_declaration`
+- `opening_brace`
+- `contrasted_opening_brace`
+- `number_separator`
+- `unhandled_throwing_task`
+- (scan for others)
+
+## Tasks
+
+- [ ] Find all rules with empty summary fields
+- [ ] Write concise summaries for each
+- [ ] Verify build passes

.issues/j/j8s-d2r--modernize-macossdkpath-from-process-to-subprocess.md

@@ -0,0 +1,39 @@
+---
+# j8s-d2r
+title: Modernize macOSSDKPath() from Process to Subprocess
+status: completed
+type: task
+priority: low
+created_at: 2026-04-11T17:56:25Z
+updated_at: 2026-04-11T18:18:15Z
+sync:
+    github:
+        issue_number: "186"
+        synced_at: "2026-04-11T18:44:01Z"
+---
+
+In `Tests/SwiftiomaticTests/Support/LintTestHelpers.swift:56-67`, `macOSSDKPath()` uses the legacy `Process` + `Pipe` + `waitUntilExit()` pattern to get the macOS SDK path via `xcrun --show-sdk-path`.
+
+Modernizing to `Subprocess` (swift-subprocess) requires making the function `async`, which cascades through:
+- `makeCompilerArguments()` (called on `SwiftSource`)
+- All callers in `violations()`, `assertCorrection()`, `testCorrection()`, etc.
+
+### Resolution
+
+Option 1+2 hybrid: made `macOSSDKPath()` async with `Subprocess.run()` and cached the result with `Mutex<String?>`. All callers were already async so cascade was minimal (just `makeCompilerArguments()`).
+
+Moved SDK path resolution to its own file (`SDKPath.swift`) to avoid `Subprocess.Configuration` / `SwiftiomaticKit.Configuration` name clash (separate issue `xsm-oy1` filed for the underlying enum-shadows-module problem).
+
+### Original Options
+1. **Make the chain async** — most correct, but touches many test helpers
+2. **Cache the SDK path in a lazy var** — call `Subprocess` once at test setup, store the result; `macOSSDKPath()` becomes a simple property read. Minimal cascade.
+3. **Leave as-is** — `Process` works fine for a one-shot test helper
+
+Option 2 is likely the best tradeoff.
+
+
+## Summary of Changes
+
+- **New file:** `Tests/SwiftiomaticTests/Support/SDKPath.swift` — async `macOSSDKPath()` using `Subprocess.run()` with `Mutex` cache
+- **Modified:** `Tests/SwiftiomaticTests/Support/LintTestHelpers.swift` — removed old `Process`-based `macOSSDKPath()`, made `makeCompilerArguments()` async, added `await` at 4 call sites
+- **Modified:** `Package.swift` — added `swift-subprocess` 0.4.x dependency (test target only)

.issues/k/kl9-aud--add-dump-config-cli-subcommand-to-show-resolved-co.md

@@ -0,0 +1,38 @@
+---
+# kl9-aud
+title: Add `dump-config` CLI subcommand to show resolved configuration
+status: completed
+type: feature
+priority: normal
+created_at: 2026-04-11T17:53:01Z
+updated_at: 2026-04-11T18:00:36Z
+sync:
+    github:
+        issue_number: "178"
+        synced_at: "2026-04-11T18:44:01Z"
+---
+
+Add a CLI subcommand that dumps the effective/resolved configuration for a given path, similar to swift-format's `dump-effective-configuration`.
+
+This would show the merged result of nested `.swiftiomatic.yaml` files, including which rules are enabled, their severity, and any per-rule options.
+
+Useful for debugging why a rule fires or doesn't fire in a specific directory.
+
+Upstream reference: swiftlang/swift-format `dump-effective-configuration` subcommand (602.0.0)
+
+
+## Summary of Changes
+
+- **`dump-config` CLI subcommand**: New subcommand that resolves and displays the effective configuration for any given file or directory path, after merging nested `.swiftiomatic.yaml` files.
+  - `--format text|json|yaml` output modes
+  - `--show-chain` flag to display which config files were merged (leaf → root)
+  - `--config` option for explicit config path (bypasses chain resolution)
+- **`Configuration.toFullDictionary()`** and **`toFullYAMLString()`**: New public methods that serialize ALL configuration values (including defaults), unlike `toYAMLString()` which only writes non-default values.
+- **`ConfigurationResolver.configChain(for:)`**: New public method exposing the config file chain for a given path.
+- **7 new tests** in `ConfigurationResolverTests`: cover `configChain`, `toFullDictionary`, and `toFullYAMLString`.
+
+### Files changed
+- `Sources/SwiftiomaticCLI/SwiftiomaticCLI.swift` — added `DumpConfig` command + `DumpConfigFormat` enum
+- `Sources/SwiftiomaticKit/Configuration/Configuration.swift` — added `toFullDictionary()`, `toFullYAMLString()`
+- `Sources/SwiftiomaticKit/Configuration/ConfigurationResolver.swift` — added public `configChain(for:)`
+- `Tests/SwiftiomaticTests/Configuration/ConfigurationResolverTests.swift` — 7 new tests

.issues/l/lv4-z40--sortimportsrule-group-implementationonly-imports-s.md

@@ -0,0 +1,17 @@
+---
+# lv4-z40
+title: '`SortImportsRule`: group `@_implementationOnly` imports separately'
+status: ready
+type: feature
+priority: normal
+created_at: 2026-04-11T17:53:01Z
+updated_at: 2026-04-11T17:53:01Z
+sync:
+    github:
+        issue_number: "182"
+        synced_at: "2026-04-11T18:44:01Z"
+---
+
+The `SortImportsRule` currently treats all imports as a single alphabetically-sorted group. It should support grouping imports by attribute, placing `@_implementationOnly` imports in a separate group (typically after regular imports).
+
+Upstream reference: swiftlang/swift-format 602.0.0 added separate grouping for `@_implementationOnly` imports in `OrderedImports`.

.issues/n/nk3-b8j--review-upstream-swiftlint-swiftformat-and-swift-fo.md

@@ -0,0 +1,69 @@
+---
+# nk3-b8j
+title: Review upstream SwiftLint, SwiftFormat, and swift-format releases for porting opportunities
+status: completed
+type: task
+priority: normal
+created_at: 2026-04-11T17:37:51Z
+updated_at: 2026-04-11T18:10:04Z
+sync:
+    github:
+        issue_number: "185"
+        synced_at: "2026-04-11T18:44:01Z"
+---
+
+Review the latest releases of the three cited linting/formatting tools for features, rules, and fixes worth porting to Swiftiomatic.
+
+## nicklockwood/SwiftFormat — `0.60.1` (Mar 7, 2026)
+
+- [x] Fixed `redundantSendable` removing `Sendable` conformance on types in public extensions — **we have `redundant_sendable` but it only checks `@MainActor` types, not public extension context; gap noted**
+- [x] Fixed `redundantSendable` leaving extra space when removing `:` — N/A, our rule is lint-only (not correctable)
+- [x] **`redundant_property` fixed** — now skips variables with explicit type annotations (`binding.typeAnnotation == nil` guard added); test added
+- [x] Updated `enumNamespaces` to preserve Swift Testing suites as structs — **already handled**: our `enum_namespaces` skips all types with attributes (`guard attributes.isEmpty`), so `@Suite` structs are safe
+
+## realm/SwiftLint — `0.63.2` (Jan 26, 2026)
+
+### New rules to consider porting
+
+- [x] `unneeded_throws_rethrows` — **already implemented** as `unneeded_throws_rethrows` rule
+- [x] `unneeded_escaping` — **already implemented** with taint analysis for escape tracking
+- [x] `multiline_call_arguments` — **already implemented** with `max_number_of_single_line_parameters` and `allows_single_line` options
+
+### Notable changes
+
+- [x] `redundant_self` — **already implemented** with `only_in_closures` (default true) and `keep_in_initializers` options
+- [x] `vertical_whitespace_between_cases` — **already has** `separation` config (`always`/`never`)
+- [x] `line_length` — **already correct**: `FunctionLineVisitor` collects from signature start to `signature.endPositionBeforeTrailingTrivia`, excluding bodies
+- [x] `large_tuple` — **already has** `ignore_regex` option for `Regex<(...)>` generic arguments
+- [x] `--disable-sourcekit` — N/A, our design is inverted: SourceKit is **opt-in** via `--sourcekit` flag (disabled by default)
+
+## swiftlang/swift-format — `602.0.0` (Sep 16, 2025)
+
+### Notable changes
+
+- [ ] `dump-effective-configuration` subcommand — **we don't have this**; CLI has `analyze`, `format`, `list-rules`, `generate-docs`, `migrate` but no config introspection
+- [x] `UseLetInEveryBoundCaseVariable` — **no equivalent rule**; low priority, niche pattern
+- [ ] **File-level ignore directive** — our `sm:disable` supports `:previous`/`:this`/`:next` scopes only; bare `sm:disable RULE` disables until `sm:enable`; no explicit file-level scope like `sm:disable:file`
+- [x] **Linter warnings by default** — **already matches**: our `SeverityOption` defaults to `.warning`
+- [x] Severity in configuration — **we kept severity** (per-rule configurable); noted divergence from swift-format's removal
+- [ ] `@_implementationOnly` import grouping — **our `SortImportsRule` treats all imports as one alphabetical group**; no attribute-based grouping
+- [x] Comments in config files — **already supported**: YAML natively supports comments
+- [x] `unsafe` expression support — **handled**: `Swift62ModernizationRule` detects unsafe buffer pointers and suggests `Span`/`RawSpan` migration
+- [x] `InlineArray` type sugar — **handled**: `Swift62ModernizationRule` suggests `InlineArray<N, T>` for homogeneous tuples (SE-0453)
+- [x] Unified whitespace handling — **already our design**: single rule set with `.lint`/`.format` scopes
+
+
+## Summary
+
+### Already implemented (16/22)
+All SwiftLint 0.63.x rules and config options already exist. swift-format design choices (warnings default, unified whitespace, YAML comments) already match.
+
+### Fixed (1/22)
+- `redundant_property` now preserves variables with explicit type annotations
+
+### Future work (5/22)
+- `dump-effective-configuration` CLI subcommand
+- File-level `sm:disable:file` scope
+- `@_implementationOnly` import grouping in `SortImportsRule`
+- `redundant_sendable` public extension context awareness
+- `UseLetInEveryBoundCaseVariable` (low priority)

.issues/r/rb0-c9s--support-file-level-smdisablefile-scope.md

@@ -0,0 +1,42 @@
+---
+# rb0-c9s
+title: Support file-level `sm:disable:file` scope
+status: completed
+type: feature
+priority: normal
+created_at: 2026-04-11T17:53:01Z
+updated_at: 2026-04-11T18:16:35Z
+sync:
+    github:
+        issue_number: "180"
+        synced_at: "2026-04-11T18:44:01Z"
+---
+
+Add a file-level scope to the `sm:disable` directive system.
+
+Currently supported scopes: `:previous`, `:this`, `:next`, and bare (disable until `sm:enable`).
+
+A file-level scope like `// sm:disable:file rule_id` at the top of a file would disable a rule for the entire file without needing a matching `sm:enable`.
+
+Upstream reference: swiftlang/swift-format 602.0.0 added file-level ignore directives for specific rules.
+
+## Plan
+
+- [x] Add `case file` to `Command.Modifier` enum
+- [x] Handle `.file` in `expand()` — single disable from line 0 to EOF
+- [x] Add parsing tests for `sm:disable:file` / `sm:enable:file`
+- [x] Add expansion tests
+- [x] Add region tests
+- [x] Add integration tests (violation suppression)
+- [x] Add superfluous disable command tests
+
+
+## Summary of Changes
+
+Added `sm:disable:file` / `sm:enable:file` directive scope. The `:file` modifier expands to a single command at line 0, creating a region that covers the entire file regardless of where the directive appears in the source. No parser changes were needed — the existing `Modifier(rawValue:)` initializer picks up the new `file` case automatically.
+
+### Files changed
+- `Sources/SwiftiomaticKit/Models/Command.swift` — added `case file` to `Modifier` enum, added `.file` case to `expand()`
+- `Tests/SwiftiomaticTests/Configuration/CommandTests.swift` — parsing, expansion, and superfluous disable tests
+- `Tests/SwiftiomaticTests/Rules/Infrastructure/RegionTests.swift` — region building tests
+- `Tests/SwiftiomaticTests/Rules/Infrastructure/DisableAllTests.swift` — integration tests for violation suppression