improve type safety, performance, and code sharing from swift review (#172)

Author: Jason-Abbott

.issues/o/oc9-otl--swift-review-modernization-shared-code-performance.md

@@ -0,0 +1,25 @@
+---
+# oc9-otl
+title: 'Swift review: modernization, shared code, performance'
+status: completed
+type: task
+priority: normal
+created_at: 2026-04-11T02:42:35Z
+updated_at: 2026-04-11T02:42:35Z
+sync:
+    github:
+        issue_number: "172"
+        synced_at: "2026-04-11T02:45:17Z"
+---
+
+## Changes
+
+- [x] Cache `CachedRegex.numberOfCaptureGroups` at init — avoids repeated `NSRegularExpression` allocation on every access
+- [x] Replace `SwiftLintConfigParser.ruleConfigs` from `nonisolated(unsafe) var [String: Any]` to `var [String: ConfigValue]` — removes `nonisolated(unsafe)` and `Any`
+- [x] Extract `DeclModifierListSyntax.accessibility` from fileprivate in MissingDocsRule to shared `SwiftSyntax+Declarations.swift`
+- [x] Extract OptionsTab inline Binding allocations to computed properties — avoids per-render closure re-creation
+- [x] Simplify `Array+Parallel.parallelMap` — replaced two `@unchecked Sendable` wrapper classes and `UnsafeMutableBufferPointer` manipulation with `Array(unsafeUninitializedCapacity:)` + `nonisolated(unsafe) let` bindings
+
+## Summary of Changes
+
+Five targeted improvements from swift review: one performance fix (cached regex capture groups), one type-safety fix (ConfigValue replacing Any), one shared code extraction (accessibility extension), one SwiftUI best practice (OptionsTab bindings), and one code simplification (parallel map). All 445 tests pass.

.jig.yaml

@@ -1,64 +1,75 @@
 nope:
   rules:
-          - name: git-no-verify
-            pattern: 'git\s+.*--no-verify'
-            message: "--no-verify is never allowed - fix the issue that's failing the hook instead"
-            #        - name: git-checkout-switch
-            #          pattern: 'git\s+(checkout|switch|stash)'
-            #          message: "git checkout/switch not allowed - branch changes require user approval"
-          - name: altering-jig
-            pattern: 'jig.yaml'
-            tools: ["Write", "Edit"]
-            message: "cannot reconfigure jig directly - print desired config and user will edit"
-          - name: bypassing-mcp
-            pattern: 'swift (build|test)'
-            message: "Use xc-mcp to build and test"
-          - name: altering-project
-            pattern: '\.(xcode|pbx)proj'
-            tools: ["Write", "Edit"]
-            message: "Project may only be modified using xc-mcp"
+    - name: git-no-verify
+      pattern: 'git\s+.*--no-verify'
+      message: "--no-verify is never allowed - fix the issue that's failing the hook instead"
+      #        - name: git-checkout-switch
+      #          pattern: 'git\s+(checkout|switch|stash)'
+      #          message: "git checkout/switch not allowed - branch changes require user approval"
+    - name: altering-jig
+      pattern: 'jig.yaml'
+      tools: [ "Write", "Edit" ]
+      message: "cannot reconfigure jig directly - print desired config and user will edit"
+    - name: bypassing-mcp
+      pattern: 'swift (build|test)'
+      message: "Use xc-mcp to build and test"
+    - name: altering-project
+      pattern: '\.(xcode|pbx)proj'
+      tools: [ "Write", "Edit" ]
+      message: "Project may only be modified using xc-mcp"
 companions:
-    brew: toba/homebrew-tap
+  brew: toba/homebrew-tap
 todo:
-    path: .issues
-    default_status: ready
-    default_type: task
-    sync:
-        github:
-            repo: toba/swiftiomatic
+  path: .issues
+  default_status: ready
+  default_type: task
+  sync:
+    github:
+      repo: toba/swiftiomatic
 citations:
-    - repo: swiftlang/swift-syntax
-      branch: main
-      notes: A set of Swift libraries for parsing, inspecting, generating, and transforming Swift source code.
-      paths:
-        high: [Sources/**/*.swift]
-        medium: [Package.swift]
-        low: [.github/**, README.md, LICENSE]
-    - repo: nicklockwood/SwiftFormat
-      branch: main
-      notes: A command-line tool and Xcode Extension for formatting Swift code
-      paths:
-        high: [Sources/**/*.swift]
-        medium: [Package.swift]
-        low: [.github/**, README.md, LICENSE]
-    - repo: realm/SwiftLint
-      branch: main
-      notes: A tool to enforce Swift style and conventions.
-      paths:
-        high: ['**/*.swift']
-        medium: [Package.swift]
-        low: [.github/**, README.md, LICENSE]
-    - repo: jpsim/SourceKitten
-      branch: main
-      notes: An adorable little framework and command line tool for interacting with SourceKit.
-      paths:
-        high: ['**/*.swift']
-        medium: [Package.swift]
-        low: [.github/**, README.md, LICENSE]
-    - repo: swiftlang/swift-format
-      branch: main
-      notes: Formatting technology for Swift source code
-      paths:
-        high: [Sources/**/*.swift]
-        medium: [Package.swift]
-        low: [.github/**, README.md, LICENSE]
+  - repo: swiftlang/swift-syntax
+    branch: main
+    notes: A set of Swift libraries for parsing, inspecting, generating, and transforming Swift source code.
+    last_checked_sha: aacb56bc763b70e27d4f66d901365b45531f76bd
+    last_checked_date: "2026-04-11T02:38:51Z"
+    paths:
+      high: [ Sources/**/*.swift ]
+      medium: [ Package.swift ]
+      low: [ .github/**, README.md, LICENSE ]
+  - repo: nicklockwood/SwiftFormat
+    branch: main
+    notes: A command-line tool and Xcode Extension for formatting Swift code
+    last_checked_sha: c8e50ff2cfc2eab46246c072a9ae25ab656c6ec3
+    last_checked_date: "2026-04-11T02:38:51Z"
+    paths:
+      high: [ Sources/**/*.swift ]
+      medium: [ Package.swift ]
+      low: [ .github/**, README.md, LICENSE ]
+  - repo: realm/SwiftLint
+    branch: main
+    notes: A tool to enforce Swift style and conventions.
+    last_checked_sha: bd662b7009942bfa163c349c7e8a31e8aee33a70
+    last_checked_date: "2026-04-11T02:38:51Z"
+    paths:
+      high: [ '**/*.swift' ]
+      medium: [ Package.swift ]
+      low: [ .github/**, README.md, LICENSE ]
+  - repo: jpsim/SourceKitten
+    branch: main
+    notes: An adorable little framework and command line tool for interacting with SourceKit.
+    last_checked_sha: 02d1db1084dde306a4f7fd7a85480d6a0f4831c4
+    last_checked_date: "2026-04-11T02:38:51Z"
+    paths:
+      high: [ '**/*.swift' ]
+      medium: [ Package.swift ]
+      low: [ .github/**, README.md, LICENSE ]
+  - repo: swiftlang/swift-format
+    branch: main
+    notes: Formatting technology for Swift source code
+    last_checked_sha: 6ddbafa85bff26c7a99c9c86295bbb44ed1a5bfb
+    last_checked_date: "2026-04-11T02:38:51Z"
+    paths:
+      high: [ Sources/**/*.swift ]
+      medium: [ Package.swift ]
+      low: [ .github/**, README.md, LICENSE ]
+changelog: weekly

.swiftiomatic.yaml

@@ -3,82 +3,82 @@ rules:
     unhandled_throwing_task:
       severity: warning
   disabled:
-  - blanket_disable_command
-  - closure_parameter_position
-  - cyclomatic_complexity
-  - file_length
-  - function_body_length
-  - function_parameter_count
-  - identifier_name
-  - inclusive_language
-  - function_parameter_count
-  - line_length
-  - mark
-  - multiple_closures_with_trailing_closure
-  - nesting
-  - opening_brace
-  - shorthand_argument
-  - opening_brace
-  - switch_case_alignment
-  - trailing_comma
-  - trailing_whitespace
-  - type_body_length
-  - type_name
-  - conditional_assignment
-  - doc_comments
-  - doc_comments_before_modifiers
-  - extension_access_control
-  - file_macro
-  - header_file_name
+    - blanket_disable_command
+    - closure_parameter_position
+    - cyclomatic_complexity
+    - file_length
+    - function_body_length
+    - function_parameter_count
+    - identifier_name
+    - inclusive_language
+    - function_parameter_count
+    - line_length
+    - mark
+    - multiple_closures_with_trailing_closure
+    - nesting
+    - opening_brace
+    - shorthand_argument
+    - opening_brace
+    - switch_case_alignment
+    - trailing_comma
+    - trailing_whitespace
+    - type_body_length
+    - type_name
+    - conditional_assignment
+    - doc_comments
+    - doc_comments_before_modifiers
+    - extension_access_control
+    - file_macro
+    - header_file_name
   enabled:
-  - async_without_await
-  - comma_inheritance
-  - convenience_type
-  - contains_over_filter_count
-  - contains_over_filter_is_empty
-  - first_where
-  - contains_over_range_nil_comparison
-  - discouraged_assert
-  - direct_return
-  - empty_collection_literal
-  - empty_collection_literal
-  - empty_string
-  - empty_xctest_method
-  - expiring_todo
-  - fatal_error_message
-  - file_name_no_space
-  - first_where
-  - flatmap_over_map_reduce
-  - identical_operands
-  - joined_default_parameter
-  - last_where
-  - legacy_multiple
-  - legacy_objc_type
-  - multiline_parameters
-  - operator_usage_whitespace
-  - optional_enum_case_matching
-  - pattern_matching_keywords
-  - period_spacing
-  - prefer_key_path
-  - prefer_self_type_over_type_of_self
-  - prefer_zero_over_explicit_init
-  - reduce_into
-  - redundant_nil_coalescing
-  - redundant_self
-  - redundant_sendable
-  - redundant_type_annotation
-  - return_value_from_void_function
-  - shorthand_optional_binding
-  - sorted_first_last
-  - toggle_bool
-  - unavailable_function
-  - unhandled_throwing_task
-  - unneeded_escaping
-  - unneeded_parentheses_in_closure_argument
-  - unneeded_throws_rethrows
-  - unused_declaration
-  - unused_import
-  - block_comments
-  - prefer_final_classes
-  - prefer_swift_testing
-  - url_macro
+    - async_without_await
+    - comma_inheritance
+    - convenience_type
+    - contains_over_filter_count
+    - contains_over_filter_is_empty
+    - first_where
+    - contains_over_range_nil_comparison
+    - discouraged_assert
+    - direct_return
+    - empty_collection_literal
+    - empty_collection_literal
+    - empty_string
+    - empty_xctest_method
+    - expiring_todo
+    - fatal_error_message
+    - file_name_no_space
+    - first_where
+    - flatmap_over_map_reduce
+    - identical_operands
+    - joined_default_parameter
+    - last_where
+    - legacy_multiple
+    - legacy_objc_type
+    - multiline_parameters
+    - operator_usage_whitespace
+    - optional_enum_case_matching
+    - pattern_matching_keywords
+    - period_spacing
+    - prefer_key_path
+    - prefer_self_type_over_type_of_self
+    - prefer_zero_over_explicit_init
+    - reduce_into
+    - redundant_nil_coalescing
+    - redundant_self
+    - redundant_sendable
+    - redundant_type_annotation
+    - return_value_from_void_function
+    - shorthand_optional_binding
+    - sorted_first_last
+    - toggle_bool
+    - unavailable_function
+    - unhandled_throwing_task
+    - unneeded_escaping
+    - unneeded_parentheses_in_closure_argument
+    - unneeded_throws_rethrows
+    - unused_declaration
+    - unused_import
+    - block_comments
+    - prefer_final_classes
+    - prefer_swift_testing
+    - url_macro

CHANGELOG.md

@@ -0,0 +1,19 @@
+# Changelog
+
+## Week of Apr 6 – Apr 12, 2026
+
+### ✨ Features
+
+- Inline suppression comments ([#166](https://github.com/toba/swiftiomatic/issues/166))
+- Config and inline comment migration tool ([#165](https://github.com/toba/swiftiomatic/issues/165))
+- Nested per-directory configuration ([#169](https://github.com/toba/swiftiomatic/issues/169))
+
+### 🐛 Fixes
+
+- Fix 7 test failures in Swiftiomatic test suite ([#126](https://github.com/toba/swiftiomatic/issues/126))
+
+### 🗜️ Tweaks
+
+- Setup brew installation within existing toba tap ([#171](https://github.com/toba/swiftiomatic/issues/171))
+- Build `assertLint`/`assertFormatting` test infrastructure ([#168](https://github.com/toba/swiftiomatic/issues/168))
+- Adopt Apple `swift-format` test patterns for comprehensive rule coverage ([#162](https://github.com/toba/swiftiomatic/issues/162))