address build warnings: replace data(using:) with Data(_:.utf8); drop ArraySlice/VariableDeclSyntax IUOs; convert IIFE to if/else expression; require Sendable on Configurable to silence C.Type captures; discard unused popLast results; minor lint cleanups

Author: Jason-Abbott

.issues/n/n9k-w1i--address-build-warnings-lint.md

@@ -0,0 +1,49 @@
+---
+# n9k-w1i
+title: Address build warnings (lint)
+status: completed
+type: task
+priority: normal
+created_at: 2026-05-02T23:14:23Z
+updated_at: 2026-05-03T03:06:48Z
+sync:
+    github:
+        issue_number: "639"
+        synced_at: "2026-05-03T03:11:04Z"
+---
+
+Fix lint warnings from Build sm_2026-05-02 log, excluding comment-related ones.
+
+- [x] noParensAroundConditions: TokenStream+Closures.swift:200,201
+- [x] noImplicitlyUnwrappedOptionals: WhitespaceLinter.swift:211,236
+- [x] useNonOptionalDataInit: ConfigurationSchema+Generated.swift (generator change)
+- [x] wrapTernaryBranches: TokenStream+ControlFlow.swift:26
+- [x] useReduceInto: Trivia+Convenience.swift:162
+- [x] useFirstWhere: DropRedundantReturn.swift:120
+- [x] dropRedundantClosureWrapper: NoCaseNamedNone.swift
+- [x] noImplicitlyUnwrappedOptionals: SplitMultipleDeclsPerLine.swift:261
+- [x] useCommaNotAndInConditions: RuleMask.swift:250
+- [x] Sendable capture warnings: Configuration.swift:107,111,113
+- [x] deprecated init: DropRedundantSetterACL.swift:108
+- [x] popLast unused result: LayoutSingleLineBodies.swift:974,988,1002,1016,1030
+
+
+
+## Summary of Changes
+
+Addressed all 20 non-comment lint warnings from the build log:
+
+- `TokenStream+Closures.swift`: dropped parens around boolean conditions
+- `WhitespaceLinter.swift`: replaced `ArraySlice!` IUOs with optionals + `?? 0` at use sites
+- `ConfigurationSchemaSwiftGenerator.swift` + `ConfigurationSchema+Generated.swift`: switched embedded JSON decode to `Data(string.utf8)`
+- `TokenStream+ControlFlow.swift`: wrapped ternary onto multiple lines
+- `Trivia+Convenience.swift`: converted `.reduce` to `.reduce(into:)` for COW seed
+- `DropRedundantReturn.swift`: collapsed `filter { ... }.first` into `first(where:)`
+- `NoCaseNamedNone.swift`: replaced immediately-invoked closure with `if`/`else if`/`else` expression
+- `SplitMultipleDeclsPerLine.swift`: replaced `varDecl: VariableDeclSyntax!` with optional + chained access
+- `RuleMask.swift`: replaced `&&` with `,` in if-condition
+- `Configurable.swift`: required `Sendable` conformance — fixes the three `C.Type` capture warnings in `Configuration.swift`
+- `DropRedundantSetterACL.swift`: dropped redundant `DeclModifierListSyntax(_:)` round-trip
+- `LayoutSingleLineBodies.swift`: discarded all five `popLast()` results with `_ =`
+
+Clean build + `swift_diagnostics` run after: 1 unrelated warning remains; original 20 all gone.

.jig.yaml

@@ -40,31 +40,31 @@ citations:
     - repo: swiftlang/swift-syntax
       branch: main
       last_checked_sha: 51c8c237beea1baa9cac64ef83cec68c6790506c
-      last_checked_date: "2026-05-02T17:31:17Z"
+      last_checked_date: "2026-05-03T03:09:08Z"
       paths:
         high: [Sources/**/*.swift]
         medium: [Package.swift]
         low: [.github/**, README.md, LICENSE]
     - repo: nicklockwood/SwiftFormat
       branch: main
       last_checked_sha: a5fa7a6a57abeb834df1b3fa43ea9133137d5ade
-      last_checked_date: "2026-05-02T17:31:17Z"
+      last_checked_date: "2026-05-03T03:09:08Z"
       paths:
         high: [Sources/**/*.swift]
         medium: [Package.swift]
         low: [.github/**, README.md, LICENSE]
     - repo: realm/SwiftLint
       branch: main
       last_checked_sha: ef026db5af6f768b44b43d5c3d744d6eabacd3db
-      last_checked_date: "2026-05-02T17:31:17Z"
+      last_checked_date: "2026-05-03T03:09:08Z"
       paths:
         high: ['**/*.swift']
         medium: [Package.swift]
         low: [.github/**, README.md, LICENSE]
     - repo: swiftlang/swift-format
       branch: main
       last_checked_sha: 4c86a1a7086b3eef3f55d2542926fa4c06fa70db
-      last_checked_date: "2026-05-02T17:31:17Z"
+      last_checked_date: "2026-05-03T03:09:08Z"
       paths:
         high: [Sources/**/*.swift]
         medium: [Package.swift]

CHANGELOG.md

@@ -45,6 +45,10 @@
 - `// sm:ignore:next`; new directive scoped to the next line only ([#620](https://github.com/toba/swiftiomatic/issues/620))
 - `guard`/`else`; always break before `else` when conditions wrap ([#635](https://github.com/toba/swiftiomatic/issues/635))
 
+### 🗜️ Tweaks
+
+- Address build warnings; replace `data(using:)` with `Data(_:.utf8)`, drop IUOs, switch IIFEs to `if`/`else` expressions, mark `Configurable` `Sendable`, discard unused `popLast` results ([#639](https://github.com/toba/swiftiomatic/issues/639))
+
 ### 🐞 Fixes
 
 - `useTrailingClosures`; anchor finding on the original pre-rewrite call instead of the detached `super.visit` result so the warning lands on the actual call site rather than line 1 ([#636](https://github.com/toba/swiftiomatic/issues/636))

Package.resolved

@@ -15,7 +15,7 @@ package func configurationKey(forTypeName name: String) -> String {
 ///
 /// Both syntax rules and layout settings conform to this protocol, unifying the concept of
 /// "something in the configuration that has a key and a default."
-package protocol Configurable {
+package protocol Configurable: Sendable {
     /// The type of the default value for this item.
     associatedtype Value: Sendable & Codable & Equatable
 

Sources/ConfigurationKit/Configurable.swift

@@ -27,9 +27,7 @@ package final class ConfigurationSchemaSwiftGenerator: FileGenerator {
                     let json = ##\"\"\"
             \(schemaJSON)
             \"\"\"##
-                    guard let data = json.data(using: .utf8) else {
-                        fatalError("Failed to encode embedded JSON Schema — regenerate with `swift run Generator`")
-                    }
+                    let data = Data(json.utf8)
                     let decoder = JSONDecoder()
                     do {
                         return try decoder.decode(JSONValue.self, from: data)

Sources/GeneratorKit/ConfigurationSchemaSwiftGenerator.swift

@@ -159,7 +159,7 @@ extension Trivia {
     func trimmingSuperfluousNewlines(fromClosingBrace: Bool) -> (Trivia, Int) {
         var trimmed = 0
         var pendingNewlineCount = 0
-        let pieces = indices.reduce([TriviaPiece]()) { partialResult, index in
+        let pieces = indices.reduce(into: [TriviaPiece]()) { partialResult, index in
             let piece = self[index]
             // Collapse consecutive newlines into a single one
             if case let .newlines(count) = piece {
@@ -168,24 +168,23 @@ extension Trivia {
                         // For the last index(newline right before the closing brace), collapse into
                         // a single newline
                         trimmed += count - 1
-                        return partialResult + [.newlines(1)]
+                        partialResult.append(.newlines(1))
                     } else {
                         pendingNewlineCount += count
-                        return partialResult
                     }
                 } else {
                     if let last = partialResult.last, last.isNewline {
                         trimmed += count
-                        return partialResult
                     } else if index == 0 {
                         // For leading trivia not associated with a closing brace, collapse the
                         // first newline into a single one
                         trimmed += count - 1
-                        return partialResult + [.newlines(1)]
+                        partialResult.append(.newlines(1))
                     } else {
-                        return partialResult + [piece]
+                        partialResult.append(piece)
                     }
                 }
+                return
             }
             // Remove spaces/tabs surrounded by newlines
             if piece.isSpaceOrTab,
@@ -194,20 +193,22 @@ extension Trivia {
                self[index - 1].isNewline,
                self[index + 1].isNewline
             {
-                return partialResult
+                return
             }
             // Handle pending newlines if there are any
             if pendingNewlineCount > 0 {
                 if index < self.count - 1 {
-                    let newlines = TriviaPiece.newlines(pendingNewlineCount)
+                    partialResult.append(.newlines(pendingNewlineCount))
                     pendingNewlineCount = 0
-                    return partialResult + [newlines] + [piece]
+                    partialResult.append(piece)
                 } else {
-                    return partialResult + [.newlines(1)] + [piece]
+                    partialResult.append(.newlines(1))
+                    partialResult.append(piece)
                 }
+                return
             }
             // Retain other trivia pieces
-            return partialResult + [piece]
+            partialResult.append(piece)
         }
 
         return (Trivia(pieces: pieces), trimmed)

Sources/SwiftiomaticKit/Extensions/Trivia+Convenience.swift

@@ -197,8 +197,8 @@ extension TokenStream {
                     // tokens' boundary characters would otherwise glue into one token
                     // (e.g. `try await`, `if let`).
                     if let p = prev.text.last, let c = t.text.first,
-                       (p.isLetter || p.isNumber || p == "_"),
-                       (c.isLetter || c.isNumber || c == "_")
+                       p.isLetter || p.isNumber || p == "_",
+                       c.isLetter || c.isNumber || c == "_"
                     {
                         text += " "
                     }

Sources/SwiftiomaticKit/Layout/Tokens/TokenStream+Closures.swift

@@ -23,7 +23,8 @@ extension TokenStream {
         // any condition wraps, every condition wraps. With a single condition, fall back to the
         // historical `.inconsistent` group (just so breaks around/inside aren't forced).
         let conditionsGroupStyle: GroupBreakStyle = node.conditions.count > 1
-            ? .consistent : .inconsistent
+            ? .consistent
+            : .inconsistent
         before(
             node.conditions.firstToken(viewMode: .sourceAccurate),
             tokens: .open(conditionsGroupStyle)

Sources/SwiftiomaticKit/Layout/Tokens/TokenStream+ControlFlow.swift

@@ -208,15 +208,15 @@ package final class WhitespaceLinter {
 
         // Move the offset to the first non-whitespace character.
         var adjustedUserIndex = userIndex
-        var lastUserRun: ArraySlice<UTF8.CodeUnit>!
+        var lastUserRun: ArraySlice<UTF8.CodeUnit>?
 
         for (index, userRun) in userRuns.enumerated() {
             lastUserRun = userRun
             if index < userRuns.count - 1 { adjustedUserIndex += userRun.count + 1 }
         }
 
         // Calculate the length of the user's line.
-        let userIndent = lastUserRun.count
+        let userIndent = lastUserRun?.count ?? 0
         var userLength = userIndent
 
         for index in adjustedUserIndex..<userText.count {
@@ -233,15 +233,15 @@ package final class WhitespaceLinter {
 
         // Move the offset to the first non-whitespace character.
         var adjustedFormattedIndex = formattedIndex
-        var lastFormattedRun: ArraySlice<UTF8.CodeUnit>!
+        var lastFormattedRun: ArraySlice<UTF8.CodeUnit>?
 
         for (index, formattedRun) in formattedRuns.enumerated() {
             lastFormattedRun = formattedRun
             if index < formattedRuns.count - 1 { adjustedFormattedIndex += formattedRun.count + 1 }
         }
 
         // Calculate the length of the formatted line.
-        let formattedIndent = lastFormattedRun.count
+        let formattedIndent = lastFormattedRun?.count ?? 0
         var formattedLength = formattedIndent
 
         for index in adjustedFormattedIndex..<formattedText.count {