Merge branch 'main' into addinterfaceuntaggedvlan

Author: tobiasge

src/netbox_initializers/initializers/sites.py

@@ -26,7 +26,20 @@ def load_data(self):
 
             matching_params, defaults = self.split_params(params)
 
+            asnFounds = []
             if defaults.get("asns", 0):
+                for asn in defaults["asns"]:
+                    found = ASN.objects.filter(asn=asn).first()
+                    if found:
+                        asnFounds += [found]
+
+                if len(defaults["asns"]) != len(asnFounds):
+                    print(
+                        "⚠️ Unable to create Site '{0}': all ASNs could not be found".format(
+                            params.get("name")
+                        )
+                    )
+
                 # asns will be assosciated below
                 del defaults["asns"]
 
@@ -35,15 +48,13 @@ def load_data(self):
             if created:
                 print("📍 Created site", site.name)
 
-            if params.get("asns", 0):
-                for asn in params["asns"]:
-                    found = ASN.objects.filter(asn=asn).first()
+            self.set_custom_fields_values(site, custom_field_data)
 
-                    if found:
-                        site.asns.add(found)
-                        print(" 👤 Assigned site %s asn %s" % (site.name, asn))
+            for asn in asnFounds:
+                site.asns.add(asn)
+                print(" 👤 Assigned asn %s to site %s" % (asn, site.name))
 
-            self.set_custom_fields_values(site, custom_field_data)
+            site.save()
 
 
 register_initializer("sites", SiteInitializer)