fix(email): pass attachments to beforeSend closure (#150)

Author: FloWinge

classes/Actions/EmailAction.php

@@ -205,6 +205,8 @@ public function from(): User
 	public function run(): void
 	{
 		try {
+			// get attachments before email is created
+			$attachments = $this->attachments();
 
 			$email = App::instance()->email([
 				'template' => $this->template(),
@@ -219,10 +221,10 @@ public function run(): void
 					'submission' => $this->submission(),
 					'form' => $this->submission()->form(),
 				],
-				'attachments' => [], // don't pass attachments here, add them in beforeSend
-				'beforeSend' => function ($mailer) {
+				'attachments' => [], // attachments added in beforeSend for custom naming
+				'beforeSend' => function ($mailer) use ($attachments) { // use captured attachments to ensure files are accessed at the correct time
 					// add attachments with custom names
-					foreach ($this->attachments() as $attachment) {
+					foreach ($attachments as $attachment) {
 						if (is_array($attachment)) {
 							$mailer->addAttachment($attachment['path'], $attachment['name']);
 						} else {
@@ -264,7 +266,7 @@ protected function attachments(): array
 					$attachments[] = $file;
 				}
 			} else { // is PHP file object
-				$files = array_values(A::filter($value->value(), fn ($file) => $file['error'] === UPLOAD_ERR_OK));
+				$files = array_values(A::filter($value->value(), fn($file) => $file['error'] === UPLOAD_ERR_OK));
 				foreach ($files as $file) {
 					$attachments[] = [
 						'path' => $file['tmp_name'],