fix: always flash empty submissions with errors (closes #135)

Author: tobimori

classes/Models/SubmissionPage.php

@@ -545,6 +545,19 @@ public function status(): string
 		return $this->isFinished() ? 'listed' : 'unlisted';
 	}
 
+	/**
+	 * Check if the submission has any filled values
+	 */
+	public function isEmpty(): bool
+	{
+		foreach ($this->values()->toArray() as $value) {
+			if ($value !== null && $value !== '' && $value !== []) {
+				return false;
+			}
+		}
+		return true;
+	}
+
 	/**
 	 * Return the corresponding form page
 	 */

classes/Models/SubmissionSession.php

@@ -76,13 +76,10 @@ private static function cleanupIfNeeded(SubmissionPage $submission): void
 		// Only clean up if submission is finished
 		// Don't clean up on validation errors - they're expected during form filling
 		if ($submission->isFinished()) {
-			$kirby = App::instance();
 			$storage = $submission->storage();
 
-			if ($storage instanceof SubmissionSessionStorage) {
-				$kirby->session()->remove(DreamForm::SESSION_KEY);
-				$storage->cleanup();
-			} elseif ($storage instanceof SubmissionCacheStorage) {
+			if (method_exists($storage, 'cleanup')) {
+				/** @var SubmissionSessionStorage|SubmissionCacheStorage $storage */
 				$storage->cleanup();
 			}
 		}

config/hooks.php

@@ -2,6 +2,7 @@
 
 use tobimori\DreamForm\DreamForm;
 use tobimori\DreamForm\Models\SubmissionPage;
+use tobimori\DreamForm\Storage\SubmissionSessionStorage;
 
 return [
 	/**
@@ -21,6 +22,27 @@
 		];
 	},
 
+	/**
+	 * Clean up empty submissions with errors after rendering (flash behavior)
+	 */
+	'page.render:after' => function (string $contentType, array $data, string $html, Kirby\Cms\Page $page) {
+		$submission = $data['submission'] ?? null;
+
+		// if submission exists, has errors, and is empty, clean it up after render
+		if (
+			$submission instanceof SubmissionPage &&
+			!$submission->isSuccessful() &&
+			$submission->isEmpty()
+		) {
+			$storage = $submission->storage();
+
+			if (method_exists($storage, 'cleanup')) {
+				/** @var SubmissionSessionStorage $storage */
+				$storage->cleanup();
+			}
+		}
+	},
+
 	/*
 	 * Deletes all files associated with a submission page with elevated permissions,
 	 * so we can disallow deleting single files from the panel