feat: do not allow empty submissions

Author: tobimori

classes/Fields/Field.php

@@ -93,6 +93,14 @@ public function validate(): true|string
 		return true;
 	}
 
+	/**
+	 * Check if the field value is empty
+	 */
+	public function isEmpty(): bool
+	{
+		return $this->value()->isEmpty();
+	}
+
 	/**
 	 * Run logic after the form submission
 	 * e.g. for storing an uploaded file

classes/Fields/FileUploadField.php

@@ -100,6 +100,24 @@ public function validate(): true|string
 		return true;
 	}
 
+	/**
+	 * Check if the file upload field is empty
+	 */
+	public function isEmpty(): bool
+	{
+		$files = $this->value()->value();
+
+		// if no files array, it's empty
+		if (!is_array($files)) {
+			return true;
+		}
+
+		// check if any file was successfully uploaded (error code 0 = UPLOAD_ERR_OK)
+		$uploadedFiles = array_filter($files, fn ($file) => is_array($file) && isset($file['error']) && $file['error'] === UPLOAD_ERR_OK);
+
+		return empty($uploadedFiles);
+	}
+
 	// abusing the sanitize method to get the file from the request
 	protected function sanitize(ContentField $value): ContentField
 	{

classes/Models/SubmissionHandling.php

@@ -65,6 +65,8 @@ public function handleGuards(bool $postValidation = false): SubmissionPage
 	public function handleFields()
 	{
 		$currentStep = App::instance()->request()->query()->get('dreamform-step', 1);
+		$allFieldsEmpty = true;
+
 		foreach ($this->form()->fields($currentStep) as $field) {
 			// skip "decorative" fields that don't have a value
 			if (!$field::hasValue()) {
@@ -84,6 +86,16 @@ public function handleFields()
 			} else {
 				$this->removeError($field->key());
 			}
+
+			// check if at least one field is not empty
+			if (!$field->isEmpty()) {
+				$allFieldsEmpty = false;
+			}
+		}
+
+		// reject submission if all fields are empty
+		if ($allFieldsEmpty) {
+			$this->setError(t('dreamform.submission.error.emptyFields'));
 		}
 
 		return $this;

classes/Models/SubmissionPage.php

@@ -550,7 +550,8 @@ public function status(): string
 	 */
 	public function isEmpty(): bool
 	{
-		foreach ($this->values()->toArray() as $value) {
+		foreach ($this->values()->toArray() as $key => $value) {
+			ray($key, $value);
 			if ($value !== null && $value !== '' && $value !== []) {
 				return false;
 			}

i18n.lock

@@ -204,6 +204,7 @@ checksums:
     submission.error.logType: 8ccade6dbadd811549681a5d47a0c228
     submission.error.ratelimit: ac3f18655245056d79a43b8d93ca142b
     submission.error.csrf: f50aaeec1b998d29fcf256fb9a56d914
+    submission.error.emptyFields: 7609524fd93fe053e07424ed92c47938
     submission.ham: bca6fe1bceb5a6054dff6c1aed978a0d
     submission.log.error: a02e13357f41b47114edda8970846ef3
     submission.markedAs: 1acc2605319fdc4c375eddbec19ecb12

translations/cs.json

@@ -202,6 +202,7 @@
 	"submission.error.logType": "Typ položky „{{ type }}“ není platný.",
 	"submission.error.ratelimit": "Formulář jste odeslali příliš často. Počkejte prosím chvíli a zkuste to znovu.",
 	"submission.error.csrf": "Platnost formuláře vypršela. Znovu načtěte stránku a zkuste to znovu.",
+	"submission.error.emptyFields": "Prosím vyplň alespoň jedno pole před odesláním.",
 	"submission.ham": "Není spam",
 	"submission.log.error": "Neznámá chyba v <strong>„{{ type }}“</strong>",
 	"submission.markedAs": "Tato odpověď byla označena jako {{ status }}",

translations/de.json

@@ -202,6 +202,7 @@
 	"submission.error.logType": "Der Eintragstyp \"{{ type }}\" ist nicht gültig.",
 	"submission.error.ratelimit": "Du hast das Formular zu häufig abgeschickt. Bitte warte einen Moment und versuche es erneut.",
 	"submission.error.csrf": "Das Formular ist abgelaufen. Bitte lade die Seite neu und versuche es erneut.",
+	"submission.error.emptyFields": "Bitte fülle mindestens ein Feld aus, bevor du absendest.",
 	"submission.ham": "Kein Spam",
 	"submission.log.error": "Unbekannter Fehler in <strong>\"{{ type }}\"</strong>",
 	"submission.markedAs": "Diese Antwort wurde als {{ status }} markiert.",

translations/en.json

@@ -202,6 +202,7 @@
 	"submission.error.logType": "The submission log type \"{{ type }}\" is not valid.",
 	"submission.error.ratelimit": "You've submitted the form too often. Please wait a moment and try again.",
 	"submission.error.csrf": "The form expired. Please reload the page and try again.",
+	"submission.error.emptyFields": "Please fill out at least one field before submitting.",
 	"submission.ham": "Not Spam",
 	"submission.log.error": "Unhandled error in performer <strong>\"{{ type }}\"</strong>",
 	"submission.markedAs": "This answer is {{ status }}",

translations/es.json

@@ -202,6 +202,7 @@
 	"submission.error.logType": "El tipo de registro de envío \"{{ type }}\" no es válido.",
 	"submission.error.ratelimit": "Has enviado el formulario demasiadas veces. Por favor, espera un momento e inténtalo de nuevo.",
 	"submission.error.csrf": "El formulario ha expirado. Por favor, recarga la página e inténtalo de nuevo.",
+	"submission.error.emptyFields": "Por favor, completa al menos un campo antes de enviar.",
 	"submission.ham": "No es spam",
 	"submission.log.error": "Error no controlado en el ejecutor <strong>\"{{ type }}\"</strong>",
 	"submission.markedAs": "Esta respuesta está {{ status }}",

translations/fr.json

@@ -202,6 +202,7 @@
 	"submission.error.logType": "Le type de journal de soumission \"{{ type }}\" n'est pas valide.",
 	"submission.error.ratelimit": "Vous avez soumis le formulaire trop souvent. Veuillez attendre un moment et réessayer.",
 	"submission.error.csrf": "Le formulaire a expiré. Veuillez recharger la page et réessayer.",
+	"submission.error.emptyFields": "Veuillez remplir au moins un champ avant de soumettre.",
 	"submission.ham": "Pas du spam",
 	"submission.log.error": "Erreur non gérée dans l'exécuteur <strong>\"{{ type }}\"</strong>",
 	"submission.markedAs": "Cette réponse est {{ status }}",