Address code review feedback: rename addp to addpri|ap and improve implementation

- Rename command from 'addp' to 'addpri|ap' to match existing patterns (add|a, pri|p)
- Replace grep-based priority validation with modern Bash syntax
- Update shorthelp() and actionsHelp() functions to show both command forms
- Update USAGE.md documentation to reflect new command name
- Replace dynamic date with hardcoded 2009-02-13 in tests per framework requirements
- Rename test file from t1050-addp.sh to t1050-addpri.sh for consistency
- Update all test references from addp to addpri throughout test suite

Author: rosconap

USAGE.md

@@ -28,14 +28,14 @@ todo.sh addm "FIRST THING I NEED TO DO +project1 @context
 SECOND THING I NEED TO DO +project2 @context"
 ```
 
-### `addp`
+### `addpri`
 Adds TEXT TO ADD to your todo.txt file on its own line with the specified PRIORITY (A-Z) at the beginning.
 
 The priority letter is automatically converted to uppercase and formatted as `(PRIORITY)`.
 
 ```shell
-todo.sh addp A "Important high-priority task"
-todo.sh addp e "Medium priority task"
+todo.sh addpri A "Important high-priority task"
+todo.sh ap E "Medium priority task"
 ```
 
 Example output:

tests/t1050-addp.sh renamed to tests/t1050-addpri.sh

@@ -1,22 +1,22 @@
 #!/usr/bin/env bash
 
-test_description='addp command functionality
+test_description='addpri command functionality
 
-Tests the addp command which adds tasks with specified priority.
+Tests the addpri command which adds tasks with specified priority.
 '
 . ./test-lib.sh
 
-# Test basic addp functionality
-test_todo_session 'basic addp functionality' <<EOF
->>> todo.sh addp A "High priority task"
+# Test basic addpri functionality
+test_todo_session 'basic addpri functionality' <<EOF
+>>> todo.sh addpri A "High priority task"
 1 (A) High priority task
 TODO: 1 added.
 
->>> todo.sh addp B "Medium priority task"
+>>> todo.sh addpri B "Medium priority task"
 2 (B) Medium priority task
 TODO: 2 added.
 
->>> todo.sh addp Z "Low priority task"
+>>> todo.sh addpri Z "Low priority task"
 3 (Z) Low priority task
 TODO: 3 added.
 
@@ -32,11 +32,11 @@ EOF
 cat > todo.txt <<EOF
 EOF
 test_todo_session 'lowercase priority conversion' <<EOF
->>> todo.sh addp c "lowercase priority test"
+>>> todo.sh addpri c "lowercase priority test"
 1 (C) lowercase priority test
 TODO: 1 added.
 
->>> todo.sh addp z "another lowercase test"
+>>> todo.sh addpri z "another lowercase test"
 2 (Z) another lowercase test
 TODO: 2 added.
 
@@ -47,15 +47,15 @@ TODO: 2 added.
 TODO: 2 of 2 tasks shown
 EOF
 
-# Test addp with projects and contexts
+# Test addpri with projects and contexts
 cat > todo.txt <<EOF
 EOF
-test_todo_session 'addp with projects and contexts' <<EOF
->>> todo.sh addp A "Important work task +project @work"
+test_todo_session 'addpri with projects and contexts' <<EOF
+>>> todo.sh addpri A "Important work task +project @work"
 1 (A) Important work task +project @work
 TODO: 1 added.
 
->>> todo.sh addp B "Call client +client @phone"
+>>> todo.sh addpri B "Call client +client @phone"
 2 (B) Call client +client @phone
 TODO: 2 added.
 
@@ -69,66 +69,66 @@ EOF
 # Test error handling - no arguments
 cat > todo.txt <<EOF
 EOF
-test_todo_session 'addp error - no arguments' <<EOF
->>> todo.sh addp
-usage: todo.sh addp PRIORITY "TODO ITEM"
+test_todo_session 'addpri error - no arguments' <<EOF
+>>> todo.sh addpri
+usage: todo.sh addpri PRIORITY "TODO ITEM"
 === 1
 EOF
 
 # Test error handling - missing task text
-test_todo_session 'addp error - missing task text' <<EOF
->>> todo.sh addp A
-usage: todo.sh addp PRIORITY "TODO ITEM"
+test_todo_session 'addpri error - missing task text' <<EOF
+>>> todo.sh addpri A
+usage: todo.sh addpri PRIORITY "TODO ITEM"
 === 1
 EOF
 
 # Test error handling - invalid priority (number)
-test_todo_session 'addp error - invalid priority number' <<EOF
->>> todo.sh addp 1 "Invalid priority task"
+test_todo_session 'addpri error - invalid priority number' <<EOF
+>>> todo.sh addpri 1 "Invalid priority task"
 TODO: Priority must be a letter from A to Z (got: 1)
 === 1
 EOF
 
 # Test error handling - invalid priority (multiple characters)
-test_todo_session 'addp error - invalid priority multiple chars' <<EOF
->>> todo.sh addp AA "Invalid priority task"
+test_todo_session 'addpri error - invalid priority multiple chars' <<EOF
+>>> todo.sh addpri AA "Invalid priority task"
 TODO: Priority must be a letter from A to Z (got: AA)
 === 1
 EOF
 
 # Test error handling - invalid priority (special character)
-test_todo_session 'addp error - invalid priority special char' <<EOF
->>> todo.sh addp @ "Invalid priority task"
+test_todo_session 'addpri error - invalid priority special char' <<EOF
+>>> todo.sh addpri @ "Invalid priority task"
 TODO: Priority must be a letter from A to Z (got: @)
 === 1
 EOF
 
-# Test addp integration with date_on_add
+# Test addpri integration with date_on_add
 cat > todo.txt <<EOF
 EOF
 echo "export TODOTXT_DATE_ON_ADD=1" >> todo.cfg
 
-test_todo_session 'addp with date on add' <<EOF
->>> todo.sh addp A "Task with date"
-1 (A) $(date '+%Y-%m-%d') Task with date
+test_todo_session 'addpri with date on add' <<EOF
+>>> todo.sh addpri A "Task with date"
+1 (A) 2009-02-13 Task with date
 TODO: 1 added.
 
 >>> todo.sh -p list
-1 (A) $(date '+%Y-%m-%d') Task with date
+1 (A) 2009-02-13 Task with date
 --
 TODO: 1 of 1 tasks shown
 EOF
 
 # Reset config for next test
 echo "export TODOTXT_DATE_ON_ADD=0" >> todo.cfg
 
-# Test that addp overrides TODOTXT_PRIORITY_ON_ADD
+# Test that addpri overrides TODOTXT_PRIORITY_ON_ADD
 cat > todo.txt <<EOF
 EOF
 echo "export TODOTXT_PRIORITY_ON_ADD=C" >> todo.cfg
 
-test_todo_session 'addp overrides PRIORITY_ON_ADD' <<EOF
->>> todo.sh addp A "Priority A task"
+test_todo_session 'addpri overrides PRIORITY_ON_ADD' <<EOF
+>>> todo.sh addpri A "Priority A task"
 1 (A) Priority A task
 TODO: 1 added.
 
@@ -143,15 +143,15 @@ TODO: 2 added.
 TODO: 2 of 2 tasks shown
 EOF
 
-# Test addp with various edge cases
+# Test addpri with various edge cases
 cat > todo.txt <<EOF
 EOF
-test_todo_session 'addp edge cases' <<EOF
->>> todo.sh addp E "Task with special chars: !@#$%^&*()"
+test_todo_session 'addpri edge cases' <<EOF
+>>> todo.sh addpri E "Task with special chars: !@#$%^&*()"
 1 (E) Task with special chars: !@#$%^&*()
 TODO: 1 added.
 
->>> todo.sh addp F "Task with 'single quotes' and \"double quotes\""
+>>> todo.sh addpri F "Task with 'single quotes' and \"double quotes\""
 2 (F) Task with 'single quotes' and "double quotes"
 TODO: 2 added.
 

todo.sh

@@ -45,7 +45,7 @@ shorthelp()
 		    add|a "THING I NEED TO DO +project @context"
 		    addm "THINGS I NEED TO DO
 		          MORE THINGS I NEED TO DO"
-		    addp PRIORITY "TEXT TO ADD"
+		    addpri|ap PRIORITY "TEXT TO ADD"
 		    addto DEST "TEXT TO ADD"
 		    append|app NR "TEXT TO APPEND"
 		    archive
@@ -178,10 +178,11 @@ actionsHelp()
 		      Adds SECOND THING I NEED TO DO to you todo.txt on its own line.
 		      Project and context notation optional.
 
-		    addp PRIORITY "TEXT TO ADD"
+		    addpri PRIORITY "TEXT TO ADD"
+		    ap PRIORITY "TEXT TO ADD"
 		      Adds TEXT TO ADD to your todo.txt file on its own line with
 		      the specified PRIORITY (A-Z) at the beginning.
-		      For example, addp A "Important task" creates "(A) Important task".
+		      For example, addpri A "Important task" creates "(A) Important task".
 
 		    addto DEST "TEXT TO ADD"
 		      Adds a line of text to any file located in the todo.txt directory.
@@ -1126,14 +1127,14 @@ case $action in
     IFS=$SAVEIFS
     ;;
 
-"addp")
-    errmsg="usage: $TODO_SH addp PRIORITY \"TODO ITEM\""
+"addpri" | "ap")
+    errmsg="usage: $TODO_SH addpri PRIORITY \"TODO ITEM\""
     [ -z "$2" ] && die "$errmsg"
     priority="$2"
     [ -z "$3" ] && die "$errmsg"
 
     # Validate priority is a single letter A-Z
-    if ! echo "$priority" | grep -q '^[A-Za-z]$'; then
+    if [[ "$priority" != @([A-Za-z]) ]]; then
         die "TODO: Priority must be a letter from A to Z (got: $priority)"
     fi