Integration miscalculates stations with multiple lines

[BorisProhaska]

When using this integration with a station id, that has multiple lines, it is completely being ignored which line is the first and next.

I think it's because this integration isn't actually looking into the data, but always takes the first line.

As an example:

• 10A: in 7 min, in 37min
• 11A: in 2 min, in 12min

I'd assume, that the first is 11A in 2min, and next is 10A in 7min.

What the integration does is: 10A (because first in the list) in 7min as first, and 10A in 37min as next.

Can you fix this please? :)

Thanks

[jozefKruszynski]

The reason for this is that the way the integration works, is that it only takes the first monitor in the index of the Json response.

I actually forked this project today, and made some changes to fix this issue, also added unique IDs to the created monitors, and modified the naming of them also.

If you want to take a look at it, you can find it here:
https://github.com/jozefKruszynski/home-assistant-wienerlinien

The config is identical, but you will need to makes some changes to any dashboards due to the different naming and unique IDs

[jozefKruszynski]

@tofuSCHNITZEL I hope it's okay that I posted my fork in the above response.

[BorisProhaska]

@jozefKruszynski I'll have a look at it - thank you very much.

[tofuSCHNITZEL]

@jozefKruszynski would you create a pull request so I can make the improvements available for everybody?

[jozefKruszynski]

Will do

[BorisProhaska]

@jozefKruszynski @tofuSCHNITZEL this is way better now. Thank you very much - it does exactly what i wanted - you guys are awesome :)

[jozefKruszynski]

@tofuSCHNITZEL
I’ll try to make the pull request tomorrow. Please give it a thorough review as I don’t usually program in Python so you might a few oddities.

[tofuSCHNITZEL]

thanks! I will have a look and test it also on my own setup.

[jozefKruszynski]

@tofuSCHNITZEL
Do you have a specific merge request template that you would like me to use?

[tofuSCHNITZEL]

hm no I dont think so.

[jozefKruszynski]

@tofuSCHNITZEL in case you hadn't spotted it yet, here is a gentle nudge 😉
#6

[tofuSCHNITZEL]

Yes I already looked it over, would you have time and would you be interested in a call / "digital meet up" to discuss the changes?
I also want to look at the API first to get a feeling how the data is structured there...

[jozefKruszynski]

Sounds like a reasonable plan. I actually just managed to find the official documentation of the API last night.
I have v1 and v1.3 although I'd really like to get an openapi doc rather than the pdfs that I found.

Edit: I probably have some time next week for a teams/zoom/something else call. Let me know when would suit...

[tofuSCHNITZEL]

teams would work for me... could you send me the links to the doc you found?

[jozefKruszynski]

Good morning, here is the link to the v1.3 api pdf.
https://www.wienerlinien.at/ogd_realtime/doku/ogd/wienerlinien-echtzeitdaten-dokumentation.pdf

According to the pdf, v1.3 was released 03.09.2020, I haven't found anything more recent so far.

Here is the original v1.0:
https://data.wien.gv.at/pdf/wienerlinien-echtzeitdaten-dokumentation.pdf

From a quick test this morning, it looks as though when you use the DIVA number for a stop instead of the RBL number, you get all info for that stop. I tested Floridsdorf for example, and got a response containing all the U6 departures and the buses, and trams going in each direction.