Skip to content

Commit ee73793

Browse files
author
Jake Plimack
committed
chore: fix linting issues in workflows and docs
Remove unnecessary quoted strings in GitHub Actions workflow YAML files, bump action versions (checkout@v4, codeql@v3), upgrade runner images to ubuntu-24.04, fix trailing whitespace in markdown, resolve duplicate top-level headings (MD025), and add trunk + actionlint configuration. TCL-4373
1 parent 2e94ce4 commit ee73793

37 files changed

+1245
-761
lines changed

‎.github/actionlint.yaml‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
self-hosted-runner:
2+
labels:
3+
- ubuntu-22.04-4core
4+
- ubuntu-22.04-64core
5+
- ubuntu-22.04-8core
6+
- ubuntu-22.04-arm-4core
7+
- ubuntu-24.04-4core
8+
- ubuntu-24.04-8core
9+
- ubuntu-24.04-arm-4core
10+
- sriov
11+
- ocp

‎.github/workflows/actionlint.yaml‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
name: Actionlint
2+
3+
on:
4+
pull_request:
5+
paths:
6+
- .github/workflows/**
7+
8+
concurrency:
9+
group: ${{ github.workflow }}-${{ github.ref }}
10+
cancel-in-progress: true
11+
12+
permissions:
13+
contents: write
14+
pull-requests: write
15+
16+
jobs:
17+
actionlint:
18+
runs-on: ubuntu-latest
19+
steps:
20+
- name: Checkout
21+
uses: actions/checkout@v4
22+
23+
- name: Run Actionlint
24+
uses: raven-actions/actionlint@v2
25+
with:
26+
files: .github/workflows/*.y*ml

‎.github/workflows/chart-push-release.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "Push helm chart on release"
1+
name: Push helm chart on release
22

33
env:
44
IMAGE_NAME: ghcr.io/${{ github.repository }}

‎.github/workflows/codeql.yml‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
name: "CodeQL"
1+
name: CodeQL
22

33
on:
44
push:
5-
branches: [ "master" ]
5+
branches: [ master ]
66
pull_request:
7-
branches: [ "master" ]
7+
branches: [ master ]
88
schedule:
9-
- cron: "48 5 * * 6"
9+
- cron: 48 5 * * 6
1010

1111
jobs:
1212
analyze:
@@ -24,18 +24,18 @@ jobs:
2424

2525
steps:
2626
- name: Checkout
27-
uses: actions/checkout@v3
27+
uses: actions/checkout@v4
2828

2929
- name: Initialize CodeQL
30-
uses: github/codeql-action/init@v2
30+
uses: github/codeql-action/init@v3
3131
with:
3232
languages: ${{ matrix.language }}
3333
queries: +security-and-quality
3434

3535
- name: Autobuild
36-
uses: github/codeql-action/autobuild@v2
36+
uses: github/codeql-action/autobuild@v3
3737

3838
- name: Perform CodeQL Analysis
39-
uses: github/codeql-action/analyze@v2
39+
uses: github/codeql-action/analyze@v3
4040
with:
4141
category: "/language:${{ matrix.language }}"

‎.github/workflows/image-push-master.yml‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "Push images on merge to master"
1+
name: Push images on merge to master
22

33
env:
44
IMAGE_NAME: ghcr.io/${{ github.repository }}
@@ -11,34 +11,34 @@ on:
1111

1212
jobs:
1313
build-and-push-image-operator:
14-
runs-on: ubuntu-20.04
14+
runs-on: ubuntu-24.04-4core
1515
steps:
1616
- name: Check out the repo
17-
uses: actions/checkout@v3
17+
uses: actions/checkout@v4
1818

1919
# Add support for more platforms with QEMU (optional)
2020
# https://github.com/docker/setup-qemu-action
2121
- name: Set up QEMU
2222
uses: docker/setup-qemu-action@v3
2323

2424
- name: Set up Docker Buildx
25-
uses: docker/setup-buildx-action@v2
25+
uses: docker/setup-buildx-action@v3
2626

2727
- name: Login to Docker
28-
uses: docker/login-action@v2
28+
uses: docker/login-action@v3
2929
with:
3030
registry: ghcr.io
3131
username: ${{ github.repository_owner }}
3232
password: ${{ secrets.GITHUB_TOKEN }}
3333

3434
- name: Docker meta
3535
id: docker_meta
36-
uses: docker/metadata-action@v4
36+
uses: docker/metadata-action@v5
3737
with:
3838
images: ${{ env.IMAGE_NAME }}
3939

4040
- name: Build and push sriov-network-operator
41-
uses: docker/build-push-action@v4
41+
uses: docker/build-push-action@v6
4242
with:
4343
context: .
4444
push: true
@@ -50,34 +50,34 @@ jobs:
5050
file: ./Dockerfile
5151

5252
build-and-push-image-config-daemon:
53-
runs-on: ubuntu-20.04
53+
runs-on: ubuntu-24.04-4core
5454
steps:
5555
- name: Check out the repo
56-
uses: actions/checkout@v3
56+
uses: actions/checkout@v4
5757

5858
# Add support for more platforms with QEMU (optional)
5959
# https://github.com/docker/setup-qemu-action
6060
- name: Set up QEMU
6161
uses: docker/setup-qemu-action@v3
6262

6363
- name: Set up Docker Buildx
64-
uses: docker/setup-buildx-action@v2
64+
uses: docker/setup-buildx-action@v3
6565

6666
- name: Login to Docker
67-
uses: docker/login-action@v2
67+
uses: docker/login-action@v3
6868
with:
6969
registry: ghcr.io
7070
username: ${{ github.repository_owner }}
7171
password: ${{ secrets.GITHUB_TOKEN }}
7272

7373
- name: Docker meta
7474
id: docker_meta
75-
uses: docker/metadata-action@v4
75+
uses: docker/metadata-action@v5
7676
with:
7777
images: ${{ env.IMAGE_NAME }}-config-daemon
7878

7979
- name: Build and push sriov-network-operator-config-daemon
80-
uses: docker/build-push-action@v4
80+
uses: docker/build-push-action@v6
8181
with:
8282
context: .
8383
push: true
@@ -89,34 +89,34 @@ jobs:
8989
file: ./Dockerfile.sriov-network-config-daemon
9090

9191
build-and-push-image-webhook:
92-
runs-on: ubuntu-20.04
92+
runs-on: ubuntu-24.04-4core
9393
steps:
9494
- name: Check out the repo
95-
uses: actions/checkout@v3
95+
uses: actions/checkout@v4
9696

9797
# Add support for more platforms with QEMU (optional)
9898
# https://github.com/docker/setup-qemu-action
9999
- name: Set up QEMU
100100
uses: docker/setup-qemu-action@v3
101101

102102
- name: Set up Docker Buildx
103-
uses: docker/setup-buildx-action@v2
103+
uses: docker/setup-buildx-action@v3
104104

105105
- name: Login to Docker
106-
uses: docker/login-action@v2
106+
uses: docker/login-action@v3
107107
with:
108108
registry: ghcr.io
109109
username: ${{ github.repository_owner }}
110110
password: ${{ secrets.GITHUB_TOKEN }}
111111

112112
- name: Docker meta
113113
id: docker_meta
114-
uses: docker/metadata-action@v4
114+
uses: docker/metadata-action@v5
115115
with:
116116
images: ${{ env.IMAGE_NAME }}-webhook
117117

118118
- name: Build and push sriov-network-operator-webhook
119-
uses: docker/build-push-action@v4
119+
uses: docker/build-push-action@v6
120120
with:
121121
context: .
122122
push: true

‎.github/workflows/image-push-release.yml‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "Push images on release"
1+
name: Push images on release
22

33
env:
44
IMAGE_NAME: ghcr.io/${{ github.repository }}
@@ -10,36 +10,36 @@ on:
1010
- v*
1111
jobs:
1212
build-and-push-image-operator:
13-
runs-on: ubuntu-20.04
13+
runs-on: ubuntu-24.04-4core
1414
steps:
1515
- name: Check out the repo
16-
uses: actions/checkout@v3
16+
uses: actions/checkout@v4
1717

1818
# Add support for more platforms with QEMU (optional)
1919
# https://github.com/docker/setup-qemu-action
2020
- name: Set up QEMU
2121
uses: docker/setup-qemu-action@v3
2222

2323
- name: Set up Docker Buildx
24-
uses: docker/setup-buildx-action@v2
24+
uses: docker/setup-buildx-action@v3
2525

2626
- name: Login to Docker
27-
uses: docker/login-action@v2
27+
uses: docker/login-action@v3
2828
with:
2929
registry: ghcr.io
3030
username: ${{ github.repository_owner }}
3131
password: ${{ secrets.GITHUB_TOKEN }}
3232

3333
- name: Docker meta
3434
id: docker_meta
35-
uses: docker/metadata-action@v4
35+
uses: docker/metadata-action@v5
3636
with:
3737
images: ${{ env.IMAGE_NAME }}
3838
flavor: |
3939
latest=false
4040
4141
- name: Build and push sriov-network-operator
42-
uses: docker/build-push-action@v4
42+
uses: docker/build-push-action@v6
4343
with:
4444
context: .
4545
push: true
@@ -50,36 +50,36 @@ jobs:
5050
file: ./Dockerfile
5151

5252
build-and-push-image-config-daemon:
53-
runs-on: ubuntu-20.04
53+
runs-on: ubuntu-24.04-4core
5454
steps:
5555
- name: Check out the repo
56-
uses: actions/checkout@v3
56+
uses: actions/checkout@v4
5757

5858
# Add support for more platforms with QEMU (optional)
5959
# https://github.com/docker/setup-qemu-action
6060
- name: Set up QEMU
6161
uses: docker/setup-qemu-action@v3
6262

6363
- name: Set up Docker Buildx
64-
uses: docker/setup-buildx-action@v2
64+
uses: docker/setup-buildx-action@v3
6565

6666
- name: Login to Docker
67-
uses: docker/login-action@v2
67+
uses: docker/login-action@v3
6868
with:
6969
registry: ghcr.io
7070
username: ${{ github.repository_owner }}
7171
password: ${{ secrets.GITHUB_TOKEN }}
7272

7373
- name: Docker meta
7474
id: docker_meta
75-
uses: docker/metadata-action@v4
75+
uses: docker/metadata-action@v5
7676
with:
7777
images: ${{ env.IMAGE_NAME }}-config-daemon
7878
flavor: |
7979
latest=false
8080
8181
- name: Build and push sriov-network-operator-config-daemon
82-
uses: docker/build-push-action@v4
82+
uses: docker/build-push-action@v6
8383
with:
8484
context: .
8585
push: true
@@ -90,36 +90,36 @@ jobs:
9090
file: ./Dockerfile.sriov-network-config-daemon
9191

9292
build-and-push-image-webhook:
93-
runs-on: ubuntu-20.04
93+
runs-on: ubuntu-24.04-4core
9494
steps:
9595
- name: Check out the repo
96-
uses: actions/checkout@v3
96+
uses: actions/checkout@v4
9797

9898
# Add support for more platforms with QEMU (optional)
9999
# https://github.com/docker/setup-qemu-action
100100
- name: Set up QEMU
101101
uses: docker/setup-qemu-action@v3
102102

103103
- name: Set up Docker Buildx
104-
uses: docker/setup-buildx-action@v2
104+
uses: docker/setup-buildx-action@v3
105105

106106
- name: Login to Docker
107-
uses: docker/login-action@v2
107+
uses: docker/login-action@v3
108108
with:
109109
registry: ghcr.io
110110
username: ${{ github.repository_owner }}
111111
password: ${{ secrets.GITHUB_TOKEN }}
112112

113113
- name: Docker meta
114114
id: docker_meta
115-
uses: docker/metadata-action@v4
115+
uses: docker/metadata-action@v5
116116
with:
117117
images: ${{ env.IMAGE_NAME }}-webhook
118118
flavor: |
119119
latest=false
120120
121121
- name: Build and push sriov-network-operator-webhook
122-
uses: docker/build-push-action@v4
122+
uses: docker/build-push-action@v6
123123
with:
124124
context: .
125125
push: true

‎.github/workflows/pr-ci-triggers.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ jobs:
66
vendors-ci-triggers-list:
77
runs-on: ubuntu-latest
88
steps:
9-
- uses: actions/github-script@v5
9+
- uses: actions/github-script@v7
1010
env:
1111
MESSAGE: >-
1212
Thanks for your PR,\n

‎.github/workflows/pr-labeler.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
name: "Pull Request Labeler"
1+
name: Pull Request Labeler
22
on:
33
- pull_request_target
44

55
jobs:
66
triage:
77
runs-on: ubuntu-latest
88
steps:
9-
- uses: actions/labeler@v3
9+
- uses: actions/labeler@v5
1010
with:
11-
repo-token: "${{ secrets.GITHUB_TOKEN }}"
11+
repo-token: ${{ secrets.GITHUB_TOKEN }}

‎.github/workflows/pr-update.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
name: "Run Jobs on PR"
1+
name: Run Jobs on PR
22
on: pull_request
33

44
jobs:
55
execute:
6-
name: "remove the lgtm label"
6+
name: remove the lgtm label
77
runs-on: ubuntu-latest
88
steps:
99
- uses: jpmcb/prow-github-actions@v1.1.2
1010
with:
11-
jobs: 'lgtm'
12-
github-token: "${{ secrets.GITHUB_TOKEN }}"
11+
jobs: lgtm
12+
github-token: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)