remove one clone

Author: yanns

axum/src/routing/mod.rs

@@ -668,12 +668,12 @@ where
         }
     }
 
-    fn call_with_state(&mut self, req: Request, state: S) -> RouteFuture<E> {
+    fn call_with_state(self, req: Request, state: S) -> RouteFuture<E> {
         match self {
-            Fallback::Default(route) | Fallback::Service(route) => route.oneshot_inner(req),
+            Fallback::Default(route) | Fallback::Service(route) => route.oneshot_inner_owned(req),
             Fallback::BoxedHandler(handler) => {
-                let mut route = handler.clone().into_route(state);
-                route.oneshot_inner(req)
+                let route = handler.clone().into_route(state);
+                route.oneshot_inner_owned(req)
             }
         }
     }

axum/src/routing/route.rs

@@ -47,6 +47,12 @@ impl<E> Route<E> {
         RouteFuture::new(method, self.0.clone().oneshot(req))
     }
 
+    /// Variant of [`Route::oneshot_inner`] that takes ownership of the route to avoid cloning.
+    pub(crate) fn oneshot_inner_owned(self, req: Request) -> RouteFuture<E> {
+        let method = req.method().clone();
+        RouteFuture::new(method, self.0.oneshot(req))
+    }
+
     pub(crate) fn layer<L, NewError>(self, layer: L) -> Route<NewError>
     where
         L: Layer<Route<E>> + Clone + Send + 'static,

axum/src/routing/tests/fallback.rs

@@ -344,5 +344,5 @@ async fn state_isnt_cloned_too_much_with_fallback() {
 
     client.get("/does-not-exist").await;
 
-    assert_eq!(state.count(), 4);
+    assert_eq!(state.count(), 3);
 }