Skip to content

subscriber: feature-flag recording #245

Open
@hawkw

Description

@hawkw

The recording features in console-subscriber requires additional dependencies (e.g. serde-json) that we don't need anywhere else in the console. My PR #238 will probably also add a crossbeam-channel dependency to the recording code. It would be kind of nice if the recording feature was feature-flagged so that these dependencies can be disabled by users who aren't using recordings.

The one potential concern about feature flagging this is that it could be considered a breaking change. However, feature-flagging it wouldn't make any APIs disappear, just behavior. Should this be considered a semver-breaking change?

Metadata

Metadata

Assignees

Labels

C-subscriberCrate: console-subscriber.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions