Skip to content

console-subscriber crate has low test coverage #450

Open
@hds

Description

@hds

What crate(s) in this repo are involved in the problem?

console-subscriber

What is the issue?

The console-subscriber crate has no integration tests. There are some unit tests, but the coverage isn’t great.

Recently, we’ve found or fixed a few of issues which probably could have been caught with a bit of testing. For example the issue #378 (fixed in #440), and the fixes #430 and #447.

Possible solution

Ideally, we would like a way to test the console-subscriber end to end, starting with an instrumented tokio runtime and ending with a validation of tasks received by a client to the gRPC server.

Much of this setup is likely to be duplicated between tests, so some of that test framework should be factored out into common code. Although we likely don’t need anything as complete as tracing-mock in the tracing project.

Would you like to work on fixing this bug?

yes, I already am

Metadata

Metadata

Assignees

Labels

C-subscriberCrate: console-subscriber.E-mediumEffort: medium.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions