Skip to content

Commit d9f615a

Browse files
committed
Move args into format strings
1 parent e186482 commit d9f615a

File tree

5 files changed

+14
-16
lines changed

5 files changed

+14
-16
lines changed

src/bin/cli.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,17 +90,17 @@ async fn main() -> mini_redis::Result<()> {
9090
Command::Ping { msg } => {
9191
let value = client.ping(msg).await?;
9292
if let Ok(string) = str::from_utf8(&value) {
93-
println!("\"{}\"", string);
93+
println!("\"{string}\"");
9494
} else {
95-
println!("{:?}", value);
95+
println!("{value:?}");
9696
}
9797
}
9898
Command::Get { key } => {
9999
if let Some(value) = client.get(&key).await? {
100100
if let Ok(string) = str::from_utf8(&value) {
101-
println!("\"{}\"", string);
101+
println!("\"{string}\"");
102102
} else {
103-
println!("{:?}", value);
103+
println!("{value:?}");
104104
}
105105
} else {
106106
println!("(nil)");

src/bin/server.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ pub async fn main() -> mini_redis::Result<()> {
3636
let port = cli.port.unwrap_or(DEFAULT_PORT);
3737

3838
// Bind a TCP listener
39-
let listener = TcpListener::bind(&format!("127.0.0.1:{}", port)).await?;
39+
let listener = TcpListener::bind(&format!("127.0.0.1:{port}")).await?;
4040

4141
server::run(listener, signal::ctrl_c()).await;
4242

src/connection.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ impl Connection {
225225
// Convert the value to a string
226226
let mut buf = [0u8; 20];
227227
let mut buf = Cursor::new(&mut buf[..]);
228-
write!(&mut buf, "{}", val)?;
228+
write!(&mut buf, "{val}")?;
229229

230230
let pos = buf.position() as usize;
231231
self.stream.write_all(&buf.get_ref()[..pos]).await?;

src/frame.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ impl Frame {
9898

9999
Ok(())
100100
}
101-
actual => Err(format!("protocol error; invalid frame type byte `{}`", actual).into()),
101+
actual => Err(format!("protocol error; invalid frame type byte `{actual}`").into()),
102102
}
103103
}
104104

@@ -169,7 +169,7 @@ impl Frame {
169169

170170
/// Converts the frame to an "unexpected frame" error
171171
pub(crate) fn to_error(&self) -> crate::Error {
172-
format!("unexpected frame: {}", self).into()
172+
format!("unexpected frame: {self}").into()
173173
}
174174
}
175175

@@ -189,11 +189,11 @@ impl fmt::Display for Frame {
189189

190190
match self {
191191
Frame::Simple(response) => response.fmt(fmt),
192-
Frame::Error(msg) => write!(fmt, "error: {}", msg),
192+
Frame::Error(msg) => write!(fmt, "error: {msg}"),
193193
Frame::Integer(num) => num.fmt(fmt),
194194
Frame::Bulk(msg) => match str::from_utf8(msg) {
195195
Ok(string) => string.fmt(fmt),
196-
Err(_) => write!(fmt, "{:?}", msg),
196+
Err(_) => write!(fmt, "{msg:?}"),
197197
},
198198
Frame::Null => "(nil)".fmt(fmt),
199199
Frame::Array(parts) => {

src/parse.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ impl Parse {
3636
pub(crate) fn new(frame: Frame) -> Result<Parse, ParseError> {
3737
let array = match frame {
3838
Frame::Array(array) => array,
39-
frame => return Err(format!("protocol error; expected array, got {:?}", frame).into()),
39+
frame => return Err(format!("protocol error; expected array, got {frame:?}").into()),
4040
};
4141

4242
Ok(Parse {
@@ -65,8 +65,7 @@ impl Parse {
6565
.map(|s| s.to_string())
6666
.map_err(|_| "protocol error; invalid string".into()),
6767
frame => Err(format!(
68-
"protocol error; expected simple frame or bulk frame, got {:?}",
69-
frame
68+
"protocol error; expected simple frame or bulk frame, got {frame:?}"
7069
)
7170
.into()),
7271
}
@@ -85,8 +84,7 @@ impl Parse {
8584
Frame::Simple(s) => Ok(Bytes::from(s.into_bytes())),
8685
Frame::Bulk(data) => Ok(data),
8786
frame => Err(format!(
88-
"protocol error; expected simple frame or bulk frame, got {:?}",
89-
frame
87+
"protocol error; expected simple frame or bulk frame, got {frame:?}"
9088
)
9189
.into()),
9290
}
@@ -111,7 +109,7 @@ impl Parse {
111109
// fails, an error is returned.
112110
Frame::Simple(data) => atoi::<u64>(data.as_bytes()).ok_or_else(|| MSG.into()),
113111
Frame::Bulk(data) => atoi::<u64>(&data).ok_or_else(|| MSG.into()),
114-
frame => Err(format!("protocol error; expected int frame but got {:?}", frame).into()),
112+
frame => Err(format!("protocol error; expected int frame but got {frame:?}").into()),
115113
}
116114
}
117115

0 commit comments

Comments
 (0)