Address CR comments

Signed-off-by: Joe Grund <grundjoseph@gmail.com>

Author: jgrund

src/host.rs

@@ -277,17 +277,12 @@ impl Udp {
 
         Ok(UdpSocket::new(addr, rx))
     }
-    pub(crate) fn connect(&mut self, src: SocketAddr, dst: SocketAddr) -> io::Result<()> {
+    pub(crate) fn connect(&mut self, src: SocketAddr, dst: SocketAddr) {
         let Some(bind) = self.binds.get_mut(&src.port()) else {
-            return Err(io::Error::new(
-                io::ErrorKind::NotFound,
-                "Connect failed (no matching bind) for {src}",
-            ));
+            panic!("Connect failed (no matching bind) for {src}");
         };
 
         bind.target_addr = Some(dst);
-
-        Ok(())
     }
 
     fn receive_from_network(&mut self, src: SocketAddr, dst: SocketAddr, datagram: Datagram) {

src/net/udp.rs

@@ -156,12 +156,12 @@ impl UdpSocket {
             }),
         }
     }
-    pub async fn connect<A: ToSocketAddrs>(&self, addr: A) -> io::Result<()> {
+    pub async fn connect<A: ToSocketAddrs>(&self, addr: A) {
         World::current(|world| {
             let addr = addr.to_socket_addr(&world.dns);
             let host = world.current_host_mut();
 
-            host.udp.connect(self.local_addr, addr)
+            host.udp.connect(self.local_addr, addr);
         })
     }
 

tests/udp.rs

@@ -1046,7 +1046,7 @@ fn try_recv_connected() -> Result {
     sim.client("server1", async move {
         let sock = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, 1234)).await?;
 
-        sock.connect(("server2", 5678)).await?;
+        sock.connect(("server2", 5678)).await;
 
         sock.readable().await?;
 
@@ -1079,7 +1079,7 @@ fn try_recv_connected_wrong_host() -> Result {
         let sock = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, 1234)).await?;
 
         // Connect to server3, which doesn't send anything.
-        sock.connect(("server3", 6781)).await?;
+        sock.connect(("server3", 6781)).await;
 
         // Datagram from server2 is filtered so sock never becomes readable.
         tokio::time::timeout(Duration::from_secs(5), sock.readable())