fix: fix test assertions for span-based replacements, add qaIssueCount to KeyCreateDialog, fix n+1 in language delete

Author: Anty0

backend/data/src/main/kotlin/io/tolgee/service/language/LanguageHardDeleter.kt

@@ -49,6 +49,7 @@ class LanguageHardDeleter(
             left join fetch k.branch
             left join fetch t.comments
             left join fetch t.labels
+            left join fetch t.qaIssues
             where t.id in :ids""",
               Translation::class.java,
             ).setParameter("ids", it.map { it.id })

ee/backend/tests/src/test/kotlin/io/tolgee/ee/service/qa/checks/PunctuationMismatchCheckTest.kt

@@ -56,7 +56,7 @@ class PunctuationMismatchCheckTest {
     assertThat(results).hasSize(1)
     assertThat(results[0].message).isEqualTo(QaIssueMessage.QA_PUNCTUATION_ADD)
     assertThat(results[0].params).containsEntry("punctuation", ".")
-    assertThat(results[0].replacement).isEqualTo("Bonjour.")
+    assertThat(results[0].replacement).isEqualTo(".")
   }
 
   @Test
@@ -65,7 +65,7 @@ class PunctuationMismatchCheckTest {
     assertThat(results).hasSize(1)
     assertThat(results[0].message).isEqualTo(QaIssueMessage.QA_PUNCTUATION_REMOVE)
     assertThat(results[0].params).containsEntry("punctuation", "!")
-    assertThat(results[0].replacement).isEqualTo("Bonjour")
+    assertThat(results[0].replacement).isEqualTo("")
   }
 
   @Test
@@ -75,7 +75,7 @@ class PunctuationMismatchCheckTest {
     assertThat(results[0].message).isEqualTo(QaIssueMessage.QA_PUNCTUATION_REPLACE)
     assertThat(results[0].params).containsEntry("punctuation", "!")
     assertThat(results[0].params).containsEntry("expected", ".")
-    assertThat(results[0].replacement).isEqualTo("Bonjour.")
+    assertThat(results[0].replacement).isEqualTo(".")
   }
 
   @Test

ee/backend/tests/src/test/kotlin/io/tolgee/ee/service/qa/checks/SpacesMismatchCheckTest.kt

@@ -45,15 +45,15 @@ class SpacesMismatchCheckTest {
     assertThat(results[0].message).isEqualTo(QaIssueMessage.QA_SPACES_LEADING_ADDED)
     assertThat(results[0].positionStart).isEqualTo(0)
     assertThat(results[0].positionEnd).isEqualTo(2)
-    assertThat(results[0].replacement).isEqualTo("Hello")
+    assertThat(results[0].replacement).isEqualTo("")
   }
 
   @Test
   fun `detects missing leading spaces`() {
     val results = check.check(params("Hello", "  Hello"))
     assertThat(results).hasSize(1)
     assertThat(results[0].message).isEqualTo(QaIssueMessage.QA_SPACES_LEADING_REMOVED)
-    assertThat(results[0].replacement).isEqualTo("  Hello")
+    assertThat(results[0].replacement).isEqualTo("  ")
   }
 
   @Test
@@ -63,25 +63,25 @@ class SpacesMismatchCheckTest {
     assertThat(results[0].message).isEqualTo(QaIssueMessage.QA_SPACES_TRAILING_ADDED)
     assertThat(results[0].positionStart).isEqualTo(5)
     assertThat(results[0].positionEnd).isEqualTo(7)
-    assertThat(results[0].replacement).isEqualTo("Hello")
+    assertThat(results[0].replacement).isEqualTo("")
   }
 
   @Test
   fun `detects missing trailing spaces`() {
     val results = check.check(params("Hello", "Hello  "))
     assertThat(results).hasSize(1)
     assertThat(results[0].message).isEqualTo(QaIssueMessage.QA_SPACES_TRAILING_REMOVED)
-    assertThat(results[0].replacement).isEqualTo("Hello  ")
+    assertThat(results[0].replacement).isEqualTo("  ")
   }
 
   @Test
   fun `detects doubled spaces`() {
     val results = check.check(params("Hello  world", "Hello world"))
     assertThat(results).hasSize(1)
     assertThat(results[0].message).isEqualTo(QaIssueMessage.QA_SPACES_DOUBLED)
-    assertThat(results[0].positionStart).isEqualTo(5)
+    assertThat(results[0].positionStart).isEqualTo(6)
     assertThat(results[0].positionEnd).isEqualTo(7)
-    assertThat(results[0].replacement).isEqualTo(" ")
+    assertThat(results[0].replacement).isEqualTo("")
   }
 
   @Test

webapp/src/views/projects/translations/TranslationHeader/KeyCreateDialog.tsx

@@ -43,6 +43,7 @@ export const KeyCreateDialog: React.FC<Props> = ({
         unresolvedCommentCount: 0,
         activeSuggestionCount: 0,
         totalSuggestionCount: 0,
+        qaIssueCount: 0,
         fromTranslationMemory: false,
         labels: [],
       };