fix: stop the usage popovers reporting limits that did not apply

Two places told an organization something untrue about its plan.

A word plan neither charges nor enforces per seat — getSeatsLimit returns
unlimited for any metric that does not use seats — yet the plan still carries an
includedSeats allowance for its free tier. The dashboard rendered a bar from
that allowance, so an organization with eight members sat permanently at "8 of
3" in red with the top-bar critical warning stuck on, against a limit nothing
would ever enforce. The bar now follows the enforced limit rather than the
allowance.

The plan-limit popover offered auto-upgrade whenever the plan was word based,
not when the word limit was what failed. A batch job running out of MT credits
raises the same counter, so those users were told their word limit was exhausted
and shown a one-click billing change for an unrelated problem. It now requires
the words to actually be exhausted, which the popover can already see in the
usage data it renders.

The seat rule is covered by tests, confirmed to fail without it, and one case
keeps the bar for a plan that does enforce seats so the assertions discriminate.

Author: dkrizan

webapp/src/ee/billing/component/getProgressData.test.ts

@@ -0,0 +1,48 @@
+import { describe, expect, it } from 'vitest';
+import { getProgressData } from './getProgressData';
+
+/**
+ * A word plan carries an includedSeats allowance for its free tier, but nothing enforces it —
+ * the server reports seatsLimit as unlimited. Rendering a bar for it puts an organization
+ * permanently over a limit that does not exist.
+ */
+describe('usage progress', () => {
+  const usage = (overrides = {}) =>
+    ({
+      includedSeats: 3,
+      currentSeats: 8,
+      seatsLimit: -1,
+      includedTranslations: 0,
+      currentTranslations: 0,
+      includedKeys: 0,
+      currentKeys: 0,
+      includedMtCredits: 0,
+      usedMtCredits: 0,
+      includedWords: 50_000,
+      currentWords: 100,
+      isPayAsYouGo: false,
+      ...overrides,
+    }) as any;
+
+  it('hides the seat bar when seats are not enforced', () => {
+    const { seatsProgress } = getProgressData({ usage: usage() });
+
+    expect(seatsProgress.isInUse).toBe(false);
+  });
+
+  it('does not let an unenforced seat count raise the critical warning', () => {
+    // 8 of 3 would otherwise be 266% and pin the top-bar warning on permanently.
+    const { isCritical } = getProgressData({ usage: usage() });
+
+    expect(isCritical).toBe(false);
+  });
+
+  it('still shows the seat bar when seats are enforced', () => {
+    const { seatsProgress } = getProgressData({
+      usage: usage({ seatsLimit: 3 }),
+    });
+
+    expect(seatsProgress.isInUse).toBe(true);
+    expect(seatsProgress.progress).toBeGreaterThan(1);
+  });
+});

webapp/src/ee/billing/component/getProgressData.ts

@@ -11,8 +11,13 @@ export const getProgressData = ({ usage }: { usage: UsageModel }) => {
 
   const keysProgress = new ProgressItem(usage.includedKeys, usage.currentKeys);
 
+  // A word plan neither charges nor enforces per seat — the server reports its seat limit as
+  // unlimited — yet the plan still carries an includedSeats allowance for the free tier. Showing
+  // a bar for it puts an organization permanently over a limit that does not exist, in red, with
+  // the top-bar critical warning stuck on.
+  const seatsEnforced = usage.seatsLimit !== -1;
   const seatsProgress = new ProgressItem(
-    usage.includedSeats,
+    seatsEnforced ? usage.includedSeats : 0,
     usage.currentSeats
   );
 

webapp/src/ee/billing/limitPopover/PlanLimitPopoverCloud.tsx

@@ -41,11 +41,22 @@ export const PlanLimitPopoverCloud: React.FC<
   });
 
   const subscription = subscriptionLoadable.data;
+  const progressData = usage && getProgressData({ usage });
+
+  // The popover opens for any plan-limit error, including a batch job running out of MT credits,
+  // which shares the same counter. Offering auto-upgrade off the plan's metric alone told those
+  // users their word limit was exhausted and put a billing setting one click away for a problem
+  // that had nothing to do with words — so the words have to actually be exhausted.
+  const wordsExhausted = Boolean(
+    progressData?.wordsProgress.isInUse &&
+      progressData.wordsProgress.progress >= 1
+  );
   const wordsAutoUpgradeAvailable = Boolean(
     subscription &&
       subscription.plan.metricType === 'HOSTED_WORDS' &&
       !subscription.plan.free &&
-      !subscription.autoUpgradeEnabled
+      !subscription.autoUpgradeEnabled &&
+      wordsExhausted
   );
 
   const autoUpgradeMutation = useBillingApiMutation({
@@ -77,8 +88,6 @@ export const PlanLimitPopoverCloud: React.FC<
     );
   };
 
-  const progressData = usage && getProgressData({ usage });
-
   return progressData ? (
     <GenericPlanLimitPopover
       onClose={onClose}