Commit 9b79501
committed
fix: keep the shutdown drain inside Kubernetes' grace period, document 0 as auto
Both from dkrizan's review:
- awaitTerminationSeconds was 20 per pool, and Spring destroys pools one at a time,
so four pools could wait up to 80s. The Tolgee chart does not set
terminationGracePeriodSeconds, so pods get Kubernetes' default of 30 and the
kubelet would SIGKILL mid-drain — the wait would cost the whole grace period and
still lose the work it was protecting. 5s per pool keeps the worst case at 20s.
- max-threads treats 0 as "derive it", so someone setting 0 to switch a pool off
gets the derived size instead. The property docs now say so for both pools.1 parent 8af0ae3 commit 9b79501
2 files changed
Lines changed: 14 additions & 3 deletions
File tree
- backend
- app/src/main/kotlin/io/tolgee/configuration
- data/src/main/kotlin/io/tolgee/configuration/tolgee
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
87 | 93 | | |
88 | 94 | | |
89 | 95 | | |
| |||
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
| |||
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
75 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
76 | 81 | | |
77 | 82 | | |
78 | 83 | | |
| |||
0 commit comments