500 while importing (Probably with meta)

[JanCizmar]

Describe the bug
org.hibernate.TransientPropertyValueException: object references an unsaved transient instance - save the transient instance before flushing : io.tolgee.model.dataImport.ImportKey.keyMeta -> io.tolgee.model.key.KeyMeta

To Reproduce
Don't know how to reproduce, but there should be enough info in Sentry

Expected behavior
Should import successfully.

Stack trace

org.hibernate.TransientPropertyValueException: object references an unsaved transient instance - save the transient instance before flushing : io.tolgee.model.dataImport.ImportKey.keyMeta -> io.tolgee.model.key.KeyMeta
    at org.hibernate.engine.spi.CascadingActions$8.noCascade(CascadingActions.java:372)
    at org.hibernate.engine.internal.Cascade.cascade(Cascade.java:173)
    at org.hibernate.event.internal.AbstractFlushingEventListener.cascadeOnFlush(AbstractFlushingEventListener.java:169)
    at org.hibernate.event.internal.AbstractFlushingEventListener.prepareEntityFlushes(AbstractFlushingEventListener.java:152)
    at org.hibernate.event.internal.AbstractFlushingEventListener.preFlush(AbstractFlushingEventListener.java:102)
    at org.hibernate.event.internal.DefaultAutoFlushEventListener.onAutoPreFlush(DefaultAutoFlushEventListener.java:103)
    at org.hibernate.event.service.internal.EventListenerGroupImpl.fireEventOnEachListener(EventListenerGroupImpl.java:127)
    at org.hibernate.internal.SessionImpl.autoPreFlush(SessionImpl.java:1387)
    at org.hibernate.query.sqm.internal.ConcreteSqmSelectQueryPlan.withCacheableSqmInterpretation(ConcreteSqmSelectQueryPlan.java:322)
    at org.hibernate.query.sqm.internal.ConcreteSqmSelectQueryPlan.performList(ConcreteSqmSelectQueryPlan.java:302)
    at org.hibernate.query.sqm.internal.QuerySqmImpl.doList(QuerySqmImpl.java:526)
    at org.hibernate.query.spi.AbstractSelectionQuery.list(AbstractSelectionQuery.java:423)
    at org.hibernate.query.Query.getResultList(Query.java:120)
    at org.springframework.data.jpa.repository.query.JpaQueryExecution$CollectionExecution.doExecute(JpaQueryExecution.java:129)
    at org.springframework.data.jpa.repository.query.JpaQueryExecution.execute(JpaQueryExecution.java:92)
    at org.springframework.data.jpa.repository.query.AbstractJpaQuery.doExecute(AbstractJpaQuery.java:152)
    at org.springframework.data.jpa.repository.query.AbstractJpaQuery.execute(AbstractJpaQuery.java:140)
    at org.springframework.data.repository.core.support.RepositoryMethodInvoker.doInvoke(RepositoryMethodInvoker.java:170)
    at org.springframework.data.repository.core.support.RepositoryMethodInvoker.invoke(RepositoryMethodInvoker.java:158)
    at org.springframework.data.repository.core.support.QueryExecutorMethodInterceptor.doInvoke(QueryExecutorMethodInterceptor.java:169)
    at org.springframework.data.repository.core.support.QueryExecutorMethodInterceptor.invoke(QueryExecutorMethodInterceptor.java:148)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184)
    at org.springframework.data.projection.DefaultMethodInvokingMethodInterceptor.invoke(DefaultMethodInvokingMethodInterceptor.java:70)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184)
    at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:379)
    at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:119)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184)
    at org.springframework.dao.support.PersistenceExceptionTranslationInterceptor.invoke(PersistenceExceptionTranslationInterceptor.java:138)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184)
    at org.springframework.data.jpa.repository.support.CrudMethodMetadataPostProcessor$CrudMethodMetadataPopulatingMethodInterceptor.invoke(CrudMethodMetadataPostProcessor.java:136)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184)
    at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184)
    at org.springframework.data.repository.core.support.MethodInvocationValidator.invoke(MethodInvocationValidator.java:95)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184)
    at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:223)
    at jdk.proxy2.$Proxy331.getAllByProjectId
    at io.tolgee.service.key.KeyService.getAll(KeyService.kt:57)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
    at java.lang.reflect.Method.invoke(Method.java:580)
    at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:355)
    at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:716)
    at io.tolgee.service.key.KeyService$$SpringCGLIB$$1.getAll(<generated>)
    at io.tolgee.service.dataImport.ImportDataManager.existingKeys_delegate$lambda$15(ImportDataManager.kt:85)
    at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
    at io.tolgee.service.dataImport.ImportDataManager.getExistingKeys(ImportDataManager.kt:84)
    at io.tolgee.service.dataImport.CoreImportFilesProcessor.shouldImportKey(CoreImportFilesProcessor.kt:327)
    at io.tolgee.service.dataImport.CoreImportFilesProcessor.processTranslations(CoreImportFilesProcessor.kt:313)
    at io.tolgee.service.dataImport.CoreImportFilesProcessor.processResult(CoreImportFilesProcessor.kt:169)
    at io.tolgee.service.dataImport.CoreImportFilesProcessor.processFile(CoreImportFilesProcessor.kt:108)
    at io.tolgee.service.dataImport.CoreImportFilesProcessor.processFileOrArchive(CoreImportFilesProcessor.kt:90)
    at io.tolgee.service.dataImport.CoreImportFilesProcessor.processFilesRecursive(CoreImportFilesProcessor.kt:72)
    at io.tolgee.service.dataImport.CoreImportFilesProcessor.processFiles(CoreImportFilesProcessor.kt:64)
    at io.tolgee.service.dataImport.ImportService.addFiles(ImportService.kt:102)

Versions and environment

• Tolgee Platform version: [e.g. 3.111.0]
• Environment: Cloud

[jacobras]

I'm running into this on my just-installed self-hosted instance (in Docker). I added two languages + imported their files. Then I added 6 other languages and now I can't upload any file, not even the ones already imported. The error immediately pops up after selecting a file to upload.

Docker logs show the same

Caused by: org.hibernate.TransientPropertyValueException: object references an unsaved transient instance - save the transient instance before flushing : io.tolgee.model.dataImport.ImportKey.keyMeta -> io.tolgee.model.key.KeyMeta

(there's no way to see the logs from the UI, right?)

• All Android XML files
• I tried restarting the container but that didn't fix it
• I tried deleting all languages I added (so I'm back to the state when it worked) but that didn't fix it
• I can still upload files to the Demo project, even the one that's not accepted for my main project

@JanCizmar Would you happen to know any workaround? After this pops up, no file is accepted anymore.

Update! I found something.

If I have this unchecked before uploading, it fails. If I check it, then upload, and then uncheck and proceed, it works! 🎉

[JanCizmar]

This is super ugly bug. It would help us a lot if you can provide exact steps to reproduce on a fresh project, because we have hard time to reproduce this. 🙏 Is there any chance you can provide some steps and the exact files you are importing to reproduce this?

[jacobras]

@JanCizmar I'm actually able to reproduce it with a very small test setup. Here's what I did.

Environment:

• Docker Desktop running on Windows 11 (with WSL2)
• Intel Core i5 1240P (it's the Framework laptop's mainboard I use as a standalone server)
• 32 GB RAM, SSD with plenty of free space

I created a new Docker .. project? using Docker Compose.

docker-compose.yml:

services:
  tolgee:
    image: tolgee/tolgee
    ports:
      - "8085:8080"
    volumes:
      - tolgee_data2:/data
      - ./config.yaml:/config.yaml
    environment:
      spring.config.additional-location: file:///config.yaml

volumes:
  tolgee_data2:

config.yaml:

tolgee:
  authentication:
    enabled: true
    initial-password: admin
    initial-username: admin
  smtp:
    auth: true
    from: Tolgee <no-reply@mydomain.com>
    host: email-smtp.regional-region.amazonaws.com
    password: 'omg/my/password'
    port: 465
    ssl-enabled: true
    username: user@company.com

strings.xml:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <!-- General -->
    <string name="edit">Edit</string>
    <string name="restore">Restore</string>
</resources>

strings2.xml:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <!-- General -->
    <string name="extra">This one's in strings2.xml!</string>
</resources>

Steps:

1. Create new project "Test"
   • English as base language
   • Dutch as second language
2. Upload strings.xml as English
   • [convert placeholders] unchecked
   • [create new keys] checked
3. Now uncheck [create new keys] and drag strings2.xml in

This instantly results in the error for me. Btw: note that on step 2 I already get [import timed out]. I also get this with my main instance all the time, but it does work.

Let me know if you need more information or maybe even the volumes of this test container.

[JanCizmar]

Awesome! Thanks a lot for giving us this context.