Merge pull request #33 from embray/check-signature

fix: actually note whether the pkcs7 signature is valid for the data

Author: tomasmcguinness

PassValidator.Console/ConsoleValidator.cs

@@ -53,6 +53,7 @@ private static bool IsPassSignatureValid(Validator.ValidationResult validationRe
     {
         return !validationResult.HasSignatureExpired &&
                 validationResult.HasSignature &&
+                validationResult.SignatureValid &&
                 validationResult.SignedByApple;
     }
 

PassValidator.Console/VerbosePrinter.cs

@@ -24,6 +24,7 @@ public static void PrintValidationResults(bool isVerbose, ValidationResult valid
         System.Console.WriteLine($"\tPass Type Identifier Matches: {validationResult.PassTypeIdentifierMatches}");
         System.Console.WriteLine($"\tSigned By Apple: {validationResult.SignedByApple}");
         System.Console.WriteLine($"\tSignature Expiration Date: {validationResult.SignatureExpirationDate}");
+        System.Console.WriteLine($"\tSignature Valid: {validationResult.SignatureValid}");
         System.Console.WriteLine($"\tHas Icon 3x: {validationResult.HasIcon3x}");
         System.Console.WriteLine($"\tHas Icon 2x: {validationResult.HasIcon2x}");
         System.Console.WriteLine($"\tHas Icon 1x: {validationResult.HasIcon1x}");

PassValidator.Validator/ValidationResult.cs

@@ -18,6 +18,8 @@ public class ValidationResult
 
     public string SignatureExpirationDate { get; set; }
 
+    public bool SignatureValid { get; set; }
+
     public bool HasIcon3x { get; set; }
 
     public bool HasIcon2x { get; set; }

PassValidator.Validator/Validator.cs

@@ -150,10 +150,11 @@ public ValidationResult Validate(byte[] passContent)
         try
         {
             signedCms.CheckSignature(true);
+            result.SignatureValid = true;
         }
         catch
         {
-            // ignored
+            result.SignatureValid = false;
         }
 
         var signer = signedCms.SignerInfos[0];