Add test for pointOnFeature

Author: kgiann78

measurement/measurement_test.go

@@ -1608,9 +1608,10 @@ func TestInBBox(t *testing.T)  {
 
 func TestInRing(t *testing.T) {
 	tests := map[string]struct {
-		point   geometry.Point
-		ring    []geometry.Point
-		want    bool
+		point   		geometry.Point
+		ring    		[]geometry.Point
+		ignoreBoundary 	bool
+		want    		bool
 	} {
 		"point in ring": {
 			point: geometry.Point{
@@ -1639,6 +1640,7 @@ func TestInRing(t *testing.T) {
 					Lat: 0.0,
 				},
 			},
+			ignoreBoundary: false,
 			want: true,
 		},
 		"point not in ring": {
@@ -1668,13 +1670,74 @@ func TestInRing(t *testing.T) {
 					Lat: 0.0,
 				},
 			},
+			ignoreBoundary: false,
+			want: false,
+		},
+		"point on ring": {
+			point: geometry.Point{
+				Lng: 0.0,
+				Lat: 0.0,
+			},
+			ring: []geometry.Point {
+				{
+					Lng: 0.0,
+					Lat: 0.0,
+				},
+				{
+					Lng: 0.0,
+					Lat: 100.0,
+				},
+				{
+					Lng: 100.0,
+					Lat: 100.0,
+				},
+				{
+					Lng: 100.0,
+					Lat: 0.0,
+				},
+				{
+					Lng: 0.0,
+					Lat: 0.0,
+				},
+			},
+			ignoreBoundary: false,
+			want: true,
+		},
+		"point on ring, ignore boundary": {
+			point: geometry.Point{
+				Lng: 0.0,
+				Lat: 0.0,
+			},
+			ring: []geometry.Point {
+				{
+					Lng: 0.0,
+					Lat: 0.0,
+				},
+				{
+					Lng: 0.0,
+					Lat: 100.0,
+				},
+				{
+					Lng: 100.0,
+					Lat: 100.0,
+				},
+				{
+					Lng: 100.0,
+					Lat: 0.0,
+				},
+				{
+					Lng: 0.0,
+					Lat: 0.0,
+				},
+			},
+			ignoreBoundary: true,
 			want: false,
 		},
 	}
 
 	for name, tt := range tests {
 		t.Run(name, func(t *testing.T) {
-			assert.Equal(t, inRing(tt.point, tt.ring, false), tt.want)
+			assert.Equal(t, inRing(tt.point, tt.ring, tt.ignoreBoundary), tt.want)
 		})
 	}
 }
@@ -1728,3 +1791,92 @@ func TestInPolygon(t *testing.T) {
 		})
 	}
 }
+
+
+func TestPointOnFeature(t *testing.T) {
+	fs, err := createFeature(t, AreaPolygon)
+	if err != nil {
+		t.Errorf("createFeature error = %v", err)
+	}
+
+	p, err := PointOnFeature(*fs, nil, "")
+	if err != nil {
+		t.Errorf("PointOnFeature error = %v", err)
+	} else {
+		if p == nil {
+			t.Error("point cannot be empty")
+		}
+		if p != nil {
+			assert.Equal(t, p.Lng, 133.0)
+			assert.Equal(t, p.Lat, -26.857142857142858)
+		}
+		return
+	}
+}
+
+func TestPointOnFeatureOfImbalancedPolygon(t *testing.T) {
+	fs, err := createFeature(t, ImbalancedPolygon)
+	if err != nil {
+		t.Errorf("createFeature error = %v", err)
+	}
+
+	p, err := PointOnFeature(*fs, nil, "")
+	if err != nil {
+		t.Errorf("PointOnFeature error = %v", err)
+	} else {
+		if p == nil {
+			t.Error("point cannot be empty")
+		}
+		if p != nil {
+			assert.Equal(t, p.Lng, 4.851791984156558)
+			assert.Equal(t, p.Lat, 45.78143055383553)
+		}
+		return
+	}
+}
+
+func TestPointOnFeatureCollection(t *testing.T) {
+	fc, err := createFeatureCollection(t, AreaFeatureCollection)
+	if err != nil {
+		t.Errorf("createFeatureCollection error: %v", err)
+	}
+
+	p, err := PointOnFeatureCollection(*fc, nil, "")
+	if err != nil {
+		t.Errorf("PointOnFeature error = %v", err)
+	} else {
+		if p == nil {
+			t.Error("point cannot be empty")
+		}
+		if p != nil {
+			assert.Equal(t, p.Lng, 6.774169921875)
+			assert.Equal(t, p.Lat, 47.486422855836416)
+		}
+		return
+	}
+}
+
+
+func createFeature(t *testing.T, geometryString string) (*feature.Feature, error) {
+	gjson, err := utils.LoadJSONFixture(geometryString)
+	if err != nil {
+		t.Errorf("LoadJSONFixture error: %v", err)
+	}
+	fs, err := feature.FromJSON(gjson)
+	if err != nil {
+		t.Errorf("FromJSON error: %v", err)
+	}
+	return fs, err
+}
+
+func createFeatureCollection(t *testing.T, geometryString string) (*feature.Collection, error) {
+	gjson, err := utils.LoadJSONFixture(geometryString)
+	if err != nil {
+		t.Errorf("LoadJSONFixture error: %v", err)
+	}
+	fs, err := feature.CollectionFromJSON(gjson)
+	if err != nil {
+		t.Errorf("FromJSON error: %v", err)
+	}
+	return fs, err
+}