Skip to content

Commit d714db1

Browse files
tomconroyclaude
andcommitted
Patch norad for empty guideline names
Google's roboto-serif repo (and others in the wild) has UFOs whose fontinfo guidelines carry name=""; released norad (<=0.18.4) rejects the whole fontinfo load over it, so fontc fails the build with 'failed to load font info data'. linebender/norad#414 fixed this on norad main (1c8ac19) but no release carries it yet, so pin norad to that rev alongside the fontations patch. Drop when norad ships a release past 0.18.4. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent be8eb45 commit d714db1

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,3 +62,6 @@ font-types = { git = "https://github.com/tomconroy/fontations.git", rev = "66820
6262
read-fonts = { git = "https://github.com/tomconroy/fontations.git", rev = "668202b5" }
6363
write-fonts = { git = "https://github.com/tomconroy/fontations.git", rev = "668202b5" }
6464
skrifa = { git = "https://github.com/tomconroy/fontations.git", rev = "668202b5" }
65+
# norad with linebender/norad#414 (empty guideline names); drop once norad
66+
# ships a release past 0.18.4.
67+
norad = { git = "https://github.com/linebender/norad.git", rev = "1c8ac19b1a1a4d21bb27d72161b63043cd42cc52" }

0 commit comments

Comments
 (0)