Clean up comments and improve readability in Notifications and UI components

Author: tomekdot

src/notifications/Notifications.as

@@ -1,4 +1,3 @@
-/*
 /*
  * =============================================================================
  * @namespace Notifications

src/ui/UI.as

@@ -3,6 +3,11 @@
  * Provides options to toggle UI windows and run tests.
  */
 void RenderMenu() {
+    // Only show the entry in the Plugins dropdown when it is NOT already shown on the
+    // main menu bar (RenderMenuMain). This avoids a duplicate "Event Calendar" entry
+    // while always leaving exactly one way to open the window.
+    if (S_ShowCalendarInMainMenu) return;
+
     // Single top-level menu item that toggles the calendar window.
     if (UI::MenuItem(Icons::CalendarO + " " + "Event Calendar", "", g_UIState.ShowCalendarWindow)) {
         g_UIState.ShowCalendarWindow = !g_UIState.ShowCalendarWindow;
@@ -192,46 +197,6 @@ void RenderCalendarGrid() {
     UI::EndTable();
 }
 
-/*
- * Renders the list of events for the currently selected day.
- */
-void RenderEventList() {
-    UI::Text("Events for: " + g_UIState.CalYear + "-" + TimeUtils::Two(g_UIState.CalMonth) + "-" + TimeUtils::Two(g_UIState.SelectedDay));
-    
-    UI::BeginChild("EventList", vec2(0, -1), true);
-    if (g_IsLoading) {
-        UI::TextDisabled("Loading...");
-    } else if (g_Events.IsEmpty()) {
-        UI::TextDisabled("No events loaded.");
-    } else {
-        bool foundEvent = false;
-        // Iterate through all events to find ones matching the selected day.
-        string key = tostring(g_UIState.SelectedDay);
-        if (g_MonthEventCache.Exists(key)) {
-            array<EventItem@>@ dayList = cast<array<EventItem@>@>(g_MonthEventCache[key]);
-            if (dayList !is null) {
-                // Sort for display
-                Helpers::SortEventsByStart(dayList);
-                for (uint i = 0; i < dayList.Length; i++) {
-                    auto@ e = dayList[i];
-                    if (e is null) continue;
-                    int Y, M, D, h, m, s;
-                    TimeUtils::UtcYMDHMSFromMs(e.startMs, Y, M, D, h, m, s);
-                    string tag = e.source.Length > 0 ? ("[" + e.source + "] ") : "";
-                    string dur = e.durationSec > 0 ? (" (" + tostring(e.durationSec/60) + "m)") : "";
-                    UI::Text(Moon::PhaseEmojiForTitleLower(e.title) + " " + TimeUtils::Two(h) + ":" + TimeUtils::Two(m) + " - " + tag + e.title + dur);
-                }
-                foundEvent = dayList.Length > 0;
-            }
-        }
-        
-        if (!foundEvent) {
-            UI::TextDisabled("No events for this day.");
-        }
-    }
-    UI::EndChild();
-}
-
 /*
  * Renders a small footer at the bottom of the window for status information.
  */

src/utils/Helpers.as

@@ -185,7 +185,7 @@ namespace Helpers {
             while (j >= 0) {
                 EventItem@ prev   = arr[uint(j)];
                 int64      prevMs = prev is null ? 0 : prev.startMs;
-                int64      keyMs  = key is null ? 0 : key.startMs;
+                int64      keyMs  = key  is null ? 0 : key.startMs;
                 if (prevMs <= keyMs) break;
                 @arr[uint(j + 1)] = prev;
                 j--;

src/utils/Utils.as

@@ -65,12 +65,19 @@ namespace Moon {
      * @return A color vector (RGBA).
      */
     vec4 PhaseColorForTitleLower(const string &in t) {
-        switch (GetPhaseKind(t)) { 
-            case PhaseKind::PK_NM: return vec4(0.5, 0.5, 0.5, 1.0); // Grey
-            case PhaseKind::PK_FQ: return vec4(0.6, 0.6, 0.6, 1.0); // Light Grey
-            case PhaseKind::PK_FM: return vec4(0.7, 0.7, 0.7, 1.0); // Lighter Grey
-            case PhaseKind::PK_LQ: return vec4(0.4, 0.4, 0.4, 1.0); // Dark Grey
-            default: return vec4(0.3, 0.3, 0.3, 1.0);               // Darkest Grey (Intermediate)
+        // Brightness follows the real illuminated fraction of the Moon's disc,
+        // but kept in a mid range so the button text stays readable on every phase
+        // (a near-white background would hide the light text).
+        //   Full Moon      = brightest
+        //   First/Last Qtr = mid
+        //   Intermediate   = darker
+        //   New Moon       = darkest
+        switch (GetPhaseKind(t)) {
+            case PhaseKind::PK_FM: return vec4(0.62, 0.62, 0.62, 1.0); // Full Moon  - brightest (still readable)
+            case PhaseKind::PK_FQ: return vec4(0.52, 0.52, 0.52, 1.0); // First Quarter - mid
+            case PhaseKind::PK_LQ: return vec4(0.52, 0.52, 0.52, 1.0); // Last Quarter  - mid
+            case PhaseKind::PK_NM: return vec4(0.34, 0.34, 0.34, 1.0); // New Moon   - darkest
+            default:               return vec4(0.43, 0.43, 0.43, 1.0); // Intermediate - between new & quarter
         }
     }
 
@@ -106,8 +113,8 @@ namespace TimeUtils {
     string FriendlyDeltaLong(int64 deltaMs) {
         int64 totalSeconds = Math::Abs(deltaMs) / 1000;
 
-        int days = int(totalSeconds / 86400); totalSeconds %= 86400;
-        int hours = int(totalSeconds / 3600); totalSeconds %= 3600;
+        int days    = int(totalSeconds / 86400); totalSeconds %= 86400;
+        int hours   = int(totalSeconds / 3600); totalSeconds %= 3600;
         int minutes = int(totalSeconds / 60);
         int seconds = int(totalSeconds % 60);