modify README and support Wiki with lightbox

Author: tomy-shen

README.md

@@ -1,5 +1,8 @@
 # Redmine Lightbox 3
 
+![Redmine](https://img.shields.io/badge/Redmine-6.0-brightgreen)
+[![Software License](https://img.shields.io/badge/license-MIT-blueviolet.svg)](LICENSE)
+
 This plugin lets you preview image (JPG, GIF, PNG, BMP) and PDF attachments in a lightbox.
 
 This is a fork of paginagmbh's [redmine_lightbox2](https://github.com/paginagmbh/redmine_lightbox2) plugin.

app/assets/javascripts/lightbox.js

@@ -1,9 +1,7 @@
 /*
- * Lightbox3 for Redmine 6 - The Truly Final Version
+ * Lightbox3 for Redmine 6 - Final Hybrid Version
  *
- * This script is the definitive solution based on all previous debugging sessions.
- * It works without ERB overrides and handles all known contexts (main attachments,
- * journal attachments, images, and PDFs).
+ * This version incorporates the correct selector (`a.thumbnail`) for Wiki pages
  */
 $(document).ready(function() {
 
@@ -12,7 +10,6 @@ $(document).ready(function() {
         var $link = $(linkElement);
         var href = $link.attr('href');
 
-        // Ignore links that we know shouldn't have a lightbox (like delete buttons)
         if (!href || $link.hasClass('delete') || $link.hasClass('icon-del')) {
             return;
         }
@@ -31,35 +28,51 @@ $(document).ready(function() {
     // --- Apply the logic to DIFFERENT sections of Redmine ---
 
     // 1. Main Attachment Block (top of issue, documents, files, etc.)
-    // This targets all links inside the main attachments block.
     $('div.attachments a').each(function() {
         applyLightbox(this);
     });
 
-    // 2. Journal / Notes Section - a special case with broken links
-    // It has two types of links that need fixing before applying lightbox.
-
-    // 2a. Journal Thumbnails & Filename links
+    // 2. Journal / Notes Section
     $('div.journal div.thumbnails a, div.journal ul.details a[href*="/attachments/"]:not(.icon-download)').each(function() {
         var $link = $(this);
-        var wrongHref = $link.attr('href'); // e.g., /attachments/8
+        var wrongHref = $link.attr('href');
         var filename = $link.find('img').attr('title') || $link.text().trim();
 
         if (wrongHref && filename) {
             var attachmentId = wrongHref.split('/')[2];
             if ($.isNumeric(attachmentId)) {
-                // First, rewrite the broken href to the correct download path
                 var correctHref = '/attachments/download/' + attachmentId + '/' + filename;
                 $link.attr('href', correctHref);
-                // After fixing the link, process it to see if it needs a lightbox
+                applyLightbox(this);
+            }
+        }
+    });
+    
+    // 3. UPDATED - Wiki Embedded Thumbnails (Using the correct selector now)
+    // This targets images embedded with the {{thumbnail()}} macro using the `a.thumbnail` class.
+    $('div.wiki a.thumbnail').each(function() {
+        var $link = $(this);
+        var wrongHref = $link.attr('href');
+        var $image = $link.find('img');
+        
+        // For these wiki thumbnails, the filename is in the 'alt' attribute.
+        var filename = $image.attr('alt'); 
+
+        if (wrongHref && filename) {
+            var attachmentId = wrongHref.split('/')[2];
+            if ($.isNumeric(attachmentId)) {
+                // Rebuild the href to point to the correct download path
+                var correctHref = '/attachments/download/' + attachmentId + '/' + filename;
+                $link.attr('href', correctHref);
+                
+                // After fixing the link, process it to add the lightbox class.
                 applyLightbox(this);
             }
         }
     });
 
 
     // --- Precautionary fix for the duplicate icon mystery ---
-    // This will clean up any duplicate download icons, regardless of their source.
     $('div.journal ul.details li:contains("File")').each(function() {
         var $downloadIcons = $(this).find('a.icon-download');
         if ($downloadIcons.length > 1) {
@@ -69,10 +82,9 @@ $(document).ready(function() {
 
 
     // --- INITIALIZE LIGHTBOX ---
-    // Finally, after all links have been corrected and classes applied, initialize fancybox.
     $('a.lightbox').fancybox({
         iframe: {
-            preload: false // Recommended setting for PDFs
+            preload: false
         }
     });