🗄 [chore][backend] Remove read_event in favor of read_events

Author: tomy0000000

backend/kayman/crud/event.py

@@ -26,10 +26,6 @@ def create_events(
     return db_events
 
 
-def read_event(session: Session, event_id: int) -> Event | None:
-    return session.get(Event, event_id)
-
-
 def read_events(
     session: Session,
     event_ids: Collection[int] | None = None,

backend/kayman/routers/event.py

@@ -8,7 +8,6 @@
 from kayman.core.db import get_session
 from kayman.crud.event import (
     create_events,
-    read_event,
     read_events,
 )
 from kayman.schemas.api_models import EventReadDetailed
@@ -40,10 +39,10 @@ def create(*, session: Session = Depends(get_session), event: EventCreate) -> Ev
 
 @event_router.get("/{event_id}", name="Read Event", response_model=EventReadDetailed)
 def read(*, session: Session = Depends(get_session), event_id: int) -> EventBase:
-    event = read_event(session, event_id)
-    if event is None:
+    events = read_events(session, event_ids=[event_id])
+    if not events:
         raise HTTPException(status_code=404, detail="Event not found")
-    return event
+    return events[0]
 
 
 @event_router.get("", name="Read Events", response_model=list[EventReadDetailed])

backend/kayman/tests/crud/test_event.py

@@ -4,7 +4,7 @@
 import pytest
 from sqlmodel import Session
 
-from kayman.crud.event import create_events, read_event, read_events, update_events
+from kayman.crud.event import create_events, read_events, update_events
 from kayman.schemas.event import EventType, EventUpdate
 from kayman.tests.factories import (
     CategoryFactory,
@@ -56,27 +56,23 @@ def test_create_events_no_commit(session: Session, session_2: Session):
     assert session_event.type == event.type
 
     # The event should not be visible to other sessions (yet)
-    session_2_event = read_event(session_2, session_event.id)
-    assert session_2_event is None
+    session_2_events = read_events(session_2, event_ids=[session_event.id])
+    assert len(session_2_events) == 0
 
     # Commit the event from main session
     session.commit()
 
     # The event should now be visible to other sessions
-    session_3_event = read_event(session_2, session_event.id)
-    assert session_3_event is not None
+    session_3_events = read_events(session_2, event_ids=[session_event.id])
+    assert len(session_3_events) == 1
+    session_3_event = session_3_events[0]
     assert session_3_event.id == session_event.id
     assert session_3_event.description == session_event.description
     assert session_3_event.timestamp == session_event.timestamp
     assert session_3_event.timezone == session_event.timezone
     assert session_3_event.type == session_event.type
 
 
-def test_read_event(session: Session):
-    event = EventFactory()
-    assert read_event(session, event.id) == event
-
-
 def test_read_events_by_ids(session: Session):
     event_1 = EventFactory()
     event_2 = EventFactory()