Skip to content

Commit cdb2abf

Browse files
committed
❇️ [refactor][backend] Rename transaction column
1 parent 2c3886f commit cdb2abf

5 files changed

Lines changed: 50 additions & 13 deletions

File tree

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
"""rename transaction.payment_id to event_id
2+
3+
Revision ID: 52d7da73b2b4
4+
Revises: d09182f71aa6
5+
Create Date: 2026-06-24 00:00:22.250836
6+
7+
"""
8+
9+
from alembic import op
10+
11+
# revision identifiers, used by Alembic.
12+
revision = '52d7da73b2b4'
13+
down_revision = 'd09182f71aa6'
14+
branch_labels = None
15+
depends_on = None
16+
17+
18+
def upgrade():
19+
op.alter_column("transaction", "payment_id", new_column_name="event_id")
20+
op.execute(
21+
"ALTER TABLE transaction RENAME CONSTRAINT "
22+
"transaction_payment_id_index_key TO transaction_event_id_index_key"
23+
)
24+
op.execute(
25+
"ALTER TABLE transaction RENAME CONSTRAINT "
26+
"transaction_payment_id_fkey TO transaction_event_id_fkey"
27+
)
28+
29+
30+
def downgrade():
31+
op.execute(
32+
"ALTER TABLE transaction RENAME CONSTRAINT "
33+
"transaction_event_id_fkey TO transaction_payment_id_fkey"
34+
)
35+
op.execute(
36+
"ALTER TABLE transaction RENAME CONSTRAINT "
37+
"transaction_event_id_index_key TO transaction_payment_id_index_key"
38+
)
39+
op.alter_column("transaction", "event_id", new_column_name="payment_id")

backend/kayman/routers/event.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ def create(
289289
TransactionBase.model_validate(
290290
transaction,
291291
update={
292-
"payment_id": event_id,
292+
"event_id": event_id,
293293
"index": transaction_index,
294294
},
295295
)

backend/kayman/schemas/transaction.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
class TransactionBase(SQLModel):
1515
account_id: int = Field(foreign_key="account.id")
16-
payment_id: int | None = Field(foreign_key="event.id", default=None)
16+
event_id: int | None = Field(foreign_key="event.id", default=None)
1717
amount: Decimal
1818
created_at: datetime = Field(
1919
default_factory=lambda: datetime.now(UTC),
@@ -31,9 +31,7 @@ class TransactionBase(SQLModel):
3131

3232
class Transaction(TransactionBase, table=True):
3333
__table_args__ = (
34-
UniqueConstraint(
35-
"payment_id", "index", name="transaction_payment_id_index_key"
36-
),
34+
UniqueConstraint("event_id", "index", name="transaction_event_id_index_key"),
3735
)
3836
id: int | None = Field(primary_key=True, default=None)
3937
account: "Account" = Relationship(back_populates="transactions")

backend/kayman/tests/crud/test_transaction.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def test_create_transactions_1_txn(session: Session):
1313
txn = TransactionBase.model_validate(
1414
txn_create,
1515
update={
16-
"payment_id": 1,
16+
"event_id": 1,
1717
"index": 0,
1818
},
1919
)
@@ -24,7 +24,7 @@ def test_create_transactions_1_txn(session: Session):
2424
assert db_txn.amount == txn.amount
2525
assert db_txn.description == txn.description
2626
assert db_txn.index == txn.index
27-
assert db_txn.payment_id == txn.payment_id
27+
assert db_txn.event_id == txn.event_id
2828
assert db_txn.created_at == txn.created_at
2929
assert db_txn.posted_at == txn.posted_at
3030
assert db_txn.reconciled_at == txn.reconciled_at
@@ -38,7 +38,7 @@ def test_create_transactions_n_txn(session: Session):
3838
TransactionBase.model_validate(
3939
txn_create,
4040
update={
41-
"payment_id": 1,
41+
"event_id": 1,
4242
"index": txn_index,
4343
},
4444
)
@@ -52,7 +52,7 @@ def test_create_transactions_n_txn(session: Session):
5252
assert db_txn.amount == txn.amount
5353
assert db_txn.description == txn.description
5454
assert db_txn.index == txn.index
55-
assert db_txn.payment_id == txn.payment_id
55+
assert db_txn.event_id == txn.event_id
5656
assert db_txn.created_at == txn.created_at
5757
assert db_txn.posted_at == txn.posted_at
5858
assert db_txn.reconciled_at == txn.reconciled_at
@@ -63,7 +63,7 @@ def test_create_transactions_no_commit(session: Session, session_2: Session):
6363
txn = TransactionBase.model_validate(
6464
txn_create,
6565
update={
66-
"payment_id": 1,
66+
"event_id": 1,
6767
"index": 0,
6868
},
6969
)
@@ -75,7 +75,7 @@ def test_create_transactions_no_commit(session: Session, session_2: Session):
7575
assert session_txn.amount == txn.amount
7676
assert session_txn.description == txn.description
7777
assert session_txn.index == txn.index
78-
assert session_txn.payment_id == txn.payment_id
78+
assert session_txn.event_id == txn.event_id
7979
assert session_txn.created_at == txn.created_at
8080
assert session_txn.posted_at == txn.posted_at
8181
assert session_txn.reconciled_at == txn.reconciled_at
@@ -95,7 +95,7 @@ def test_create_transactions_no_commit(session: Session, session_2: Session):
9595
assert session_2_txn.amount == txn.amount
9696
assert session_2_txn.description == txn.description
9797
assert session_2_txn.index == txn.index
98-
assert session_2_txn.payment_id == txn.payment_id
98+
assert session_2_txn.event_id == txn.event_id
9999
assert session_2_txn.created_at == txn.created_at
100100
assert session_2_txn.posted_at == txn.posted_at
101101
assert session_2_txn.reconciled_at == txn.reconciled_at

backend/kayman/tests/factories/transaction.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class Meta:
1515
description = factory.Faker("sentence")
1616
index = factory.Sequence(lambda n: n)
1717
event = factory.SubFactory("kayman.tests.factories.event.EventFactory")
18-
payment_id = factory.SelfAttribute("event.id")
18+
event_id = factory.SelfAttribute("event.id")
1919
created_at = factory.Faker("date_time")
2020
posted_at = factory.Faker("date_time")
2121
reconciled_at = factory.Faker("date_time")

0 commit comments

Comments
 (0)