❇️ [refactor][backend] EventEntryCreate inherits Base, generalize create CRUD

Author: tomy0000000

backend/kayman/crud/event_entry.py

@@ -2,12 +2,12 @@
 
 from sqlmodel import Session
 
-from kayman.schemas.event_entry import EventEntry, EventEntryBase
+from kayman.schemas.event_entry import EventEntry, EventEntryBase, EventEntryCreate
 
 
 def create_event_entries(
     session: Session,
-    entries: list[EventEntryBase],
+    entries: Sequence[EventEntryCreate],
     commit: bool = True,
 ) -> Sequence[EventEntryBase]:
     db_entries = [EventEntry.model_validate(entry) for entry in entries]

backend/kayman/schemas/api_models.py

@@ -14,6 +14,7 @@ class EventReadDetailed(EventRead):
     entries: list[EventEntryRead]
 
 
+# TODO: test-only after legacy_create removal, remove once validate_total is gone
 class EventCreateDetailed(SQLModel):
     """Includes transactions and entries."""
 

backend/kayman/schemas/event_entry.py

@@ -30,12 +30,8 @@ class EventEntry(EventEntryBase, table=True):
     currency: "Currency" = Relationship(back_populates="entries")
 
 
-class EventEntryCreate(SQLModel):
-    category_id: int
-    amount: Decimal
-    quantity: int
-    currency_code: str
-    description: str | None = None
+class EventEntryCreate(EventEntryBase):
+    pass
 
 
 class EventEntryRead(EventEntryBase):

backend/kayman/tests/crud/test_event_entry.py

@@ -3,7 +3,7 @@
 from sqlmodel import Session
 
 from kayman.crud.event_entry import create_event_entries
-from kayman.schemas.event_entry import EventEntry, EventEntryBase
+from kayman.schemas.event_entry import EventEntry, EventEntryCreate
 from kayman.tests.factories import (
     CategoryFactory,
     CurrencyFactory,
@@ -17,7 +17,7 @@ def test_create_event_entries(session: Session):
     category = CategoryFactory()
     currency = CurrencyFactory()
     entries = [
-        EventEntryBase.model_validate(entry)
+        EventEntryCreate.model_validate(entry)
         for entry in EventEntryFactory.build_batch(
             3,
             event_id=event.id,
@@ -48,7 +48,7 @@ def test_create_event_entries_no_commit(session: Session, session_2: Session):
     event = EventFactory()
     category = CategoryFactory()
     currency = CurrencyFactory()
-    entry = EventEntryBase.model_validate(
+    entry = EventEntryCreate.model_validate(
         EventEntryFactory.build(
             event_id=event.id,
             category_id=category.id,
@@ -79,7 +79,7 @@ def test_create_event_entries_no_commit(session: Session, session_2: Session):
 def test_create_event_entries_event_not_found(session: Session):
     category = CategoryFactory()
     currency = CurrencyFactory()
-    entry = EventEntryBase.model_validate(
+    entry = EventEntryCreate.model_validate(
         EventEntryFactory.build(
             event_id=999999,
             category_id=category.id,

backend/kayman/tests/factories/event.py

@@ -22,9 +22,13 @@ def build_details(cls, type=EventType.Expense, entry_num=1, transaction_num=1):
         from kayman.tests.factories.event_entry import EventEntryFactory
         from kayman.tests.factories.transaction import TransactionFactory
 
-        # Create entries and transactions
+        # Create entries and transactions. event_id is a placeholder: these are
+        # never persisted, but EventEntryCreate (validated inside
+        # EventCreateDetailed) requires it.
         entries_currency = CurrencyFactory.build()
-        entries = EventEntryFactory.build_batch(entry_num, currency=entries_currency)
+        entries = EventEntryFactory.build_batch(
+            entry_num, currency=entries_currency, event_id=0
+        )
         transactions = TransactionFactory.build_batch(transaction_num)
 
         # Calculate totals