❇️ [refactor][backend] Rename PaymentType to EventType

Author: tomy0000000

backend/alembic/versions/d09182f71aa6_rename_paymenttype_enum_to_eventtype.py

@@ -0,0 +1,23 @@
+"""rename paymenttype enum to eventtype
+
+Revision ID: d09182f71aa6
+Revises: 7365aeb08d01
+Create Date: 2026-06-23 23:26:13.393096
+
+"""
+
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision = 'd09182f71aa6'
+down_revision = '7365aeb08d01'
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    op.execute("ALTER TYPE paymenttype RENAME TO eventtype")
+
+
+def downgrade():
+    op.execute("ALTER TYPE eventtype RENAME TO paymenttype")

backend/kayman/logics/event.py

@@ -1,7 +1,7 @@
 from decimal import Decimal
 
 from kayman.schemas.api_models import PaymentCreateDetailed
-from kayman.schemas.event import PaymentType
+from kayman.schemas.event import EventType
 
 
 def validate_total(details: PaymentCreateDetailed) -> None:
@@ -10,7 +10,7 @@ def validate_total(details: PaymentCreateDetailed) -> None:
         return
 
     # Payment type of transfer or exchange is not checked
-    if details.payment.type in (PaymentType.Transfer, PaymentType.Exchange):
+    if details.payment.type in (EventType.Transfer, EventType.Exchange):
         return
 
     entries_total = Decimal(
@@ -20,14 +20,14 @@ def validate_total(details: PaymentCreateDetailed) -> None:
         sum([transaction.amount for transaction in details.transactions])
     )
 
-    if details.payment.type is PaymentType.Expense:
+    if details.payment.type is EventType.Expense:
         if entries_total != -transactions_total:
             raise ValueError(
                 f"Entries total ({entries_total}) and "
                 f"transactions total ({-transactions_total}) do not match"
             )
 
-    if details.payment.type is PaymentType.Income:
+    if details.payment.type is EventType.Income:
         if entries_total != transactions_total:
             raise ValueError(
                 f"Entries total ({entries_total}) and "

backend/kayman/schemas/event.py

@@ -14,27 +14,16 @@
     from kayman.schemas.currency import Currency
     from kayman.schemas.transaction import Transaction
 
-#
-# Payment Category
-#
 
-
-class PaymentType(enum.Enum):
+class EventType(enum.Enum):
     Expense = "Expense"
     Income = "Income"
     Transfer = "Transfer"
     Exchange = "Exchange"
 
 
-#
-# Payment
-#
-
-
 class EventBase(SQLModel):
-    type: PaymentType = Field(
-        sa_column=Column(sqlmodel.Enum(PaymentType), nullable=False)
-    )
+    type: EventType = Field(sa_column=Column(sqlmodel.Enum(EventType), nullable=False))
     timestamp: datetime = Field(
         sa_column=Column(DateTime(timezone=True), nullable=False),
         title="Local timestamp, or timezone-aware timestamp",

backend/kayman/tests/factories/event.py

@@ -3,7 +3,7 @@
 
 from kayman.schemas import Event
 from kayman.schemas.api_models import PaymentCreateDetailed
-from kayman.schemas.event import PaymentType
+from kayman.schemas.event import EventType
 
 
 class EventFactory(SQLAlchemyModelFactory):
@@ -14,10 +14,10 @@ class Meta:
     description = factory.Faker("sentence")
     timestamp = factory.Faker("date_time")
     timezone = "UTC"
-    type = factory.Faker("random_element", elements=list(PaymentType))
+    type = factory.Faker("random_element", elements=list(EventType))
 
     @classmethod
-    def build_details(cls, type=PaymentType.Expense, entry_num=1, transaction_num=1):
+    def build_details(cls, type=EventType.Expense, entry_num=1, transaction_num=1):
         from kayman.tests.factories.currency import CurrencyFactory
         from kayman.tests.factories.payment_entry import PaymentEntryFactory
         from kayman.tests.factories.transaction import TransactionFactory
@@ -31,12 +31,12 @@ def build_details(cls, type=PaymentType.Expense, entry_num=1, transaction_num=1)
         entries_total = sum([entry.amount * entry.quantity for entry in entries])
         transactions_total = sum([transaction.amount for transaction in transactions])
 
-        if type is PaymentType.Expense:
+        if type is EventType.Expense:
             # Update last transaction amount to match the total
             # entries_total == -transactions_total
             transactions[-1].amount -= entries_total + transactions_total
 
-        if type is PaymentType.Income:
+        if type is EventType.Income:
             # Update last transaction amount to match the total
             # entries_total == transactions_total
             transactions[-1].amount -= transactions_total - entries_total

backend/kayman/tests/logics/test_event.py

@@ -1,22 +1,22 @@
 import pytest
 
 from kayman.logics.event import validate_total
-from kayman.schemas.event import PaymentType
+from kayman.schemas.event import EventType
 from kayman.tests.factories import EventFactory
 
 
 def test_validate_total_expense():
     """Expense: Entries total is matched with transactions total"""
     details = EventFactory.build_details(
-        type=PaymentType.Expense, entry_num=3, transaction_num=5
+        type=EventType.Expense, entry_num=3, transaction_num=5
     )
     validate_total(details)
 
 
 def test_validate_total_expense_multi_currencies():
     """Expense: Multiple currencies are used, validation should be skipped"""
     details = EventFactory.build_details(
-        type=PaymentType.Expense, entry_num=3, transaction_num=5
+        type=EventType.Expense, entry_num=3, transaction_num=5
     )
     details.entries[-1].currency_code += "_INVALID"  # explicitly change currency
     validate_total(details)
@@ -25,7 +25,7 @@ def test_validate_total_expense_multi_currencies():
 def test_validate_total_expense_mismatch():
     """Expense: Entries and transactions totals do not match"""
     details = EventFactory.build_details(
-        type=PaymentType.Expense, entry_num=3, transaction_num=5
+        type=EventType.Expense, entry_num=3, transaction_num=5
     )
     details.transactions[-1].amount += 1
     with pytest.raises(ValueError, match="transactions (.*) not match"):
@@ -35,15 +35,15 @@ def test_validate_total_expense_mismatch():
 def test_validate_total_income():
     """Income: Entries total is matched with transactions total"""
     details = EventFactory.build_details(
-        type=PaymentType.Income, entry_num=3, transaction_num=5
+        type=EventType.Income, entry_num=3, transaction_num=5
     )
     validate_total(details)
 
 
 def test_validate_total_income_multi_currencies():
     """Income: Multiple currencies are used, validation should be skipped"""
     details = EventFactory.build_details(
-        type=PaymentType.Income, entry_num=3, transaction_num=5
+        type=EventType.Income, entry_num=3, transaction_num=5
     )
     details.entries[-1].currency_code += "_INVALID"  # explicitly change currency
     validate_total(details)
@@ -52,7 +52,7 @@ def test_validate_total_income_multi_currencies():
 def test_validate_total_income_mismatch():
     """Income: Entries and transactions totals do not match"""
     details = EventFactory.build_details(
-        type=PaymentType.Income, entry_num=3, transaction_num=5
+        type=EventType.Income, entry_num=3, transaction_num=5
     )
     details.transactions[-1].amount += 1
     with pytest.raises(ValueError, match="transactions (.*) not match"):
@@ -62,14 +62,14 @@ def test_validate_total_income_mismatch():
 def test_validate_total_transfer():
     """Transfer: Validation should be skipped"""
     details = EventFactory.build_details(
-        type=PaymentType.Transfer, entry_num=3, transaction_num=5
+        type=EventType.Transfer, entry_num=3, transaction_num=5
     )
     validate_total(details)
 
 
 def test_validate_total_exchange():
     """Exchange: Validation should be skipped"""
     details = EventFactory.build_details(
-        type=PaymentType.Exchange, entry_num=3, transaction_num=5
+        type=EventType.Exchange, entry_num=3, transaction_num=5
     )
     validate_total(details)