Skip to content

adnl: recent_inbound_peers inserted before signature verification (hardening) #2373

Description

@Perruer

Summary

In adnl/adnl-local-id.cpp:87, recent_inbound_peers.insert(packet.from_short())
executes before signature verification at adnl-peer.cpp:265.

An attacker can fill the 60-slot set with forged from_short() values,
blocking new peers from their source IP for 60 seconds.

Suggested fix

Move insert() to after signature verification, or validate
from_short() against the verified sender identity.

Affected commit

a6298cf

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions