refactor(ui): remove extensionAddress from subscription response and update SubscriptionForm to use parsed value

Author: mois-ilya

apps/demo-dapp-with-react-ui/src/components/SubscriptionForm/SubscriptionForm.tsx

@@ -93,16 +93,21 @@ export function SubscriptionForm() {
 
     const onSend = () => {
         setSubscriptionError(null);
+
         tonConnectUi
             .createSubscription(subscription, { version: 'v2' })
             .then(res => {
+                // TODO: remove this property for release, only for testing purposes
+                // @ts-ignore
+                const extensionAddress = res.extensionAddress as string;
+
                 setSubscriptionRes(res);
                 setSubscriptionError(null);
                 // Auto-fill extensionAddress in cancel form
-                if (res.extensionAddress) {
+                if (extensionAddress) {
                     setCancelPayload(prev => ({
                         ...prev,
-                        extensionAddress: res.extensionAddress as string
+                        extensionAddress: extensionAddress
                     }));
                 }
             })

packages/sdk/src/models/methods/create-subscription-v2/create-subscription-v2-response.ts

@@ -1,11 +1,6 @@
 export interface CreateSubscriptionV2Response {
     /**
-     * Subscription extension address (Bag of Cells)
+     * Subscription message (Bag of Cells)
      */
     boc: string;
-    /**
-     * Parsed extension address for convenience
-     */
-    // TODO: remove this property for release, only for testing purposes
-    extensionAddress?: string;
 }

packages/sdk/src/parsers/create-subscription-v2-parser.ts

@@ -53,12 +53,7 @@ export class CreateSubscriptionV2Parser extends RpcParser<'createSubscriptionV2'
     convertFromRpcResponse(
         rpcResponse: WithoutId<CreateSubscriptionV2RpcResponseSuccess>
     ): CreateSubscriptionV2Response {
-        return {
-            ...rpcResponse.result,
-            // TODO: remove this property for release, only for testing purposes
-            // @ts-ignore
-            extensionAddress: rpcResponse.result.extension_address
-        };
+        return rpcResponse.result;
     }
 }