Allow compiling the gem with MSVC (which is not C99 compliant) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not use Variable-length arrays (VLA) but instead use a heap array with malloc & free * Redefine a macro
|
Benchmarked on linux after changes to see impact of these changes: develop: 0.097458 jaro_winkler (9e1d7a0) 0.097458 0.000000 0.097458 ( 0.097460) Had to remove 22a60aa (which was a commit where I tried to remove the |
|
Hum I guess an alternative is to declare the arrays as fixed size, large enough. |
|
alloca seems to work, but haven't tested on MSVC jaro_winkler (12dc642) 0.108995 0.000000 0.108995 ( 0.108998) |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize this is probably a corner case (using MSVC to compile a ruby gem), but that's he situation I am in: I have to use MSVC to compile this gem as we have a C++ application that has to be built on MSVC and one thing it does is to create a CLI based on ruby and embedded some gems.
The fun stuff is that MSVC (including the 2019 16.5.1 that I use which is fully up to date) isn't C99 compliant, it's C89 compliant. So in order to be able to build the C extension in this repo, I had to do the following changes:
Edit: Well actually, what a coincidence, I see this PR actually fixes an open issue. Fix #41