fix: prevent unnecessary pyo3 build step and fix cargo workspace build (#85)

* Disable default pyo3 features and enable macros

Rename Python binding crate and fix macOS linking

Add macOS linker flag for pyo3 dynamic symbol resolution

* Update pyo3 dependency to version 0.27.2

* Update jingle dependency to version 0.3.6

* Update GitHub workflow to add Python 3.14 support

* Update documented Python support to include 3.14 and drop 3.10

Author: toolCHAINZ

.github/workflows/python.yml

@@ -14,7 +14,7 @@ on:
       - main
   workflow_dispatch:
   release:
-    types: [ published ]
+    types: [published]
 
 permissions:
   contents: read
@@ -38,7 +38,7 @@ jobs:
         uses: PyO3/maturin-action@v1
         with:
           target: ${{ matrix.platform.target }}
-          args: --release --out dist --interpreter python3.10 python3.11 python3.12 python3.13 python3.13t pypy3.10 pypy3.11 --auditwheel skip
+          args: --release --out dist --interpreter python3.11 python3.12 python3.13 python3.14 python3.13t python3.14t --auditwheel skip
           working-directory: crackers_python
           manylinux: manylinux2_28
           before-script-linux: |
@@ -68,7 +68,7 @@ jobs:
         platform:
           - runner: windows-latest
             target: x64
-        python: [ '3.11', '3.12', '3.13' ]
+        python: ["3.11", "3.12", "3.13", "3.14"]
     steps:
       - uses: actions/checkout@v4
         with:
@@ -112,7 +112,7 @@ jobs:
         platform:
           - runner: macos-14
             target: aarch64
-        python: [ '3.11', '3.12', '3.13' ]
+        python: ["3.11", "3.12", "3.13", "3.14"]
     steps:
       - uses: actions/checkout@v4
         with:
@@ -156,7 +156,7 @@ jobs:
     name: Release
     runs-on: ubuntu-latest
     if: ${{ (github.event_name == 'release' && startsWith(github.event.release.tag_name, 'crackers_python')) || github.event_name == 'workflow_dispatch' }}
-    needs: [ linux, macos, sdist ]
+    needs: [linux, macos, sdist]
     permissions:
       # Use to sign the release artifacts
       id-token: write
@@ -169,7 +169,7 @@ jobs:
       - name: Generate artifact attestation
         uses: actions/attest-build-provenance@v2
         with:
-          subject-path: 'wheels-*/*'
+          subject-path: "wheels-*/*"
       - name: Publish to PyPI
         uses: PyO3/maturin-action@v1
         env:

crackers/Cargo.toml

@@ -24,7 +24,7 @@ toml = ["dep:toml_edit"]
 z3-gh-release = ["z3/gh-release"]
 
 [dependencies]
-jingle = { version = "0.3.2", features = ["gimli"] }
+jingle = { version = "0.3.6", features = ["gimli"] }
 z3 = "0.19.0"
 serde = { version = "1.0.203", features = ["derive"] }
 thiserror = "2.0"
@@ -38,4 +38,4 @@ rand = "0.9.2"
 derive_builder = "0.20"
 anyhow = { version = "1.0", optional = true }
 tracing-indicatif = { version = "0.3", optional = true }
-pyo3 = { version = "0", optional = true }
+pyo3 = { version = "0.27.2", optional = true, default-features = false, features = ["macros"] }

crackers_python/Cargo.toml

@@ -6,13 +6,13 @@ edition = "2024"
 description = "pyo3 bindings for crackers"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 [lib]
-name = "crackers"
+name = "crackers_python"
 crate-type = ["cdylib"]
 
 [dependencies]
-pyo3 = { version = "0.26", features = ["extension-module", "py-clone"] }
+pyo3 = { version = "0.27.2", features = ["extension-module", "py-clone"] }
 crackers = {path = "../crackers", features = ["pyo3"], version = "0.6.3" }
-jingle = { version = "0.3.2", features = ["pyo3"]}
+jingle = { version = "0.3.6", features = ["pyo3"]}
 toml_edit = { version = "0.23.4", features = ["serde"] }
 z3 = "0.19.0"
 serde_json = "1.0.140"

crackers_python/PYTHON_README.md

@@ -18,7 +18,7 @@ For more details, please refer to the [GitHub project](https://github.com/toolCH
 
 [![PyPI](https://img.shields.io/pypi/v/crackers)](https://pypi.org/project/crackers/)
 
-The easiest way to use `crackers` is through the [PyPI](https://pypi.org/project/crackers/) package. For every release, we provide wheels for `[MacOS, Windows, Linux] x [3.10, 3.11, 3.12, 3.13]`.
+The easiest way to use `crackers` is through the [PyPI](https://pypi.org/project/crackers/) package. For every release, we provide wheels for `[MacOS, Windows, Linux] x [3.11, 3.12, 3.13, 3.14]`.
 
 A simple usage looks like the following:
 

crackers_python/build.rs

@@ -17,6 +17,19 @@ fn main() {
             std::env::set_var("Z3_PATH", z3_python_lib);
         }
     }
+
+    // For pyo3 extension-modules on macOS, allow undefined symbols to be resolved
+    // dynamically by the Python interpreter at load time. This avoids linker errors
+    // when building a cdylib that depends on the Python C API (pyo3).
+    //
+    // We only add these flags on macOS to avoid affecting other platforms.
+    if cfg!(target_os = "macos") {
+        // Preferred form for passing to the linker; some toolchains accept either
+        // -Wl,-undefined,dynamic_lookup or two separate args. Using -Wl,... is more
+        // explicit and portable across macOS linker invocations.
+        println!("cargo:rustc-link-arg=-Wl,-undefined,dynamic_lookup");
+    }
+
     println!("cargo:rerun-if-changed=build.rs");
     println!("cargo:rerun-if-env-changed=Z3_PATH")
 }