Skip to content

Commit a00f0e2

Browse files
authored
Merge pull request #2 from benjyw/fix_ci
Upgrade Rust, update Python lockfile and fix CI
2 parents 4473d98 + 08a5930 commit a00f0e2

25 files changed

Lines changed: 3563 additions & 2254 deletions

.github/workflows/check-toolchain-token.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
jobs:
55
check-toolchain-token:
66
name: Check Toolchain Token
7-
runs-on: ubuntu-20.04
7+
runs-on: ubuntu-24.04
88
strategy:
99
matrix:
1010
python-version: ["3.9"]

.github/workflows/check-upstream-scripts.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
name: Check for changes in upstream scripts
2-
on:
2+
on:
33
workflow_dispatch: # Allow running on-demand
44
jobs:
55
check-scripts:
66
name: Check for upstream changes to script
7-
runs-on: ubuntu-20.04
7+
runs-on: ubuntu-24.04
88
strategy:
99
matrix:
1010
python-version: ["3.9"]
@@ -25,5 +25,5 @@ jobs:
2525
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
2626
SLACK_COLOR: yellow
2727
SLACK_TITLE: Out of date script
28-
SLACK_MESSAGE: "A local in repo script is out of date compared to an upstream script., See log for details: https://github.com/toolchainlabs/toolchain/actions/workflows/check-upstream-scripts.yml"
28+
SLACK_MESSAGE: "A local in repo script is out of date compared to an upstream script., See log for details: https://github.com/toolchainlabs/toolchain-oss/actions/workflows/check-upstream-scripts.yml"
2929
SLACK_CHANNEL: "devops"

.github/workflows/node-js-ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: Node JS CI
2-
on:
2+
on:
33
push:
44
branches:
55
- master
@@ -9,9 +9,9 @@ concurrency:
99
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
1010
cancel-in-progress: true
1111
jobs:
12-
check_for_changes:
12+
check_for_changes:
1313
name: Check JS Changes
14-
runs-on: ubuntu-latest
14+
runs-on: ubuntu-24.04
1515
outputs:
1616
js_changes: ${{ steps.changed-files.outputs.any_modified }}
1717
steps:
@@ -29,7 +29,7 @@ jobs:
2929
.github/**
3030
nodes_js_ci:
3131
name: Node/JS CI
32-
runs-on: ubuntu-20.04
32+
runs-on: ubuntu-24.04
3333
needs: check_for_changes
3434
timeout-minutes: 20
3535
steps:
@@ -106,7 +106,7 @@ jobs:
106106
run: yarn build
107107
cypress-run:
108108
name: Cypress tests
109-
runs-on: ubuntu-latest
109+
runs-on: ubuntu-24.04
110110
needs: check_for_changes
111111
if: needs.check_for_changes.outputs.js_changes == 'true'
112112
steps:
@@ -117,7 +117,7 @@ jobs:
117117
with:
118118
cache: 'yarn'
119119
cache-dependency-path: src/node/yarn.lock
120-
node-version-file: 'src/node/toolchain/pants-demo-site/.nvmrc'
120+
node-version-file: 'src/node/toolchain/pants-demo-site/.nvmrc'
121121
# Install NPM dependencies, cache them correctly
122122
# and run all Cypress tests
123123
- name: Cypress run
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
name: Audit reqs
2-
on:
2+
on:
33
workflow_dispatch: # Allow running on-demand
44
jobs:
55
audit-python:
66
name: Audit python packages
7-
runs-on: ubuntu-20.04
7+
runs-on: ubuntu-24.04
88
strategy:
99
matrix:
1010
python-version: ["3.9"]
11-
os: [ubuntu-latest]
11+
os: [ubuntu-24.04]
1212
steps:
1313
- uses: actions/checkout@v3
1414
with:
@@ -40,5 +40,5 @@ jobs:
4040
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
4141
SLACK_COLOR: red
4242
SLACK_TITLE: Python Packages Security Audit FAILED.
43-
SLACK_MESSAGE: "There is a security vulnerability in one of the python packages used by Toolchain, See log for details: https://github.com/toolchainlabs/toolchain/actions/workflows/pacakges-audit.yml"
43+
SLACK_MESSAGE: "There is a security vulnerability in one of the python packages used by Toolchain, See log for details: https://github.com/toolchainlabs/toolchain-oss/actions/workflows/packages-audit.yml"
4444
SLACK_CHANNEL: "devops"

.github/workflows/rust-ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: Rust CI
2-
on:
2+
on:
33
push:
44
branches:
55
- master
@@ -9,7 +9,7 @@ concurrency:
99
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
1010
cancel-in-progress: true
1111
jobs:
12-
check_for_changes:
12+
check_for_changes:
1313
name: Check Rust Changes
1414
runs-on: ubuntu-latest
1515
outputs:
@@ -44,7 +44,7 @@ jobs:
4444
- uses: actions-rs/toolchain@v1.0.7
4545
if: needs.check_for_changes.outputs.rust_changes == 'true'
4646
with:
47-
toolchain: 1.68.0
47+
toolchain: 1.93.0
4848
- name: Install Protoc
4949
uses: arduino/setup-protoc@64c0c85d18e984422218383b81c52f8b077404d3
5050
if: needs.check_for_changes.outputs.rust_changes == 'true'

0 commit comments

Comments
 (0)