Add support for Google Talkback assistance in Magisk app

[arnowelzel]

Magisk is a really nice tool - but unfortunately blind users can't use Magisk Manager fully since some of the UI elements don't provide textual hints for Google Talkback assistance.

For example: in Magisk Hide there is a list with checkboxes next to the app names - these checkboxes will only be announced as "unnamed control" and without and indication if the checkbox is checked, unchecked or partially checked. In addition there is at least one control which is not accessible at all: the "arrow" button which expands or collapses an app group in the Magisk Hide app list.

UI elements can provide a textual description for voice assistance in the android:contentDescription property (see https://github.com/arnowelzel/periodical/blob/master/app/src/main/res/layout/main.xml as an example) or by setting the description with setContentDescription() (see https://github.com/arnowelzel/periodical/blob/master/app/src/main/java/de/arnowelzel/android/periodical/CalendarCell.java as an example).

[diareuse]

Are you speaking on behalf of blind users, respectively is there somebody blind who goes ahead and roots their phone?

I deliberately ignored this since I'm not aware that you can flash or debug something when you don't actually see it. If there is someone, who likes to make their life a little bit harder like this, kudos to you.

I'd like to see whether you know someone who has this issue, if so I'll kindly add support for that. Otherwise it's a waste of time, honestly.

[arnowelzel]

I speak on behalf of my blind friend and others who use LineageOS with Magisk and Titanium Backup on his phones and wants to be able to configure Magisk Hide without assistance of another person with vision - and this would be possible, if Magisk Manager would provide a content description for the controls and avoids element which can not be recognized as UI element by Google Talkback. That's all which is needed, nothing else.

Even TWRP can be used via ADB on the command line - so no need to see anything on the display to install a new ROM. The same applies to Titanium Backup which can be operated using Google Talkback and many other things which can be done using ADB or SSH. My friend not only exchanges e-mails and messages, he also uses a webbrowser, a banking app to check his accounts and software like Öffi to get around in the public transport system. Yes, this is all possible as well if you are blind - but of course it needs a little support by the software which has to provide textual descriptions for all UI elements.

Even unlocking a bootloader and installing TWRP is possible for a blind user, although having a friend with vision nearby is helpful in case anything goes wrong and you need to check if there are error messages.

And to be honest as well: supporting assistive technologies is never "waste of time" just because one can't imagine a use case for it. Especially if this can be done so easy by adding a content description. There is only one UI element which might need a bit more work since it is not recognized by Google Talkback yet. Also keep in mind that people who would need assistance will often not ask for this - they will just not use the software if it doesn't support Google Talkback.

If you are interested I can also work on this and provide a pull request - I'm just quite busy with other projects at the moment, so it may take a couple of weeks.

Edit: and yes, blind people turn off the display (there is a setting for this in Google Talkback) and use headphones for the voice asisstance when using their Smartphone to protect their privacy.

[xDragonZ]

Its year 2020 and still have people use Titanium Backup?

[arnowelzel]

@xDragonZ I'm open for alternatives - what would you recommend? The requirements are to be able to backup all apps and data locally to a SD card and restore app and/or data of a single app if needed.

Edit: and app freezing would also be nice.

[diareuse]

No pull request is needed. The redesign is in review process and so this change would be worthless at this time.

I'll add support for the Talkback myself at later time.

Closing comments since the discussion is already off-topic.

[Fox2Code]

TBH I found blind user asking me on Telegram to improve Talkback support on an app made for Magisk specifically.

Some blind users are really determined, I was really shocked about that.
If someone blind successfully root their phone with Magisk, I just have respect for that.