Bootloop - Samsung S9

[alexcheveau]

Device: Samsung S9 (G9600)
Android version: 10
Magisk version name: v26.1 (debug)
Magisk version code: ee34f77 (26105)

Followed exactly all the steps in https://topjohnwu.github.io/Magisk/install.html#samsung-devices
After flashing the patched AP I got bootloop.

magisk_install_log_2023-08-24T15.06.10.log
mounts.txt
last_kmsg.txt

[salvogiangri]

By looking at the kernel logs seems like the kernel panic is caused by RKP blocking magiskinit (https://github.com/droidian-starqlte/android_kernel_samsung_sdm845/blob/8fde28b4cdfb0c1ed2501c559cb7e593879a978d/fs/exec.c#L1355), I also noticed in the install logs I can't see the RKP disable patch being applied in the kernel image:

Magisk/scripts/boot_patch.sh

Lines 223 to 227 in 0c28a91

	# Remove Samsung RKP
	./magiskboot hexpatch kernel \
	49010054011440B93FA00F71E9000054010840B93FA00F7189000054001840B91FA00F7188010054 \
	A1020054011440B93FA00F7140020054010840B93FA00F71E0010054001840B91FA00F7181010054 \
	&& PATCHEDKERNEL=true

[alexcheveau]

Retried all steps with the new version (26.2 - debug) same result: bootloop
last_kmsg.txt
magisk_install_log_2023-08-28T11.17.06.log

[osm0sis]

Is there a newer version of RKP that needs to be patched out then? Is there source available for this device? Clearly the old patch doesn't work for it.

[alexcheveau]

I don't think it's a new version because this device don't receive new updates anymore, only security patches.
The version that I'm running is https://samfrew.com/download/Galaxy__S9__/rcut/MXO/G9600ZHU9FWC3/G9600OWO9FVF2

[osm0sis]

Fact is the existing RKP patch didn't find a match in your kernel. Is there source for this device kernel?

[alexcheveau]

Fact is the existing RKP patch didn't find a match in your kernel. Is there source for this device kernel?

I think it's this: https://github.com/droidian-devices/linux-android-samsung-starqlte

[osm0sis]

Alright well if you're lucky someone might be able to use that to figure out how to patch it to properly disable RKP on it.

[salvogiangri]

Is there a newer version of RKP that needs to be patched out then? Is there source available for this device? Clearly the old patch doesn't work for it.

Not surprising at all considering this patch is pretty old, iirc it's from Chainfire's SuperSU.

[salvogiangri]

I found more info in issue #3485: #3485 (comment)
The patch might've been broken since quite a few time and didn't cause any issue on recent devices.

[TurfJakkals]

Having the same problem on S9+
Android 12
NOBLEROM2.9F-4.191

Whilst in a bootloop, accessing TWRP -> Advance -> Fix Context and reboot, solves bootloop temporarily. When trying to upgrade Magisk in-app, after reboot, bootloops again.

Zygisk is disabled.

[pndwal]

Having the same problem on S9+ Android 12 NOBLEROM2.9F-4.191

This may or may not account for the whole issue (I haven't diagnosed this properly) but I just saw your screenshot...

However the erroneous detection issue you seem to have did begin with 26105 build OP here is using...

With Ramdisk = No, clearly this is another older legacy ramdisk boot-type ('type I') device being wrongly detected as a legacy SAR 'type III' device...

Further, as the Recovery Mode check box is erroneously appearing in these cases (it's only for A-only devices launched with Android 9 as these 2018, 2019 devices were the only type III devices made) and is checked by default, users are generally leaving it checked (as they don't know better) and Magisk is then patching ramdisk in /recovery partition when taking Direct Install, and recovery.img in Samsung AP binaries when patching these...

Taking Reboot will also cause many devices to boot via recovery (as it's trying to boot system with magiskinit in recovery ramdisk) where Recovery Mode is left checked...

If you/others here tried updating, you likely have both Magisk-patched boot.img and recovery.img now...

This issue should already be fixed with:
Fix device detection scripts and logic
and
Always check mounts to detect legacy SAR on bootmode
in 26202 (Canary), but you should patch and flash fresh stock AP binary to replace recovery.img erroneously patched...

Any who have used 26105 - 26201 builds and had this issue should start fresh with AP binary or restore stock recovery.img to correct erroneous patching before installing 26202+

Hope this helps. 🙂

[osm0sis]

Just in case, try 26203?

[TurfJakkals]

Simply unchecking the Recovery Mode whilst repeating the update in-app solved the problem. Thank you for the help! 🤘🏻