Combination of Magisk pre-installed as part of ROM and locked bootloader ( good representative of this type of thing https://github.com/schnatterer/rooted-graphene ) work well and offer benefits of both magisk and locked bootloader, but there is a minor UI "situation" that can potentially cause a soft-brick
Basically, the UI presents the user with option to install/update magisk via standard means in the UI
In a situation where magisk updates are actually shipped with the signed ROM updates (because it is integrated) and the bootloader is locked a user mistakenly initiating update via "standard normal magisk rooted way" could cause a soft-brick due to bootloader being locked and the signature no longer working out
The feature to prevent that would basically have the app check if it is running on a bootloader-locked system (should be very doable on a rooted system) and hiding the "install/update" buttons if it indeed is.
I understand "rooted signed bootloader locked ROMs" are kinda niche but it is a good magisk usecase and slightly more friendliness towards them would be very appreciated
Device: Any (obviously demonstrated on Pixels)
Android version: Any (demonstrated on Rooted Graphene)
Magisk version name: 30.7
Magisk version code: 30700
Combination of Magisk pre-installed as part of ROM and locked bootloader ( good representative of this type of thing https://github.com/schnatterer/rooted-graphene ) work well and offer benefits of both magisk and locked bootloader, but there is a minor UI "situation" that can potentially cause a soft-brick
Basically, the UI presents the user with option to install/update magisk via standard means in the UI
In a situation where magisk updates are actually shipped with the signed ROM updates (because it is integrated) and the bootloader is locked a user mistakenly initiating update via "standard normal magisk rooted way" could cause a soft-brick due to bootloader being locked and the signature no longer working out
The feature to prevent that would basically have the app check if it is running on a bootloader-locked system (should be very doable on a rooted system) and hiding the "install/update" buttons if it indeed is.
I understand "rooted signed bootloader locked ROMs" are kinda niche but it is a good magisk usecase and slightly more friendliness towards them would be very appreciated
Device: Any (obviously demonstrated on Pixels)
Android version: Any (demonstrated on Rooted Graphene)
Magisk version name: 30.7
Magisk version code: 30700