Skip to content

Commit ebf0cf9

Browse files
authored
[PF] Rubocop offenses are corrected, CHANGELOG entries are added (#1017)
* CHANGELOG entries for #916 and #1008 are added Adds the #scroll_batches error-raising entry (#916), moves the GitHub Actions service entry (#1008) into chronological order, and registers @tomdev as a contributor. * Layout/TrailingWhitespace offense is corrected
1 parent 70de104 commit ebf0cf9

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@
44

55
### Changes
66

7+
* [#916](https://github.com/toptal/chewy/pull/916): Raise error in #scroll_batches when search backend returns a failure. ([@tomdev][])
8+
* [#1008](https://github.com/toptal/chewy/pull/1008): Promote Elasticsearch to a native GitHub Actions service with a health-check gate, replacing the fragile `docker compose` + `sleep 15` approach. ([@mattmenefee][])
79
* [#1010](https://github.com/toptal/chewy/pull/1010): Add Chewy 7/ES 7 to Chewy 8/ES 8 migration guide and fix stale `Elasticsearch::Transport` namespace references in docs. ([@mattmenefee][])
810
* [#1011](https://github.com/toptal/chewy/pull/1011): Replace deprecated `Sidekiq::Testing` API with new `Sidekiq 8.1+` testing API and silence Sidekiq logger during spec runs. ([@mattmenefee][], [@mjankowski][])
911
* [#1013](https://github.com/toptal/chewy/pull/1013): Fix `drop_indices` test helper to use `format: 'json'` for ES version portability. If you define a custom `drop_indices` helper in your test suite, update it to use `Chewy.client.cat.indices(format: 'json')` instead of parsing the text-format response. ([@mattmenefee][])
1012
* [#1014](https://github.com/toptal/chewy/pull/1014): Improve contributing documentation with development setup instructions, PR workflow, and grammar fixes. ([@mattmenefee][])
11-
* [#1008](https://github.com/toptal/chewy/pull/1008): Promote Elasticsearch to a native GitHub Actions service with a health-check gate, replacing the fragile `docker compose` + `sleep 15` approach. ([@mattmenefee][])
1213

1314
## 8.0.1 (2026-03-12)
1415

@@ -913,6 +914,7 @@
913914
[@socialchorus]: https://github.com/socialchorus
914915
[@taylor-au]: https://github.com/taylor-au
915916
[@TikiTDO]: https://github.com/TikiTDO
917+
[@tomdev]: https://github.com/tomdev
916918
[@undr]: https://github.com/undr
917919
[@Vitalina-Vakulchyk]: https://github.com/Vitalina-Vakulchyk
918920
[@webgago]: https://github.com/webgago

lib/chewy/errors.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def initialize(join_field_type, join_field_name, relations)
3939

4040
class MissingHitsInScrollError < Error
4141
end
42-
42+
4343
class ImportScopeCleanupError < Error
4444
end
4545

lib/chewy/search/scrolling.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def scroll_batches(batch_size: Request::DEFAULT_BATCH_SIZE, scroll: Request::DEF
4747

4848
yield(hits) if hits.present?
4949
scroll_id = result['_scroll_id']
50-
50+
5151
break if result['terminated_early']
5252

5353
result = perform_scroll(scroll: scroll, scroll_id: scroll_id) unless last_run

0 commit comments

Comments
 (0)