Do not maximize app window on first startup (or settings cleared)

Ref #684
Closes #801

Author: palexdev

pdfsam-gui/src/main/java/org/pdfsam/gui/WindowStatusController.java

@@ -66,11 +66,17 @@ && hasAvailableScreen(latestStatus)) {
         }
     }
 
+    /**
+     * Sets the app's window position and size on the primary screen to sensible defaults.
+     */
     private void defaultStageStatus() {
-        Rectangle2D primScreenBounds = Screen.getPrimary().getVisualBounds();
-        stage.setX((primScreenBounds.getWidth() - stage.getWidth()) / 2);
-        stage.setY((primScreenBounds.getHeight() - stage.getHeight()) / 4);
-        stage.setMaximized(true);
+        Rectangle2D primaryBounds = Screen.getPrimary().getVisualBounds();
+        int w = (int) (primaryBounds.getWidth() * 0.6);
+        int h = (int) (primaryBounds.getHeight() * 0.8);
+        stage.setX(primaryBounds.getMinX() + (primaryBounds.getWidth() - w) / 2);
+        stage.setY(primaryBounds.getMinY() + (primaryBounds.getHeight() - h) / 2);
+        stage.setWidth(w);
+        stage.setHeight(h);
     }
 
     private void restore(StageStatus latestStatus) {

pdfsam-gui/src/test/java/org/pdfsam/gui/WindowStatusControllerTest.java

@@ -35,7 +35,8 @@
 import org.testfx.framework.junit5.Start;
 import org.testfx.framework.junit5.Stop;
 
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
@@ -71,19 +72,25 @@ public void stop(){
     }
 
     @Test
-    public void defaultOnNullStatus() {
-        when(service.getLatestStatus()).thenReturn(StageStatus.NULL);
+    @SetSystemProperty(key = ConfigurableSystemProperty.PDFSAM_DISABLE_UI_RESTORE, value = "true")
+    public void defaultOnDisableRestore() {
+        when(service.getLatestStatus()).thenReturn(new StageStatus(10, 10, 10, 10));
         victim.setStage(victimStage);
         robot.clickOn("show").sleep(200);
-        assertTrue(victimStage.isMaximized());
+        assertNotEquals(10, victimStage.getX());
+        assertNotEquals(10, victimStage.getY());
+        assertNotEquals(10, victimStage.getWidth());
+        assertNotEquals(10, victimStage.getHeight());
     }
 
     @Test
-    @SetSystemProperty(key = ConfigurableSystemProperty.PDFSAM_DISABLE_UI_RESTORE, value = "true")
-    public void defaultOnDisableRestore() {
+    void restoreLastStatus() {
         when(service.getLatestStatus()).thenReturn(new StageStatus(10, 10, 10, 10));
         victim.setStage(victimStage);
         robot.clickOn("show").sleep(200);
-        assertTrue(victimStage.isMaximized());
+        assertEquals(10, victimStage.getX());
+        assertEquals(10, victimStage.getY());
+        assertEquals(10, victimStage.getWidth());
+        assertEquals(10, victimStage.getHeight());
     }
 }