Rename build-result-notifier to build-state-notifier

Author: toricls

sam.yml

@@ -118,13 +118,13 @@ Resources:
                   - "logs:CreateLogStream"
                   - "logs:PutLogEvents"
                 Resource: "arn:aws:logs:*:*:*"
-  BuildResultNotifier:
+  BuildStateNotifier:
     Type: "AWS::Serverless::Function"
     Properties:
       Role: !GetAtt LambdaExecutionRole.Arn
       Handler: index.handler
       Runtime: nodejs6.10
-      CodeUri: ./src/functions/build-result-notifier
+      CodeUri: ./src/functions/build-state-notifier
       Timeout: 10
       MemorySize: 128
       Environment:

src/functions/build-result-notifier/.yarnclean renamed to src/functions/build-state-notifier/.yarnclean

@@ -12,19 +12,21 @@ github.authenticate({type:'oauth', token: process.env.GITHUB_TOKEN})
 exports.handler = (event, context, callback) => {
     context.callbackWaitsForEmptyEventLoop = false
     //console.log('Received event:', JSON.stringify(event, null, 2))
-    console.log(`Build status: ${event.buildStatus}, Commit hash: ${event.sourceVersion}`)
+    const sha = event.detail['additional-information']['source-version']
+    const buildId = event.detail['build-id'].split('build/')[1]
+    console.log(`Build status: ${event.detail['build-status']}, Commit hash: ${sha}`)
 
-    const status = codeBuildStatusToGitHubStatus(event.buildStatus)
+    const status = codeBuildStatusToGitHubStatus(event.detail['build-status'])
     if (status.state === '') {
         callback(status.errorMessage)
     }
 
     github.repos.createStatus({
         owner: repo.owner,
         repo: repo.name,
-        sha: event.sourceVersion,
+        sha: sha,
         state: status.state,
-        target_url: `https://${region}.console.aws.amazon.com/codebuild/home?region=${region}#/builds/${event.id}/view/new`,
+        target_url: `https://${region}.console.aws.amazon.com/codebuild/home?region=${region}#/builds/${buildId}/view/new`,
         context: 'codebuild',
         description: status.msg
     }).then((data) => {

src/functions/build-result-notifier/index.js renamed to src/functions/build-state-notifier/index.js

@@ -21,10 +21,10 @@ exports.codeBuildStatusToGitHubStatus = (codeBuildStatus) => {
     case 'STOPPED':
     case 'TIMED_OUT':
         state = 'error'
-        msg = 'Something wrong happened on AWS CodeBuild'
+        msg = `Something wrong happened on AWS CodeBuild: ${codeBuildStatus}`
         break
     default:
-        errMsg = `Unknown CodeBuilg buildStatus: ${codeBuildStatus}`
+        errMsg = `Unknown CodeBuild buildStatus: ${codeBuildStatus}`
         console.log(errMsg)
     }
     return {

src/functions/build-result-notifier/lib/codebuild-status-to-github-status.js renamed to src/functions/build-state-notifier/lib/codebuild-status-to-github-status.js

@@ -4,8 +4,8 @@ let assert = require('assert')
 
 let codeBuildStatusToGitHubStatus = require('./codebuild-status-to-github-status').codeBuildStatusToGitHubStatus
 
-describe('should-ignore', () => {
-    describe('shouldIgnore', () => {
+describe('codebuild-status-to-github-status', () => {
+    describe('shouldReturn', () => {
         it('should return success status if CodeBuild has done without any problem', () => {
             var result = codeBuildStatusToGitHubStatus('SUCCEEDED')
             assert.equal('success', result.state)
@@ -34,7 +34,7 @@ describe('should-ignore', () => {
             var result = codeBuildStatusToGitHubStatus('UNKNOWN_VALUE')
             assert.equal('', result.state)
             assert.equal('', result.message)
-            assert.equal('Unknown CodeBuilg buildStatus: UNKNOWN_VALUE', result.errorMessage)
+            assert.equal('Unknown CodeBuild buildStatus: UNKNOWN_VALUE', result.errorMessage)
         })
     })
 })