Commit e62ccbf
committed
Fix GeometryField value conversion crashing on non-None values
GeometryField subclasses Field directly (single base), so the _FieldMeta
metaclass — which only auto-assigns field_type when there are multiple
bases — leaves field_type as None. The base to_python_value/to_db_value
converters then call isinstance(value, self.field_type), raising
TypeError: isinstance() arg 2 must be a type ... on any non-None value.
Declare field_type = str and parametrize as Field[str], mirroring the
fix applied to TSVectorField in #2237.1 parent 8c12adc commit e62ccbf
2 files changed
Lines changed: 28 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
0 commit comments