chore: complete v3.2 milestone

claude · claude · commit 76ff3f2a2fde · 2026-03-17T12:42:28.000+01:00
diff --git a/.planning/MILESTONES.md b/.planning/MILESTONES.md
@@ -1,5 +1,33 @@
 # Milestones: Lumio
 
+## v3.2 Deck Management UX (Shipped: 2026-03-17)
+
+**Delivered:** Improved shared deck management UX in the Android app — Discovery promoted to 2nd tab, platform repo hidden, swipe-to-unsubscribe with atomic data cleanup, and full card browsing for shared decks.
+
+**Phases completed:** 45-46 (3 plans, 6 tasks)
+
+**Key accomplishments:**
+
+- Discovery tab promoted to 2nd nav position (Dashboard → Discovery → Repos → Settings)
+- Platform repo lumio-decks hidden from repo list, stats, and manual add with info toast
+- Atomic unsubscribe_deck SECURITY DEFINER RPC (deletes card_review_schedule + user_repositories in one transaction)
+- SharedDeckListItem with swipe-to-unsubscribe, confirmation dialog, and success toast
+- Unified FlatList with discriminated union (kind: 'deck' | 'repo') merging shared decks and personal repos
+- Subfolder-aware card list filtering and CardDetail navigation for shared decks
+
+**Stats:**
+
+- 25 files changed (+2,276 / -128 lines)
+- 2 phases, 3 plans, 6 tasks
+- 1 day (2026-03-17)
+- UAT: 6/6 tests passed
+
+**Git range:** `b6e237e` → `24b5982` (4 feat commits)
+
+**What's next:** TBD
+
+---
+
 ## v3.1 Deck Discovery (Shipped: 2026-03-16)
 
 **Delivered:** End-to-end deck discovery pipeline — from deck.yaml metadata authoring in the deck builder, through Docora webhook indexing into a fulltext-searchable deck_index table, to a Discovery tab in the Android app where users search, browse by tag, and subscribe to shared decks with a single tap.
diff --git a/.planning/PROJECT.md b/.planning/PROJECT.md
@@ -111,18 +111,16 @@ Gli utenti studiano concetti tramite quiz generati dall'AI — il contenuto vien
 - ✓ Discovery tab (4° tab, icona bussola) con ricerca fulltext, chip tag, subscribe/unsubscribe ottimistico — v3.1
 - ✓ Deck condivisi visibili nella schermata Repos con display_name arricchito da deck_index — v3.1
 - ✓ i18n completa Discovery IT/EN (17 chiavi per lingua) — v3.1
+- ✓ Tab Discovery promosso a 2° posizione nav (Dashboard → Discovery → Repos → Settings) — v3.2
+- ✓ Repo piattaforma lumio-decks nascosto da lista repo, stats, e add manuale con info toast — v3.2
+- ✓ Unsubscribe atomico da mazzo condiviso via SECURITY DEFINER RPC (card_review_schedule + user_repositories) — v3.2
+- ✓ Swipe-to-unsubscribe su mazzi condivisi con dialog conferma e toast — v3.2
+- ✓ Lista unificata FlatList con discriminated union (deck | repo) per repos e mazzi condivisi — v3.2
+- ✓ Filtro carte per subfolder e navigazione CardDetail per mazzi condivisi — v3.2
 
 ### Active
 
-**Current Milestone: v3.2 Deck Management UX**
-
-**Goal:** Migliorare la gestione dei mazzi condivisi nell'app Android — riordino tab, nascondi repo piattaforma, e parità funzionale (swipe unsubscribe, tap → carte) con i repo normali.
-
-**Target features:**
-- Riordino tab bottom: Discovery prima di Repository
-- Nascondi repo condiviso lumio-decks dalla lista repository
-- Swipe a sinistra su mazzi condivisi per disiscriversi (con cancellazione dati studio)
-- Tap su mazzi condivisi per navigare a lista carte → dettaglio carta
+(No active milestone — start next with `/gsd:new-milestone`)
 
 ### Out of Scope
 
@@ -160,7 +158,7 @@ Gli utenti studiano concetti tramite quiz generati dall'AI — il contenuto vien
 
 ## Context
 
-**Stato attuale (post v3.1):**
+**Stato attuale (post v3.2):**
 - Monorepo pnpm: apps/android (Expo/React Native), apps/deck-builder (Vite/React SPA), apps/landing (static HTML), packages/core, packages/shared
 - Backend Supabase: auth (Google OAuth + email/password), DB, storage, edge functions (deck-commit con 9 azioni GitHub API + docora-webhook con deck.yaml indexing), Docora webhook + study_sessions + card_review_schedule + deck_index tables
 - Tech stack Android: Expo SDK 54, React Native 0.81, react-navigation, @lumio/core, i18n-js, react-native-marked, supermemo@2.0.23
@@ -172,7 +170,7 @@ Gli utenti studiano concetti tramite quiz generati dall'AI — il contenuto vien
 - Deck builder web bilingue IT/EN con dark mode, deck CRUD, card authoring con markdown editor, live preview, toolbar, metadata form (deck.yaml)
 - Discovery pipeline: deck.yaml → Docora webhook → deck_index (tsvector/GIN) → search_decks RPC → Discovery screen
 - ~56,900 LOC (TS/TSX/CSS/SQL) — ~28,300 Android + ~28,600 deck-builder
-- 13 milestones shipped: v1.1 → v3.1
+- 14 milestones shipped: v1.1 → v3.2
 
 ## Constraints
 
@@ -282,6 +280,12 @@ Gli utenti studiano concetti tramite quiz generati dall'AI — il contenuto vien
 | 409 conflict as success in subscribeToDeck | Idempotent double-tap handling without error UI | ✓ Good — v3.1 |
 | Optimistic UI with Set rollback for subscribe | Immediate visual feedback, revert on error | ✓ Good — v3.1 |
 | Collapsible metadata form (collapsed by default) | Non-intrusive for quick deck browsing, expand when needed | ✓ Good — v3.1 |
+| Post-query array filter for is_platform exclusion | Simpler than nested Supabase filter syntax | ✓ Good — v3.2 |
+| Sentinel error string PLATFORM_REPO for client detection | Clean client-side routing to info toast vs error toast | ✓ Good — v3.2 |
+| SECURITY DEFINER RPC for atomic unsubscribe | Deletes card_review_schedule + user_repositories in single transaction | ✓ Good — v3.2 |
+| Discriminated union (kind: 'deck' \| 'repo') for FlatList | Type-safe rendering of mixed shared decks and personal repos | ✓ Good — v3.2 |
+| Skip .lumioignore when subfolderPath is set | Shared decks don't have per-user .lumioignore | ✓ Good — v3.2 |
+| Fallback Repository object for shared deck CardDetail | Enables CardDetail navigation without repo in user's personal collection | ✓ Good — v3.2 |
 
 ---
-*Last updated: 2026-03-16 after v3.1 milestone*
+*Last updated: 2026-03-17 after v3.2 milestone*
diff --git a/.planning/ROADMAP.md b/.planning/ROADMAP.md
@@ -15,7 +15,7 @@
 - ✅ **v2.3 Dashboard Polish** — Phases 34-35 (shipped 2026-03-05)
 - ✅ **v3.0 Deck Builder Web** — Phases 36-40 (shipped 2026-03-13)
 - ✅ **v3.1 Deck Discovery** — Phases 41-44 (shipped 2026-03-16)
-- 🚧 **v3.2 Deck Management UX** — Phases 45-46 (in progress)
+- ✅ **v3.2 Deck Management UX** — Phases 45-46 (shipped 2026-03-17)
 
 ## Phases
 
@@ -167,48 +167,18 @@ Full details: `.planning/milestones/v3.1-ROADMAP.md`
 
 </details>
 
-### v3.2 Deck Management UX (In Progress)
-
-**Milestone Goal:** Migliorare la gestione dei mazzi condivisi nell'app Android -- riordino tab, nascondi repo piattaforma, e parita funzionale (swipe unsubscribe, tap per carte) con i repo normali.
-
-- [x] **Phase 45: Navigation & Display Cleanup** - Tab reorder e filtro repo piattaforma (completed 2026-03-17)
-- [x] **Phase 46: Shared Deck Interaction** - Swipe unsubscribe e card browsing per mazzi condivisi (completed 2026-03-17)
-
-## Phase Details
-
-### Phase 45: Navigation & Display Cleanup
-**Goal**: Users see a cleaner, more logical navigation layout with Discovery promoted and platform internals hidden
-**Depends on**: Phase 44
-**Requirements**: NAV-01, REPO-01
-**Success Criteria** (what must be TRUE):
-  1. The Discovery tab appears as the 2nd tab (after Dashboard, before Repository) in the bottom navigation bar
-  2. The lumio-decks shared repository does not appear in the Repository list -- only user-subscribed deck entries and personal repos are visible
-  3. Tab order is consistent across all app screens (no stale order on navigation)
-**Plans**: 1 plan
+<details>
+<summary>✅ v3.2 Deck Management UX (Phases 45-46) — SHIPPED 2026-03-17</summary>
 
-Plans:
-- [ ] 45-01-PLAN.md — Tab reorder, platform repo filter, and add-repo guard
+- [x] Phase 45: Navigation & Display Cleanup (1 plan) — completed 2026-03-17
+- [x] Phase 46: Shared Deck Interaction (2 plans) — completed 2026-03-17
 
-### Phase 46: Shared Deck Interaction
-**Goal**: Users can manage and browse shared decks with the same interactions available for personal repositories
-**Depends on**: Phase 45
-**Requirements**: DECK-01, DECK-02, DECK-03
-**Success Criteria** (what must be TRUE):
-  1. User can swipe left on a shared deck entry in the Repository screen to reveal an unsubscribe action
-  2. Unsubscribing from a shared deck removes the subscription and associated study data (card_review_schedule entries)
-  3. User can tap a shared deck entry to see a list of cards filtered by the deck's subfolder path
-  4. User can tap a card in the shared deck card list to view full card detail with markdown, code highlighting, LaTeX, and images
-**Plans**: 2 plans
+Full details: `.planning/milestones/v3.2-ROADMAP.md`
 
-Plans:
-- [ ] 46-01-PLAN.md — Backend RPC, client function, route params, and i18n keys
-- [ ] 46-02-PLAN.md — SharedDeckListItem component, unified list, swipe unsubscribe, card browsing
+</details>
 
 ## Progress
 
-**Execution Order:**
-Phases execute in numeric order: 45 -> 46
-
 | Phase | Milestone | Plans Complete | Status | Completed |
 |-------|-----------|----------------|--------|-----------|
 | 1-5. Foundation to Cleanup | v1.1 | 20/20 | Complete | 2026-02-08 |
@@ -224,9 +194,8 @@ Phases execute in numeric order: 45 -> 46
 | 34-35. Dashboard Polish | v2.3 | 2/2 | Complete | 2026-03-05 |
 | 36-40. Deck Builder Web | v3.0 | 10/10 | Complete | 2026-03-13 |
 | 41-44. Deck Discovery | v3.1 | 8/8 | Complete | 2026-03-16 |
-| 45. Navigation & Display Cleanup | 1/1 | Complete    | 2026-03-17 | - |
-| 46. Shared Deck Interaction | 2/2 | Complete    | 2026-03-17 | - |
+| 45-46. Deck Management UX | v3.2 | 3/3 | Complete | 2026-03-17 |
 
 ---
 *Roadmap created: 2026-01-29*
-*Last updated: 2026-03-17 -- Phase 46 planned (2 plans)*
+*Last updated: 2026-03-17 — v3.2 Deck Management UX shipped*
diff --git a/.planning/STATE.md b/.planning/STATE.md
@@ -4,7 +4,7 @@ milestone: v3.2
 milestone_name: Deck Management UX
 status: completed
 stopped_at: Completed 46-02-PLAN.md (Phase 46 complete)
-last_updated: "2026-03-17T09:58:05.180Z"
+last_updated: "2026-03-17T11:38:31.689Z"
 last_activity: 2026-03-17 — Completed 46-02 (Shared Deck UI)
 progress:
   total_phases: 2
@@ -18,10 +18,10 @@ progress:
 
 ## Project Reference
 
-See: .planning/PROJECT.md (updated 2026-03-16)
+See: .planning/PROJECT.md (updated 2026-03-17)
 
 **Core value:** Gli utenti studiano concetti tramite quiz generati dall'AI -- il contenuto viene dai repository Git, le domande vengono generate e pre-cachate dal sistema.
-**Current focus:** Phase 46 - Shared Deck Interaction
+**Current focus:** Planning next milestone
 
 ## Current Position
 
@@ -35,9 +35,9 @@ Progress: [██████████] 100%
 ## Performance Metrics
 
 **Velocity:**
-- Total plans completed: 88 (70 across v1.1-v2.3 + 10 in v3.0 + 8 in v3.1)
-- Total milestones shipped: 13 (v1.1 through v3.1)
-- Timeline: 47 days (2026-01-29 to 2026-03-16)
+- Total plans completed: 91 (70 across v1.1-v2.3 + 10 in v3.0 + 8 in v3.1 + 3 in v3.2)
+- Total milestones shipped: 14 (v1.1 through v3.2)
+- Timeline: 48 days (2026-01-29 to 2026-03-17)
 
 ## Accumulated Context
 
diff --git a/.planning/milestones/v3.2-MILESTONE-AUDIT.md b/.planning/milestones/v3.2-MILESTONE-AUDIT.md
@@ -0,0 +1,93 @@
+---
+milestone: v3.2
+audited: 2026-03-17T12:30:00Z
+status: passed
+scores:
+  requirements: 5/5
+  phases: 2/2
+  integration: 8/8
+  flows: 4/4
+gaps:
+  requirements: []
+  integration: []
+  flows: []
+tech_debt:
+  - phase: 46-shared-deck-interaction
+    items:
+      - "CardListScreen handleCardPress silently no-ops when repository is null (empty deck edge case before sync) — affects DECK-03 in non-realistic scenario only"
+nyquist:
+  compliant_phases: []
+  partial_phases: []
+  missing_phases: [45, 46]
+  overall: missing
+---
+
+# Milestone v3.2: Deck Management UX — Audit Report
+
+**Audited:** 2026-03-17
+**Status:** passed
+**Phases:** 45-46 (2 phases, 3 plans)
+
+## Milestone Definition of Done
+
+Migliorare la gestione dei mazzi condivisi nell'app Android — riordino tab, nascondi repo piattaforma, e parità funzionale (swipe unsubscribe, tap per carte) con i repo normali.
+
+## Requirements Coverage (3-Source Cross-Reference)
+
+| REQ-ID | Description | VERIFICATION.md | SUMMARY Frontmatter | REQUIREMENTS.md | Final Status |
+|--------|-------------|-----------------|---------------------|-----------------|--------------|
+| NAV-01 | Tab Discovery prima di Repository | passed (Phase 45) | 45-01-SUMMARY | [x] | **satisfied** |
+| REPO-01 | Repo lumio-decks nascosto dalla lista | passed (Phase 45) | 45-01-SUMMARY | [x] | **satisfied** |
+| DECK-01 | Swipe unsubscribe con cancellazione dati studio | passed (Phase 46) | 46-01, 46-02 SUMMARY | [x] | **satisfied** |
+| DECK-02 | Tap mazzo condiviso per lista carte filtrate | passed (Phase 46) | 46-01, 46-02 SUMMARY | [x] | **satisfied** |
+| DECK-03 | Navigazione da mazzo condiviso a dettaglio carta | passed (Phase 46) | 46-02 SUMMARY | [x] | **satisfied** |
+
+**Orphaned requirements:** None
+**Unsatisfied requirements:** None
+
+## Phase Verifications
+
+| Phase | Status | Score | Gaps |
+|-------|--------|-------|------|
+| 45 - Navigation & Display Cleanup | passed | 4/4 | None |
+| 46 - Shared Deck Interaction | passed | 9/9 | None |
+
+## Integration Check
+
+| Metric | Result |
+|--------|--------|
+| Connected exports | 8/8 |
+| Orphaned exports | 0 |
+| Missing connections | 0 |
+| Auth-protected routes | All |
+
+### E2E Flows
+
+| Flow | Requirements | Status |
+|------|-------------|--------|
+| Discovery → Subscribe → Repos → Swipe unsubscribe | DECK-01 | Complete |
+| Discovery → Subscribe → Repos → Tap → Card list → Card detail | DECK-02, DECK-03 | Complete (latent edge case) |
+| Platform repo hidden + manual add rejected | REPO-01 | Complete |
+| Tab order correct | NAV-01 | Complete |
+
+## Tech Debt
+
+### Phase 46: Shared Deck Interaction
+- `CardListScreen.tsx` line 104: `handleCardPress` silently no-ops when `repository` is null. The fallback Repository is only constructed when `allCards.length > 0`. For empty shared decks (pre-sync), tapping would do nothing. In practice: empty list means nothing to tap, so not user-visible. Minimal fix: build fallback unconditionally when `subfolderPath` is set, or show error toast in else branch.
+
+**Total:** 1 item across 1 phase
+
+## Nyquist Compliance
+
+| Phase | VALIDATION.md | Compliant | Action |
+|-------|---------------|-----------|--------|
+| 45 | missing | — | `/gsd:validate-phase 45` |
+| 46 | missing | — | `/gsd:validate-phase 46` |
+
+## UAT Results
+
+Phase 46 UAT completed: 6/6 tests passed, 0 issues.
+
+---
+_Audited: 2026-03-17_
+_Auditor: Claude (audit-milestone)_
diff --git a/.planning/milestones/v3.2-REQUIREMENTS.md b/.planning/milestones/v3.2-REQUIREMENTS.md
@@ -0,0 +1,61 @@
+# Requirements Archive: v3.2 Deck Management UX
+
+**Archived:** 2026-03-17
+**Status:** SHIPPED
+
+For current requirements, see `.planning/REQUIREMENTS.md`.
+
+---
+
+# Requirements: Lumio
+
+**Defined:** 2026-03-17
+**Core Value:** Gli utenti studiano concetti tramite quiz generati dall'AI — il contenuto viene dai repository Git, le domande vengono generate e pre-cachate dal sistema.
+
+## v3.2 Requirements
+
+Requirements for Deck Management UX milestone. Each maps to roadmap phases.
+
+### Navigation
+
+- [x] **NAV-01**: Tab Discovery appare prima di tab Repository nella bottom navigation
+
+### Repository Display
+
+- [x] **REPO-01**: Il repository condiviso lumio-decks non appare nella lista repository
+
+### Shared Decks
+
+- [x] **DECK-01**: L'utente può disiscriversi da un mazzo condiviso tramite swipe a sinistra nella pagina Repository (con cancellazione dati studio)
+- [x] **DECK-02**: L'utente può fare tap su un mazzo condiviso per vedere la lista carte filtrate per subfolder
+- [x] **DECK-03**: L'utente può navigare dal mazzo condiviso al dettaglio singola carta (markdown preview, code, LaTeX, immagini)
+
+## Future Requirements
+
+None — focused milestone.
+
+## Out of Scope
+
+| Feature | Reason |
+|---------|--------|
+| Modifica carte da app Android | Il deck builder web è l'editor, l'app è per lo studio |
+| Gestione metadata mazzo da app | deck.yaml si gestisce dal deck builder web |
+
+## Traceability
+
+| Requirement | Phase | Status |
+|-------------|-------|--------|
+| NAV-01 | Phase 45 | Complete |
+| REPO-01 | Phase 45 | Complete |
+| DECK-01 | Phase 46 | Complete |
+| DECK-02 | Phase 46 | Complete |
+| DECK-03 | Phase 46 | Complete |
+
+**Coverage:**
+- v3.2 requirements: 5 total
+- Mapped to phases: 5
+- Unmapped: 0
+
+---
+*Requirements defined: 2026-03-17*
+*Last updated: 2026-03-17 after roadmap creation*
diff --git a/.planning/milestones/v3.2-ROADMAP.md b/.planning/milestones/v3.2-ROADMAP.md
